From 2be16c4f3fa80c8d484f8bd3e90b1c2b852854cd Mon Sep 17 00:00:00 2001
From: genisis0x <manietdavv@gmail.com>
Date: Thu, 14 May 2026 14:10:44 +0530
Subject: [PATCH] fix(setup): symlink skill bin/ dirs so PreToolUse hooks
 resolve (#1459)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`link_claude_skill_dirs` previously only symlinked SKILL.md into the
top-level skill directory, leaving `bin/` behind. PreToolUse hook
frontmatter references \/bin/<script>; with no symlink
the path resolves to a non-existent target and the hook silently
no-ops. The same defect affects every skill that ships scripts -
freeze, careful, browse, etc.

Now creates a directory symlink for `bin/` alongside the existing
SKILL.md symlink. Idempotent (rm + ln -snf) and tolerant of a prior
real-directory entry at the target path. Source: issue #1459 §1.

Defects §2 (registering PreToolUse hooks in user settings.json) and
§3 (runtime path resolution) are out of scope; they need a separate
design discussion about whether the setup script should mutate
`~/.claude/settings.json` on user behalf.
---
 setup | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/setup b/setup
index e4d31f881..f17544d18 100755
--- a/setup
+++ b/setup
@@ -577,6 +577,18 @@ link_claude_skill_dirs() {
         if [ -e "$target/sections" ] || [ -L "$target/sections" ]; then rm -rf "$target/sections"; fi
         _link_or_copy "$gstack_dir/$dir_name/sections" "$target/sections"
       fi
+      # Also link bin/ when the source skill ships one. PreToolUse hook
+      # frontmatter references $CLAUDE_SKILL_DIR/bin/<script>; without
+      # this link those paths resolve to a non-existent target and the
+      # hook silently no-ops (issue #1459). Same fix applies to every
+      # skill that publishes scripts -- freeze, careful, browse, etc.
+      # Routes through _link_or_copy so Windows installs without
+      # Developer Mode get a directory copy instead of a frozen symlink.
+      if [ -d "$gstack_dir/$dir_name/bin" ]; then
+        if [ -L "$target/bin" ]; then rm "$target/bin"; fi
+        if [ -e "$target/bin" ] && [ ! -L "$target/bin" ]; then rm -rf "$target/bin"; fi
+        _link_or_copy "$gstack_dir/$dir_name/bin" "$target/bin"
+      fi
       linked+=("$link_name")
     fi
   done