RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test(tests): allow Step 1.5 pr-prep gate as a ship sub-step 

The new `## Step 1.5` heading in `ship/SKILL.md.tmpl` (the pr-prep
gate) tripped the step-numbering checks in `skill-validation`, which
only permit a closed set of fractional sub-steps. Add `1.5` to
`ALLOWED_SUBSTEPS` so the gate heading is recognised as intentional.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Benjamin D. Smith 2026-06-10 14:26:03 +10:00
parent 6b4bf39142
commit d56c408e03
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/skill-validation.test.ts
View File

@ -1207,9 +1207,10 @@ describe('Step 3.4 test coverage audit', () => {
describe('ship step numbering', () => {
// Allowed sub-steps that are resolver-generated and intentionally nested:
// 8.1 (Plan Verification), 8.2 (Scope Drift), 9.1 (Review Army), 9.2 (Findings Merge),
// 1.5 (Upstream duplicate audit — pr-prep gate), 8.1 (Plan Verification),
// 8.2 (Scope Drift), 9.1 (Review Army), 9.2 (Findings Merge),
// 9.3 (Cross-review dedup), 15.0 (WIP squash — continuous checkpoint), 15.1 (Bisectable commits).
const ALLOWED_SUBSTEPS = new Set(['8.1', '8.2', '9.1', '9.2', '9.3', '15.0', '15.1']);
const ALLOWED_SUBSTEPS = new Set(['1.5', '8.1', '8.2', '9.1', '9.2', '9.3', '15.0', '15.1']);
test('ship/SKILL.md.tmpl contains no unexpected fractional step numbers', () => {
const tmpl = fs.readFileSync(path.join(ROOT, 'ship', 'SKILL.md.tmpl'), 'utf-8');