From dc4be9c70d8b71c0eae7d6c6b46c86a2bdd49ee8 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 7 Aug 2026 13:29:34 -0700 Subject: [PATCH] fix(test): observability check 11 floor 6 -> 5 after shell-free spawn removed promptFile unlink MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit aa3bd6f0 deleted the prompt temp file (and its /* non-fatal */ marker) when it dropped shell interpolation. The invariant — every runner I/O path wrapped non-fatally — still holds at the 5 remaining sites, now named in the comment. Co-Authored-By: Claude Fable 5 --- test/helpers/observability.test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/helpers/observability.test.ts b/test/helpers/observability.test.ts index 67b588fb7..7ca812965 100644 --- a/test/helpers/observability.test.ts +++ b/test/helpers/observability.test.ts @@ -92,9 +92,10 @@ describe('session-runner observability', () => { ); // Count non-fatal comments — should be present for each new I/O path const nonFatalCount = (src.match(/\/\* non-fatal \*\//g) || []).length; - // Original had 2 (promptFile unlink + failure transcript), we added 4 more - // (runDir creation, progress.log, heartbeat, NDJSON append) - expect(nonFatalCount).toBeGreaterThanOrEqual(6); + // Five wrapped I/O sites: runDir creation, progress.log append, heartbeat + // write, per-test NDJSON append, failure-transcript write. (Was 6 until + // the shell-free spawn removed the promptFile unlink and its marker.) + expect(nonFatalCount).toBeGreaterThanOrEqual(5); }); });