From e259ec1dde368ef0bd1479ce00090f72fb2af3ae Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 8 May 2026 21:47:02 -0700 Subject: [PATCH] ci(windows): extend free-tests lane to cover icacls + Bun.which resolvers from fix-wave PRs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #1306/#1307/#1308 validation gap. The four newly-added test files already have process.platform guards so they run safely on both POSIX and Windows lanes — only platform-relevant assertions execute on each. Tests added to the windows-latest lane: - browse/test/file-permissions.test.ts (#1308 icacls + writeSecureFile) - browse/test/security.test.ts (#1306 bash.exe wrap pure-function path) - make-pdf/test/browseClient.test.ts (#1307 Bun.which browse resolver) - make-pdf/test/pdftotext.test.ts (#1307 Bun.which pdftotext resolver) --- .github/workflows/windows-free-tests.yml | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.github/workflows/windows-free-tests.yml b/.github/workflows/windows-free-tests.yml index 69e71a8b6..1b0d5c793 100644 --- a/.github/workflows/windows-free-tests.yml +++ b/.github/workflows/windows-free-tests.yml @@ -91,8 +91,17 @@ jobs: continue-on-error: true - name: Verify new portability work on Windows - # 31 tests targeting the new code paths added by v1.20.0.0. These - # MUST pass for the release-note headline ("curated Windows lane added") - # to be truthful. - run: bun test test/gstack-paths.test.ts browse/test/claude-bin.test.ts test/test-free-shards.test.ts + # Tests targeting the v1.20.0.0 lane plus v1.30.0.0 fix-wave additions. + # v1.30.0.0 extension covers icacls hardening (#1308), bash.exe telemetry + # wrap (#1306), and Bun.which-based binary resolvers (#1307). These must + # pass on Windows for the wave's "Windows hardening" framing to be honest. + run: | + bun test \ + test/gstack-paths.test.ts \ + browse/test/claude-bin.test.ts \ + test/test-free-shards.test.ts \ + browse/test/file-permissions.test.ts \ + browse/test/security.test.ts \ + make-pdf/test/browseClient.test.ts \ + make-pdf/test/pdftotext.test.ts shell: bash