From f77bbe7091f873903b000448ac4d2f1bdb2e7ce3 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 14 Aug 2026 18:40:51 -0700 Subject: [PATCH] =?UTF-8?q?test(update-check):=20fixture=20links=20gstack-?= =?UTF-8?q?egress-lib.sh=20=E2=80=94=20all=2038=20tests=20failed=20on=20ma?= =?UTF-8?q?in?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit v1.63.0.0 made bin/gstack-update-check source bin/gstack-egress-lib.sh unconditionally, but the test fixture's GSTACK_DIR only linked gstack-config — every test died at the source line (0/38 pass on pristine main, verified). The suite-truncation bug hid it: the runner was killed by an earlier file's delayed process.exit before this file ran. Link the lib like the real install layout the script assumes. Co-Authored-By: Claude Fable 5 --- browse/test/gstack-update-check.test.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/browse/test/gstack-update-check.test.ts b/browse/test/gstack-update-check.test.ts index 0edd366e4..104a2e04b 100644 --- a/browse/test/gstack-update-check.test.ts +++ b/browse/test/gstack-update-check.test.ts @@ -42,6 +42,14 @@ beforeEach(() => { const binDir = join(gstackDir, 'bin'); mkdirSync(binDir); symlinkSync(join(import.meta.dir, '..', '..', 'bin', 'gstack-config'), join(binDir, 'gstack-config')); + // v1.63+: the script sources bin/gstack-egress-lib.sh unconditionally + // (receipted fetch helpers). A real install always has it beside + // gstack-config; without this link every test failed at the source line — + // masked until the suite-truncation fix because the runner died first. + symlinkSync( + join(import.meta.dir, '..', '..', 'bin', 'gstack-egress-lib.sh'), + join(binDir, 'gstack-egress-lib.sh'), + ); }); afterEach(() => {