mirror of https://github.com/garrytan/gstack.git
b5c65c70cc
The /plan-eng-review skill failed to fire AskUserQuestion on a real plan review and surfaced 4 calibration decisions via prose instead. Investigation traced this to a "fallback when neither variant is callable" clause in the preamble that the model rationalizes around as a general escape hatch from "fanning out round-trip AUQs," even when an AUQ variant IS callable. Codex review confirmed the fallback exists in 8 inline sites with 2 surviving escape hatches the original narrowing missed (a "genuinely trivial" exception duplicated across all 4 plan-* templates, and a "outside plan mode, output as prose and stop" branch in the preamble itself). Net deletion in skill text. Closes both branches of the deleted fallback (plan-file write AND prose-and-stop) and the trivial-fix exception with a single hard rule: If no AskUserQuestion variant appears in your tool list, this skill is BLOCKED. Stop, report `BLOCKED — AskUserQuestion unavailable`, and wait for the user. Honest about being a model directive, not a runtime guard — none of the PTY harness helpers enforce BLOCKED today. The architectural improvement is that the model has fewer alternatives to obey it against. Runtime enforcement is a follow-up TODO. Sources changed: - scripts/resolvers/preamble/generate-ask-user-format.ts: delete both fallback branches; replace with 1-line BLOCKED rule - scripts/resolvers/preamble/generate-completion-status.ts: delete fallback in generatePlanModeInfo - plan-eng-review/SKILL.md.tmpl: delete fallback at Step 0 + Sections 1-4 (5 instances) + delete trivial-fix exception - office-hours/SKILL.md.tmpl: delete fallback in approach-selection - plan-ceo-review/SKILL.md.tmpl: delete trivial-fix exception - plan-design-review/SKILL.md.tmpl: delete trivial-fix exception - plan-devex-review/SKILL.md.tmpl: delete trivial-fix exception Generated SKILL.md regen lands in a follow-up commit per the bisect convention (template changes separate from regenerated output). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| generate-ask-user-format.ts | ||
| generate-brain-health-instruction.ts | ||
| generate-brain-sync-block.ts | ||
| generate-completeness-section.ts | ||
| generate-completion-status.ts | ||
| generate-confusion-protocol.ts | ||
| generate-context-health.ts | ||
| generate-context-recovery.ts | ||
| generate-continuous-checkpoint.ts | ||
| generate-lake-intro.ts | ||
| generate-preamble-bash.ts | ||
| generate-proactive-prompt.ts | ||
| generate-repo-mode-section.ts | ||
| generate-routing-injection.ts | ||
| generate-search-before-building.ts | ||
| generate-spawned-session-check.ts | ||
| generate-telemetry-prompt.ts | ||
| generate-test-failure-triage.ts | ||
| generate-upgrade-check.ts | ||
| generate-vendoring-deprecation.ts | ||
| generate-voice-directive.ts | ||
| generate-writing-style-migration.ts | ||
| generate-writing-style.ts | ||