gstack/browse/test
gus 693eadf6f3
security: validate --from-file payload paths for parity with direct paths
The direct `load-html <file>` path runs every caller-supplied file path
through validateReadPath() so reads stay confined to SAFE_DIRECTORIES
(cwd, TEMP_DIR). The `load-html --from-file <payload.json>` shortcut
and its sibling `pdf --from-file <payload.json>` skipped that check and
went straight to fs.readFileSync(). An MCP caller that picks the
payload path (or any caller whose payload argument is reachable from
attacker-influenced text) could use --from-file as a read-anywhere
escape hatch for the safe-dirs policy.

Fix: call validateReadPath(path.resolve(payloadPath)) before readFileSync
at both sites. Error surface mirrors the direct-path branch so ops and
agent errors stay consistent.

Test coverage in browse/test/from-file-path-validation.test.ts:
  - source-level: validateReadPath precedes readFileSync in the load-html
    --from-file branch (write-commands.ts) and the pdf --from-file parser
    (meta-commands.ts)
  - error-message parity: both sites reference SAFE_DIRECTORIES

Related security audit pattern: R3 F002 (validateNavigationUrl gap on
download/scrape) and R3 F008 (markHiddenElements gap on 10 DOM commands)
were the same shape — a defense that existed on the primary code path
but not its shortcut sibling. This PR closes the same class of gap on
the --from-file shortcuts.
2026-04-21 20:35:13 -07:00
..
fixtures feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
activity.test.ts
…
adversarial-security.test.ts
…
batch.test.ts
…
browser-manager-unit.test.ts
…
build.test.ts
…
bun-polyfill.test.ts
…
commands.test.ts
…
compare-board.test.ts
…
config.test.ts
…
content-security.test.ts security: extend hidden-element detection to all DOM-reading channels 2026-04-21 20:34:27 -07:00
cookie-import-browser.test.ts
…
cookie-picker-routes.test.ts
…
data-platform.test.ts
…
dual-listener.test.ts test(security): add source-level guards for dual-listener architecture 2026-04-21 20:31:56 -07:00
dx-polish.test.ts
…
error-handling.test.ts
…
file-drop.test.ts
…
find-browse.test.ts
…
findport.test.ts
…
from-file-path-validation.test.ts security: validate --from-file payload paths for parity with direct paths 2026-04-21 20:35:13 -07:00
gstack-config.test.ts
…
gstack-update-check.test.ts
…
handoff.test.ts
…
learnings-injection.test.ts
…
path-validation.test.ts
…
pdf-flags.test.ts
…
platform.test.ts
…
security-adversarial-fixes.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-adversarial.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-audit-r2.test.ts
…
security-bench.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-bunnative.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-classifier.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-e2e-fullstack.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-integration.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-live-playwright.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-review-flow.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-review-fullstack.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-review-sidepanel-e2e.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-sidepanel-dom.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security-source-contracts.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
security.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
server-auth.test.ts feat(security): dual-listener tunnel architecture 2026-04-21 20:31:43 -07:00
sidebar-agent-roundtrip.test.ts
…
sidebar-agent.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
sidebar-integration.test.ts
…
sidebar-security.test.ts feat(security): ML prompt injection defense for sidebar (v1.4.0.0) (#1089) 2026-04-20 22:18:37 +08:00
sidebar-unit.test.ts
…
sidebar-ux.test.ts
…
snapshot.test.ts
…
state-ttl.test.ts
…
tab-isolation.test.ts
…
test-server.ts
…
token-registry.test.ts
…
url-validation.test.ts security: gate download + scrape through validateNavigationUrl (SSRF) 2026-04-21 20:33:44 -07:00
watch.test.ts
…
watchdog.test.ts
…
welcome-page.test.ts
…