gstack/plan-eng-review
Tim Linnet 20ae32aec5 feat(plan-eng-review): flag optimistic-UI on a server-gated action as a code-quality check
Adds one Code-quality-review bullet: for an action whose real effect is gated or
actuated server-side (auth/permission/validation), check that the client awaits and
surfaces the real result rather than optimistically assuming success. Optimistic
status + a swallowed rejection renders as a false success — a green check while the
server quietly rejected and nothing happened.

The catalog already has general "silent failure / swallowed error" framing in the
adversarial /ship pass; this names the specific, common client↔server variant so an
eng-review reviewer checks the effect landed, not the toast. Source edited in the
section template; generated section doc regenerated via `bun run gen:skill-docs`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 19:55:14 -07:00
..
sections feat(plan-eng-review): flag optimistic-UI on a server-gated action as a code-quality check 2026-06-04 19:55:14 -07:00
SKILL.md v1.56.0.0 Token-reduction Phase B + AUQ paranoid safety net (#1849) 2026-06-04 11:14:43 -07:00
SKILL.md.tmpl v1.56.0.0 Token-reduction Phase B + AUQ paranoid safety net (#1849) 2026-06-04 11:14:43 -07:00