mirror of https://github.com/garrytan/gstack.git
269 lines
13 KiB
TypeScript
269 lines
13 KiB
TypeScript
/**
|
|
* Offline-posture sanitizer tests — raw-HTML fetch vectors beyond <img src>
|
|
* (which the image inliner owns). No Playwright, no PDF generation.
|
|
*
|
|
* Regression for: <style>@import, inline style="…url(https://…)…", and
|
|
* <img srcset> surviving sanitizeUntrustedHtml, letting Chromium fetch
|
|
* remote resources at print time with no --allow-network.
|
|
*/
|
|
|
|
import { describe, expect, test } from "bun:test";
|
|
|
|
import { render, sanitizeUntrustedHtml } from "../src/render";
|
|
|
|
describe("sanitizeUntrustedHtml (offline fetch vectors)", () => {
|
|
test("strips @import url(...) from raw <style> blocks, keeps legit rules", () => {
|
|
const input = `<style>@import url("https://evil.example/track.css");\nh1 { color: red; }</style>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("@import");
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("color: red");
|
|
});
|
|
|
|
test("strips string-form @import (no url())", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>@import "https://evil.example/a.css";</style>`);
|
|
expect(out).not.toContain("@import");
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes remote url() inside <style> blocks", () => {
|
|
const input = `<style>body { background: url(https://evil.example/px.gif); color: blue; }</style>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
expect(out).toContain("color: blue");
|
|
});
|
|
|
|
test("neutralizes remote url() in inline style attributes", () => {
|
|
const input = `<div style="background:url(https://evil.example/px.gif);padding:4px">x</div>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
expect(out).toContain("padding:4px");
|
|
});
|
|
|
|
test("neutralizes protocol-relative url(//…) in style attributes", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(//evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
// ── Bypass regressions: unquoted style attributes ──
|
|
// HTML spec: an unquoted attribute value runs until whitespace or `>`, so
|
|
// <div style=background:url(https://…)> is live markup Chromium honors.
|
|
// The original neutralizer only rewrote quoted values.
|
|
|
|
test("neutralizes remote url() in UNQUOTED style attributes", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style=background:url(https://evil.example/px.gif)>x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
});
|
|
|
|
test("keeps local url() in unquoted style attributes functional", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style=background:url(local.png)>x</div>`);
|
|
expect(out).toContain("url(local.png)");
|
|
});
|
|
|
|
// ── Bypass regressions: CSS-escape obfuscation ──
|
|
// Chromium decodes CSS ident/string escapes before fetching, so \69 → i and
|
|
// \68 → h defeat literal-pattern matching. Untrusted styling has no
|
|
// legitimate need for escaped url schemes or at-rule names — fail closed.
|
|
|
|
test("drops CSS-escaped @import (@\\69mport url(...)) in <style> blocks", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>@\\69mport url("https://evil.example/a.css");</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).not.toMatch(/@\\/); // no escaped at-rule survives for Chromium to decode
|
|
});
|
|
|
|
test("drops CSS-escaped string-form @import (@\\69mport \"https://…\")", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>@\\69mport "https://evil.example/a.css";</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).not.toMatch(/@\\/);
|
|
});
|
|
|
|
test("neutralizes CSS-escaped scheme inside url() (\\68ttps://…)", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>body{background:url("\\68ttps://evil.example/px.gif")}</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes CSS-escaped function names (u\\72l(https://…))", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>body{background:u\\72l(https://evil.example/px.gif)}</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes HTML-entity-encoded backslash escapes in style attributes", () => {
|
|
// Attribute values are entity-decoded by the HTML parser before the CSS
|
|
// parser runs, so \68ttps reaches Chromium as \68ttps → https.
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url('\68ttps://evil.example/px.gif')">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
// ── Bypass regressions: non-backslash entity obfuscation in style attrs ──
|
|
// The same attribute entity layer can hide ANY character of a fetch vector,
|
|
// not just backslashes: h → h, / → /. <style> BLOCKS don't need
|
|
// this handling — element content is raw text, never attribute-decoded.
|
|
|
|
test("neutralizes numeric-entity-obfuscated scheme in style attributes (https)", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(https://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes entity-obfuscated slashes in style attributes (// for //)", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(https://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes entity-obfuscated url( name in style attributes (url)", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(https://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("entity-decoded local styles stay functional and safely re-encoded", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="content:"hi";background:url(local.png)">x</div>`);
|
|
expect(out).toContain("url(local.png)");
|
|
expect(out).toContain(""hi"");
|
|
});
|
|
|
|
test("double-encoded entities are not double-decoded into a live scheme", () => {
|
|
// Browser decodes &#104; exactly once → literal https://… text,
|
|
// which is not a scheme. The sanitizer must mirror that single decode:
|
|
// decoding twice would CREATE url(https://…) where the browser sees none.
|
|
const out = sanitizeUntrustedHtml(`<div style="background:url(&#104;ttps://evil.example/px.gif)">x</div>`);
|
|
expect(out).not.toMatch(/url\(\s*https:/);
|
|
});
|
|
|
|
test("strips srcset with a remote candidate, leaves src for the inliner", () => {
|
|
const input = `<img src="local.png" srcset="local.png 1x, https://evil.example/x.png 2x">`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("srcset");
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain(`src="local.png"`);
|
|
});
|
|
|
|
test("strips unquoted remote srcset", () => {
|
|
const out = sanitizeUntrustedHtml(`<img src="a.png" srcset=https://evil.example/x.png>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("keeps local-only srcset (no network vector)", () => {
|
|
const input = `<img src="a.png" srcset="a.png 1x, a@2x.png 2x">`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`srcset="a.png 1x, a@2x.png 2x"`);
|
|
});
|
|
|
|
// ── Bypass regressions: SVG remote-fetch vectors ──
|
|
// The svg handling only stripped <script> and the javascript: scheme, so a
|
|
// plain https:// href on <image>/<use>/<feImage> survived and Chromium
|
|
// fetched it at print time.
|
|
|
|
test("neutralizes remote <image href> inside <svg> blocks", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><image href="https://evil.example/x.png"/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain(`href="#"`);
|
|
});
|
|
|
|
test("neutralizes remote <use xlink:href> inside <svg> blocks", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><use xlink:href="https://evil.example/defs.svg#icon"/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes protocol-relative and unquoted svg hrefs", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><image href=//evil.example/x.png /><use href='//evil.example/d.svg#i'/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes remote svg-element href even when the <svg> is never closed", () => {
|
|
// Chromium auto-closes an unclosed <svg> at EOF and still fetches.
|
|
const out = sanitizeUntrustedHtml(`<svg><image href="https://evil.example/x.png">`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes entity-obfuscated remote svg href (https)", () => {
|
|
const out = sanitizeUntrustedHtml(`<svg><image href="https://evil.example/x.png"/></svg>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("keeps local fragment href (#id) inside svg intact", () => {
|
|
const input = `<svg><defs><circle id="dot" r="2"/></defs><use href="#dot"/><use xlink:href="#dot"/></svg>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).toContain(`href="#dot"`);
|
|
expect(out).toContain(`xlink:href="#dot"`);
|
|
});
|
|
|
|
test("keeps local-file svg <image href> intact", () => {
|
|
expect(sanitizeUntrustedHtml(`<svg><image href="local.png"/></svg>`)).toContain(`href="local.png"`);
|
|
});
|
|
|
|
test("leaves regular <a href=\"https://…\"> hyperlinks alone (links don't fetch at print)", () => {
|
|
const input = `<a href="https://example.com/docs">docs</a>`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`href="https://example.com/docs"`);
|
|
});
|
|
|
|
// ── Bypass regressions: image-set() with bare quoted URL strings ──
|
|
// `image-set("https://…" 1x)` carries no url() token and no backslash, so
|
|
// the url()/escape passes never fired on it.
|
|
|
|
test("neutralizes remote image-set(...) in <style> blocks", () => {
|
|
const input = `<style>body { background: image-set("https://evil.example/a.png" 1x); color: blue; }</style>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
expect(out).toContain("url(#)");
|
|
expect(out).toContain("color: blue");
|
|
});
|
|
|
|
test("neutralizes remote image-set(...) in style attributes", () => {
|
|
const out = sanitizeUntrustedHtml(`<div style="background: image-set('https://evil.example/a.png' 1x)">x</div>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("neutralizes -webkit-image-set with a remote string argument", () => {
|
|
const out = sanitizeUntrustedHtml(`<style>body{background:-webkit-image-set("//evil.example/a.png" 1x)}</style>`);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("keeps local image-set(...) functional", () => {
|
|
const input = `<style>body { background: image-set("local.png" 1x, "local@2x.png" 2x); }</style>`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`image-set("local.png" 1x, "local@2x.png" 2x)`);
|
|
});
|
|
|
|
test("neutralizes remote <video poster> and <source src>", () => {
|
|
const input = `<video poster="https://evil.example/p.jpg"><source src="https://evil.example/v.mp4"></video>`;
|
|
const out = sanitizeUntrustedHtml(input);
|
|
expect(out).not.toContain("evil.example");
|
|
});
|
|
|
|
test("leaves remote <img src> alone — the image inliner owns its blocked-remote placeholder", () => {
|
|
const input = `<img src="https://evil.example/px.gif">`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain(`src="https://evil.example/px.gif"`);
|
|
});
|
|
|
|
test("does NOT rewrite url(https://…) mentioned in code/prose text", () => {
|
|
// marked entity-encodes quotes in code spans, so this is plain text
|
|
// outside any <style> block or style attribute — must stay intact.
|
|
const input = `<code>background: url(https://example.com/a.png)</code>`;
|
|
expect(sanitizeUntrustedHtml(input)).toContain("url(https://example.com/a.png)");
|
|
});
|
|
|
|
test("end-to-end: rendered document carries no remote fetch vector from raw HTML", () => {
|
|
const md = [
|
|
"# Doc",
|
|
`<style>@import url("https://evil.example/t.css"); h1{color:red}</style>`,
|
|
`<div style="background:url('https://evil.example/px.gif')">hi</div>`,
|
|
`<img src="a.png" srcset="https://evil.example/a.png 2x">`,
|
|
`<svg><image href="https://evil.example/s.png"/><use xlink:href="https://evil.example/d.svg#i"/></svg>`,
|
|
`<div style="background:image-set('https://evil.example/is.png' 1x)">x</div>`,
|
|
].join("\n\n");
|
|
const { bodyHtml } = render({ markdown: md });
|
|
expect(bodyHtml).not.toContain("evil.example");
|
|
});
|
|
|
|
test("end-to-end: unquoted and CSS-escaped vectors don't survive render()", () => {
|
|
const md = [
|
|
"# Doc",
|
|
`<style>@\\69mport "https://evil.example/b.css"; body{background:url("\\68ttps://evil.example/px.gif")}</style>`,
|
|
`<div style=background:url(https://evil.example/px.gif)>hi</div>`,
|
|
].join("\n\n");
|
|
const { bodyHtml } = render({ markdown: md });
|
|
expect(bodyHtml).not.toContain("evil.example");
|
|
expect(bodyHtml).not.toMatch(/@\\/);
|
|
});
|
|
});
|