mirror of https://github.com/garrytan/gstack.git
5374987c6c
PR review feedback (garrytan/gstack#1071): the data-model bias guidance was
overly absolute ("diff size is NOT a goal", "three clean models... in all
respects", "JSONField is not an escape hatch") and lacked counterexamples for
cases where JSON columns or denormalization are the right call.
- "Data model exception to right-sized diff" bullet (both skills): reframes
from an absolute rule to "don't let diff size alone decide the shape",
explicitly allows denormalization backed by a measurement, and adds the
counterexample of a field that would only ever be read through one FK join
with no independent consumer.
- JSONField bullet (both skills): keeps the core diagnostic but adds concrete
legitimate uses — third-party webhook/OAuth payload caching, open-ended
preference bags, event payloads shaped by an external producer, and
schemas still being discovered.
- plan-eng-review cognitive patterns #11 (normalize first) and #13
(structure beats blobs) get the same measured-reason / known-polymorphism
counterexamples.
- Architecture Review's "Data model honesty" bullet and the "Single
Responsibility" and "JSONField as polymorphism escape hatch" checklist
items (now living in sections/review-sections.md.tmpl per main's carve
refactor) get matching nuance.
Bumps carve-guards.ts skeleton-size budgets for plan-eng-review (69_000 ->
70_000) and plan-ceo-review (91_000 -> 92_000) to cover the added prose;
verified against test/parity-suite.test.ts (13/13 pass) and
test/skill-validation.test.ts's load-bearing-bullet guardrails (still pass —
none of the anchor phrases the static tests check were removed).
|
||
|---|---|---|
| .. | ||
| providers | ||
| agent-sdk-runner.ts | ||
| auq-sdk-capture.ts | ||
| benchmark-judge.ts | ||
| benchmark-runner.ts | ||
| budget-override.test.ts | ||
| budget-override.ts | ||
| capture-parity-baseline.test.ts | ||
| capture-parity-baseline.ts | ||
| carve-guard-checks.ts | ||
| carve-guards.ts | ||
| claude-pty-runner.ts | ||
| claude-pty-runner.unit.test.ts | ||
| codex-session-runner.ts | ||
| e2e-helpers.ts | ||
| eval-store.test.ts | ||
| eval-store.ts | ||
| gemini-session-runner.test.ts | ||
| gemini-session-runner.ts | ||
| hermetic-env.test.ts | ||
| hermetic-env.ts | ||
| llm-judge.ts | ||
| observability.test.ts | ||
| parity-harness.ts | ||
| pricing.ts | ||
| required-reads.ts | ||
| secret-sink-harness.ts | ||
| session-runner.test.ts | ||
| session-runner.ts | ||
| skill-parser.ts | ||
| tool-map.ts | ||
| touchfiles.ts | ||
| transcript-section-logger.ts | ||