mirror of https://github.com/garrytan/gstack.git
665f979d57
Two ways `gstack-version-bump` left a release half-done, both silent. 1. It only ever looked at ./package.json. A repo whose only Node package lives in a subdirectory (web/, app/, frontend/) has no root manifest, so classify reported pkgExists:false and every bump wrote VERSION alone -- leaving the manifest to be edited by hand, which is the exact drift this tool exists to prevent, in the one layout where it silently did nothing. The path now resolves --package-json-path -> .gstack/package-json-path -> ./package.json, so a subdirectory package is covered by a one-line pin. 2. VERSION is 4-digit MAJOR.MINOR.PATCH.MICRO and npm's semver is 3-component: npm rejects the fourth. Mirroring VERSION 1:1 into an npm-managed manifest writes a version npm will not install. When a package-lock.json sits beside the manifest -- proof npm actually manages it -- the MICRO is now dropped (0.1.26.0 -> 0.1.26) and the lockfile's two version fields are mirrored too (root and packages[""], which npm keeps in step and nothing else in a release does, so a lockfile left behind drifts one field per bump until someone runs npm). Pure JSON edit, no npm spawn, no dependency-tree churn. Without a lockfile nothing validates the field, so the historical 1:1 mirror is preserved -- gstack's own package.json carries 1.60.1.0 and keeps doing so. classifyState needed an expectedPkg parameter for (2): it defaults to VERSION, but for an npm-managed manifest it is the 3-component truncation. Otherwise a correctly-synced 0.1.27 reads as drift against 0.1.27.0 forever and every classify returns DRIFT. Step 12 of the ship skill documents the new behaviour; the three ship-skill golden fixtures are updated to match the regenerated hosts. 7 new tests covering both sides, including the negatives: the pin, the override, both lockfile fields, the correctly-synced-is-not-drift case, repair, and the no-lockfile 4-digit path that must not change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| golden | ||
| ios-fix | ||
| ios-qa/FixtureApp | ||
| mode-posture | ||
| office-hours-brain-writeback | ||
| plans | ||
| coverage-audit-fixture.ts | ||
| eval-baselines.json | ||
| forcing-finding-seeds.ts | ||
| golden-ship-claude.md | ||
| overlay-nudges.ts | ||
| parity-baseline-v1.44.1.json | ||
| parity-baseline-v1.46.0.0.json | ||
| parity-baseline-v1.47.0.0.json | ||
| parity-baseline-v1.53.0.0.json | ||
| parity-baseline-v1.57.7.0.json | ||
| qa-eval-checkout-ground-truth.json | ||
| qa-eval-ground-truth.json | ||
| qa-eval-spa-ground-truth.json | ||
| review-army-migration.sql | ||
| review-army-n-plus-one.rb | ||
| review-eval-design-slop.css | ||
| review-eval-design-slop.html | ||
| review-eval-enum-diff.rb | ||
| review-eval-enum.rb | ||
| review-eval-vuln.rb | ||