mirror of https://github.com/garrytan/gstack.git
899b3be30f
Codex review pass 2 flagged a [P2]: Node emits 'error' but not 'exit' when the spawned binary is missing, so the lifecycle Promise that only listened to 'exit' hangs forever. `await proc.exited` waits until the caller's own timeout fires, which on a missing `bun`, `powershell`, or similar burns the full 10 s the DPAPI helper allows. Listen to both 'exit' and 'error' on the lifecycle Promise so spawn failures resolve immediately. Also add 'close' as a third resolve trigger on the pipe drains for the same reason — the stdio streams may fire 'close' without 'end' or 'error' when the process never started. Regression test asserts proc.exited resolves (not 'TIMEOUT') when the binary doesn't exist. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| scripts | ||
| src | ||
| test | ||
| PLAN-snapshot-dropdown-interactive.md | ||
| SKILL.md | ||
| SKILL.md.tmpl | ||