mirror of https://github.com/garrytan/gstack.git
The "Enum & Value Completeness" critical check already tells the reviewer to trace a new value through every consumer outside the diff. The same blind spot shows up when a change instead loosens what an input accepts (a new MIME type, extension, or flag): the code that breaks is usually unchanged, so it never appears in the diff. Broaden that category to cover widened-input acceptance, with a concrete example. Separately, add a small informational check for user-facing strings that go stale when the logic guarding them changes but the string itself doesn't. Same idea as the existing stale-CHANGELOG note, applied to in-code copy. Both came from a real review miss: a validator was loosened to accept a typeless .pdf, but an unchanged submit helper still coerced it to text/plain, so the file was sent as garbage instead of natively. The diff-scoped pass walked right past it. |
||
|---|---|---|
| .. | ||
| specialists | ||
| SKILL.md | ||
| SKILL.md.tmpl | ||
| TODOS-format.md | ||
| checklist.md | ||
| design-checklist.md | ||
| greptile-triage.md | ||