mirror of https://github.com/garrytan/gstack.git
17b556f309
Browser-skill spawns hit `403: Tab not owned by your agent` on every first run because the gate at server.ts:639 fired for any non-root write, regardless of the token's tabPolicy. The bundled hackernews-frontpage reference skill failed identically. Every /skillify-generated skill failed identically. The user's natural tabs have no claimed owner — by design — so any skill driving them via `goto` (a write) was 403'd. The intent in skill-token.ts:79 was always correct: `tabPolicy: 'shared'` with the comment "skill scripts may switch tabs as needed." The enforcement just ignored it. Two surgical changes: browser-manager.ts:checkTabAccess — gate now keys on options.ownOnly only. Shared-policy tokens (skill spawns, default scoped clients) get permissive access — root-equivalent for the tab gate. Own-only tokens (pair-agent over the ngrok tunnel) still require ownership for every read and write. isWrite stays in the signature for callers that want to log or branch elsewhere; it no longer gates the decision. server.ts:639 — gate predicate narrowed from (WRITE_COMMANDS.has(command) || tokenInfo.tabPolicy === 'own-only') to just tokenInfo.tabPolicy === 'own-only' The 'newtab' exemption stays. Shared tokens skip the gate entirely; own-only tokens still hit it. Comment block above the gate updated to document the new predicate intent. Pair-agent isolation is intact. Tunnel tokens still default to tabPolicy: 'own-only', still must `newtab` first to get a tab they can drive, still can't dispatch any of the 23 commands outside the tunnel allowlist. The capability gate (scope checks) and rate limits already constrain what local scoped clients can do; tab ownership was never a security boundary for them — only for pair-agent. This release makes the enforcement match the original design intent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| activity.ts | ||
| audit.ts | ||
| browse-client.ts | ||
| browser-manager.ts | ||
| browser-skill-commands.ts | ||
| browser-skill-write.ts | ||
| browser-skills.ts | ||
| buffers.ts | ||
| bun-polyfill.cjs | ||
| cdp-allowlist.ts | ||
| cdp-bridge.ts | ||
| cdp-commands.ts | ||
| cdp-inspector.ts | ||
| cli.ts | ||
| commands.ts | ||
| config.ts | ||
| content-security.ts | ||
| cookie-import-browser.ts | ||
| cookie-picker-routes.ts | ||
| cookie-picker-ui.ts | ||
| domain-skill-commands.ts | ||
| domain-skills.ts | ||
| error-handling.ts | ||
| find-browse.ts | ||
| media-extract.ts | ||
| meta-commands.ts | ||
| network-capture.ts | ||
| path-security.ts | ||
| platform.ts | ||
| project-slug.ts | ||
| pty-session-cookie.ts | ||
| read-commands.ts | ||
| security-bunnative.ts | ||
| security-classifier.ts | ||
| security.ts | ||
| server.ts | ||
| sidebar-utils.ts | ||
| skill-token.ts | ||
| snapshot.ts | ||
| sse-session-cookie.ts | ||
| tab-session.ts | ||
| telemetry.ts | ||
| terminal-agent.ts | ||
| token-registry.ts | ||
| tunnel-denial-log.ts | ||
| url-validation.ts | ||
| welcome.html | ||
| write-commands.ts | ||