mirror of https://github.com/garrytan/gstack.git
b9371d716e
* fix(learnings): accept type:"investigation" in gstack-learnings-log The /investigate skill instructed agents to log learnings with type:"investigation", but bin/gstack-learnings-log:22 rejected anything not in [pattern, pitfall, preference, architecture, tool, operational]. Every investigation run exited 1 to stderr and the learning was dropped, silently to the user. Fix: add 'investigation' to ALLOWED_TYPES. Regression test: round-trips a learning with type:"investigation" and asserts exit 0 + file write; second test reads investigate/SKILL.md.tmpl and asserts it emits the literal type:"investigation" string, guarding the template/validator contract at both ends. Fixes #1423. Reported by diogolealassis. * fix(gbrain): engine detection survives gbrain ≥0.25 schema + non-zero doctor exit freshDetectEngineTier() in lib/gstack-memory-helpers.ts returned engine: "unknown" for every Supabase user on gbrain ≥0.25. Two stacking bugs: 1. execSync("gbrain doctor --json --fast 2>/dev/null") threw on non-zero exit. gbrain doctor exits 1 whenever health_score < 100, which is essentially every fresh install due to resolver_health warnings. The JSON output never reached the parser. 2. gbrain ≥0.25 shipped schema_version:2 doctor output that dropped the top-level 'engine' field entirely. Result: every /sync-gbrain on Supabase logged 'engine=unknown' and skipped all sync stages silently. Fix: - Replace execSync with execFileSync (no shell, no bash-specific 2>/dev/null redirect; portable to Windows). - Recover stdout from the thrown error object so non-zero exits still parse. - Fall back to reading gbrain's config.json (respecting GBRAIN_HOME env var, defaulting to ~/.gbrain/config.json) when doctor output doesn't surface an engine field. - Add logGbrainError() helper that appends one-line JSONL to ~/.gstack/.gbrain-errors.jsonl on parse failure, so future regressions leave a forensic trail. The "supabase" tier here means "remote postgres" in practice — gbrain config uses engine:"postgres" for both real Supabase and any other remote postgres (e.g. local-postgres-for-testing). Downstream sync code treats them identically, so the label compression is intentional and documented inline. Regression test: existing detectEngineTier suite now isolates HOME + GBRAIN_HOME + PATH to temp dirs (closes a flake source where the prior tests would read whatever was on the reviewer's machine). New test forces gbrain off PATH, writes a synthetic config.json with engine:"postgres", asserts detectEngineTier() returns engine:"supabase". Fixes #1415. Patch shape contributed by Shiv @shivasymbl (tested on gstack v1.31.0.0 + gbrain v0.31.3 + Supabase). * fix(codex): /codex review works on Codex CLI ≥0.130.0 Codex CLI 0.130.0 made [PROMPT] and --base <BRANCH> mutually exclusive at argv level. Step 2A of codex/SKILL.md.tmpl had always passed both (the filesystem boundary prefix as the prompt argument + the base branch), so every /codex review call died with: error: the argument '[PROMPT]' cannot be used with '--base <BRANCH>' Fix: split Step 2A into two paths. Default (no custom user instructions): bare 'codex review --base <base>'. Codex's review prompt is internally diff-scoped, so the model focuses on the changes against base. The filesystem boundary prefix is dropped here because Codex 0.130 has no documented system-prompt config key (probed -c 'system_prompt="..."' against 0.130 — the flag is silently accepted but the value isn't applied). Skill files under .claude/ and agents/ are public, so this is a token-efficiency concern, not a safety one. Custom instructions (/codex review <focus>): route through codex exec with the diff written to a tempfile, inlined into the prompt between explicit DIFF_START / DIFF_END markers. The boundary is preserved here because codex exec isn't auto-scoped to the diff. The DIFF_START/END delimiters tell the model where data ends and instructions resume, which materially reduces prompt-injection hijack rates when the diff contains adversarial content. Note on bash semantics: codex's earlier review flagged the exec route as "command injection via $_DIFF interpolation." That framing is wrong — bash parameter expansion does not re-evaluate $(...) or backticks inside the expanded value, so a diff containing $(rm -rf /) is plain string data to codex exec. The real risk is prompt injection (model-side, not shell-side), which the DIFF_START/END pattern mitigates. Regression tests in test/codex-hardening.test.ts assert across BOTH codex/SKILL.md.tmpl AND the generated codex/SKILL.md: 1. No 'codex review' invocation line combines a quoted-string OR variable positional argument with --base. 2. Step 2A still contains either bare 'codex review --base' OR 'codex exec' (guards against accidental deletion of both fix paths). Fixes #1428. Reported by Stashub. * test: raise timeouts for slow integration tests Two test files were timing out at the default 5s on developer machines, both pre-existing on origin/main but unrelated to this branch's bug fixes: - test/gstack-artifacts-init.test.ts: 13 tests spawning real subprocesses via fake gh/glab/git shims in PATH. bun's fork+exec overhead pushed these past 5s consistently. Added a local test-wrapper that aliases test() with a 30s timeout (matches the brain-sync.test.ts pattern already in the repo). - test/gstack-next-version.test.ts: one integration smoke test that spawns 'bun run ./bin/gstack-next-version' and parses the resulting JSON. The subprocess does a 'gh pr list' against the live GitHub API to enumerate claimed version slots. Network latency makes 5s tight; raised this single test to 30s. No production code changed. The tests already passed deterministically once given enough wall-clock time. * chore: bump version and changelog (v1.34.2.0) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| helpers | ||
| agent-sdk-runner.test.ts | ||
| analytics.test.ts | ||
| audit-compliance.test.ts | ||
| benchmark-cli.test.ts | ||
| benchmark-runner.test.ts | ||
| brain-sync.test.ts | ||
| builder-profile.test.ts | ||
| codex-e2e-plan-format.test.ts | ||
| codex-e2e.test.ts | ||
| codex-hardening.test.ts | ||
| codex-resume-flag-semantics.test.ts | ||
| context-save-hardening.test.ts | ||
| diff-scope.test.ts | ||
| e2e-harness-audit.test.ts | ||
| explain-level-config.test.ts | ||
| gbrain-detect-install.test.ts | ||
| gbrain-lib-verify.test.ts | ||
| gbrain-repo-policy.test.ts | ||
| gbrain-sources.test.ts | ||
| gbrain-supabase-provision.test.ts | ||
| gemini-e2e.test.ts | ||
| gen-skill-docs.test.ts | ||
| global-discover.test.ts | ||
| gstack-artifacts-init.test.ts | ||
| gstack-artifacts-url.test.ts | ||
| gstack-brain-context-load.test.ts | ||
| gstack-developer-profile.test.ts | ||
| gstack-gbrain-detect-mcp-mode.test.ts | ||
| gstack-gbrain-mcp-verify.test.ts | ||
| gstack-gbrain-source-wireup.test.ts | ||
| gstack-gbrain-sync.test.ts | ||
| gstack-learnings-search.test.ts | ||
| gstack-memory-helpers.test.ts | ||
| gstack-memory-ingest.test.ts | ||
| gstack-next-version.test.ts | ||
| gstack-paths.test.ts | ||
| gstack-question-log.test.ts | ||
| gstack-question-preference.test.ts | ||
| gstack-upgrade-migration-v1_17_0_0.test.ts | ||
| helpers-unit.test.ts | ||
| hook-scripts.test.ts | ||
| host-config.test.ts | ||
| jargon-list.test.ts | ||
| learnings-injection.test.ts | ||
| learnings.test.ts | ||
| llm-judge-recommendation.test.ts | ||
| llms-txt-shape.test.ts | ||
| migration-checkpoint-ownership.test.ts | ||
| migrations-v1.27.0.0.test.ts | ||
| model-overlay-opus-4-7.test.ts | ||
| no-stale-gstack-brain-refs.test.ts | ||
| openclaw-native-skills.test.ts | ||
| plan-tune.test.ts | ||
| post-rename-doc-regen.test.ts | ||
| pr-title-rewrite.test.ts | ||
| preamble-compose.test.ts | ||
| readme-throughput.test.ts | ||
| relink.test.ts | ||
| resolver-ask-user-format.test.ts | ||
| review-log.test.ts | ||
| secret-sink-harness.test.ts | ||
| setup-codesign.test.ts | ||
| setup-conductor-worktree.test.ts | ||
| setup-gbrain-path4-structure.test.ts | ||
| ship-plan-completion-invariants.test.ts | ||
| ship-version-sync.test.ts | ||
| skill-budget-regression.test.ts | ||
| skill-collision-sentinel.test.ts | ||
| skill-cross-model-recommendation-emit.test.ts | ||
| skill-e2e-ask-user-question-format-compliance.test.ts | ||
| skill-e2e-auto-decide-preserved.test.ts | ||
| skill-e2e-autoplan-chain.test.ts | ||
| skill-e2e-autoplan-dual-voice.test.ts | ||
| skill-e2e-benchmark-providers.test.ts | ||
| skill-e2e-brain-privacy-gate.test.ts | ||
| skill-e2e-bws.test.ts | ||
| skill-e2e-context-skills.test.ts | ||
| skill-e2e-cso.test.ts | ||
| skill-e2e-deploy.test.ts | ||
| skill-e2e-design.test.ts | ||
| skill-e2e-learnings.test.ts | ||
| skill-e2e-memory-pipeline.test.ts | ||
| skill-e2e-office-hours-auto-mode.test.ts | ||
| skill-e2e-office-hours-phase4.test.ts | ||
| skill-e2e-office-hours.test.ts | ||
| skill-e2e-opus-47.test.ts | ||
| skill-e2e-overlay-harness.test.ts | ||
| skill-e2e-plan-ceo-finding-count.test.ts | ||
| skill-e2e-plan-ceo-finding-floor.test.ts | ||
| skill-e2e-plan-ceo-mode-routing.test.ts | ||
| skill-e2e-plan-ceo-plan-mode.test.ts | ||
| skill-e2e-plan-design-finding-count.test.ts | ||
| skill-e2e-plan-design-finding-floor.test.ts | ||
| skill-e2e-plan-design-plan-mode.test.ts | ||
| skill-e2e-plan-design-with-ui.test.ts | ||
| skill-e2e-plan-devex-finding-count.test.ts | ||
| skill-e2e-plan-devex-finding-floor.test.ts | ||
| skill-e2e-plan-devex-plan-mode.test.ts | ||
| skill-e2e-plan-eng-finding-count.test.ts | ||
| skill-e2e-plan-eng-finding-floor.test.ts | ||
| skill-e2e-plan-eng-multi-finding-batching.test.ts | ||
| skill-e2e-plan-eng-plan-mode.test.ts | ||
| skill-e2e-plan-format.test.ts | ||
| skill-e2e-plan-mode-no-op.test.ts | ||
| skill-e2e-plan-prosons.test.ts | ||
| skill-e2e-plan-tune.test.ts | ||
| skill-e2e-plan.test.ts | ||
| skill-e2e-qa-bugs.test.ts | ||
| skill-e2e-qa-workflow.test.ts | ||
| skill-e2e-review-army.test.ts | ||
| skill-e2e-review.test.ts | ||
| skill-e2e-session-intelligence.test.ts | ||
| skill-e2e-setup-gbrain-bad-token.test.ts | ||
| skill-e2e-setup-gbrain-remote.test.ts | ||
| skill-e2e-ship-idempotency.test.ts | ||
| skill-e2e-sidebar.test.ts | ||
| skill-e2e-skillify.test.ts | ||
| skill-e2e-workflow.test.ts | ||
| skill-e2e.test.ts | ||
| skill-llm-eval.test.ts | ||
| skill-parser.test.ts | ||
| skill-routing-e2e.test.ts | ||
| skill-validation.test.ts | ||
| taste-engine.test.ts | ||
| team-mode.test.ts | ||
| telemetry.test.ts | ||
| test-free-shards.test.ts | ||
| timeline.test.ts | ||
| touchfiles.test.ts | ||
| uninstall.test.ts | ||
| upgrade-migration-v1.test.ts | ||
| v0-dormancy.test.ts | ||
| worktree.test.ts | ||
| writing-style-resolver.test.ts | ||