RomanNum3ral
/
hermes-agent
mirror of https://github.com/NousResearch/hermes-agent.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test(desktop): widen HUD composer containment regression coverage (#82319) 

Extend the packaged-app HUD geometry test from horizontal-only to full
containment: both axes for the dock and the input, plus an explicit
assertion that no percentage translate survives on the composer dock.
The vertical clipping reported on Windows (#82203) and macOS (#82214)
is the same escape class on the other axis, and the computed-translate
probe makes a future optimizer regression fail with a diagnosis instead
of a bare coordinate mismatch.
This commit is contained in:
Teknium 2026-08-09 02:03:46 -07:00 committed by GitHub
parent 952f44f841
commit 085a9d332f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
apps/desktop/e2e/launch-packaged-app.spec.ts
View File

@ -71,18 +71,46 @@ test('HUD composer remains fully inside the transparent window', async () => {
return {
viewportWidth: window.innerWidth,
viewportHeight: window.innerHeight,
dockLeft: dockRect.left,
dockRight: dockRect.right,
dockTop: dockRect.top,
dockBottom: dockRect.bottom,
inputLeft: inputRect.left,
inputRight: inputRect.right,
inputTop: inputRect.top,
inputBottom: inputRect.bottom,
// The bug class this guards: a build-time CSS optimization folding the
// dock's identity `translate` override into `transform`, leaving
// Tailwind's standalone `translate: -50%` live and shifting the dock
// half a window off-screen. Surface the computed value so a failure
// says WHY the dock moved, not just that it did.
dockTranslate: getComputedStyle(dock).translate,
}
})
// Horizontal containment — the composer shifted half a window left when the
// standalone `translate: -50%` survived optimization (#82214, #82233).
expect(geometry.dockLeft).toBeGreaterThanOrEqual(0)
expect(geometry.inputLeft).toBeGreaterThanOrEqual(0)
expect(geometry.dockRight).toBeLessThanOrEqual(geometry.viewportWidth)
expect(geometry.inputRight).toBeLessThanOrEqual(geometry.viewportWidth)
// Vertical containment — the toolbar/transcript clipping reported on
// Windows (#82203) and macOS (#82214) is the same "composer escapes the
// window" class on the other axis.
expect(geometry.dockTop).toBeGreaterThanOrEqual(0)
expect(geometry.inputTop).toBeGreaterThanOrEqual(0)
expect(geometry.dockBottom).toBeLessThanOrEqual(geometry.viewportHeight)
expect(geometry.inputBottom).toBeLessThanOrEqual(geometry.viewportHeight)
// The dock's centering translate must be fully neutralized. Any live
// percentage translate means the HUD override lost to the app's centering.
// (Computed `translate` keeps percentages as-is, so this is assertable;
// computed `transform` resolves to a matrix and is covered by the
// geometric containment checks above.)
expect(geometry.dockTranslate ?? 'none').not.toContain('%')
await hudPage.close()
})