From 151e72a5fc808cd7f122f6894132f3ab2e63de06 Mon Sep 17 00:00:00 2001
From: kshitij <82637225+kshitijk4poor@users.noreply.github.com>
Date: Sat, 1 Aug 2026 12:31:12 +0530
Subject: [PATCH] refactor: simplify pairing check return and drop
 over-defensive getattr

Follow-up cleanup from /simplify-code review:
- Replace 'if X: return True / return False' with 'return X'
- Replace 'getattr(source, "chat_type", None) or ""' with 'source.chat_type'
  (SessionSource.chat_type is a non-optional str field)
---
 plugins/platforms/telegram/adapter.py | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/plugins/platforms/telegram/adapter.py b/plugins/platforms/telegram/adapter.py
index ffaae1db8d81c..4a430702e85e3 100644
--- a/plugins/platforms/telegram/adapter.py
+++ b/plugins/platforms/telegram/adapter.py
@@ -1039,7 +1039,7 @@ class TelegramAdapter(BasePlatformAdapter):
         operator explicitly opted back into pairing via a platform override
         (resolution rule 1 in ``_get_unauthorized_dm_behavior``).
         """
-        if (getattr(source, "chat_type", None) or "") != "dm":
+        if source.chat_type != "dm":
             return False
 
         runner = getattr(getattr(self, "_message_handler", None), "__self__", None)
@@ -1146,9 +1146,7 @@ class TelegramAdapter(BasePlatformAdapter):
         if authorized:
             return True
         # Unauthorized DM that the gateway would pair: forward so pairing can run.
-        if self._should_pass_unauthorized_dm_for_pairing(source):
-            return True
-        return False
+        return self._should_pass_unauthorized_dm_for_pairing(source)
 
     @classmethod
     def _metadata_thread_id(cls, metadata: Optional[Dict[str, Any]]) -> Optional[str]: