From 261c67b2f8526bac3555cbfb6e186e68ecaca7a9 Mon Sep 17 00:00:00 2001
From: Zeraphim <diamantejc87@gmail.com>
Date: Thu, 30 Jul 2026 20:18:58 +0800
Subject: [PATCH] fix(desktop): cover pending agent terminal font cleanup

---
 .../terminal/use-agent-terminal.test.tsx      | 156 ++++++++++++++++++
 1 file changed, 156 insertions(+)
 create mode 100644 apps/desktop/src/app/right-sidebar/terminal/use-agent-terminal.test.tsx

diff --git a/apps/desktop/src/app/right-sidebar/terminal/use-agent-terminal.test.tsx b/apps/desktop/src/app/right-sidebar/terminal/use-agent-terminal.test.tsx
new file mode 100644
index 0000000000000..a917f0f7ccc11
--- /dev/null
+++ b/apps/desktop/src/app/right-sidebar/terminal/use-agent-terminal.test.tsx
@@ -0,0 +1,156 @@
+import { act, render, waitFor } from '@testing-library/react'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+
+import { useAgentTerminal } from './use-agent-terminal'
+
+const xterm = vi.hoisted(() => ({
+  attachCustomKeyEventHandler: vi.fn(),
+  clearSelection: vi.fn(),
+  dispose: vi.fn(),
+  focus: vi.fn(),
+  getSelection: vi.fn(() => ''),
+  loadAddon: vi.fn(),
+  onSelectionChange: vi.fn(() => ({ dispose: vi.fn() })),
+  open: vi.fn(),
+  refresh: vi.fn(),
+  write: vi.fn()
+}))
+
+const terminalRegistrations = vi.hoisted(() => ({
+  makeTerminalReader: vi.fn(() => vi.fn()),
+  registerReader: vi.fn(() => vi.fn()),
+  registerWriter: vi.fn(() => vi.fn())
+}))
+
+vi.mock('@xterm/xterm', () => ({
+  Terminal: class {
+    readonly buffer = { active: {} }
+    readonly rows = 24
+    readonly unicode = { activeVersion: '6' }
+    options: Record<string, unknown>
+
+    constructor(options: Record<string, unknown>) {
+      this.options = { ...options }
+    }
+
+    attachCustomKeyEventHandler = xterm.attachCustomKeyEventHandler
+    clearSelection = xterm.clearSelection
+    dispose = xterm.dispose
+    focus = xterm.focus
+    getSelection = xterm.getSelection
+    loadAddon = xterm.loadAddon
+    onSelectionChange = xterm.onSelectionChange
+    open = xterm.open
+    refresh = xterm.refresh
+    write = xterm.write
+  }
+}))
+
+vi.mock('@xterm/addon-fit', () => ({
+  FitAddon: class {
+    fit = vi.fn()
+  }
+}))
+
+vi.mock('@xterm/addon-unicode11', () => ({
+  Unicode11Addon: class {}
+}))
+
+vi.mock('@xterm/addon-web-links', () => ({
+  WebLinksAddon: class {}
+}))
+
+vi.mock('@xterm/addon-webgl', () => ({
+  WebglAddon: class {
+    clearTextureAtlas = vi.fn()
+    dispose = vi.fn()
+    onContextLoss = vi.fn()
+  }
+}))
+
+vi.mock('@/components/ui/copy-button', () => ({
+  writeClipboardText: vi.fn()
+}))
+
+vi.mock('@/lib/haptics', () => ({
+  triggerHaptic: vi.fn()
+}))
+
+vi.mock('@/themes/context', () => ({
+  useTheme: () => ({
+    renderedMode: 'dark',
+    theme: { terminal: {} },
+    themeName: 'test'
+  })
+}))
+
+vi.mock('./agent-terminal-stream', () => ({
+  registerAgentTerminalWriter: terminalRegistrations.registerWriter
+}))
+
+vi.mock('./buffer', () => ({
+  makeTerminalReader: terminalRegistrations.makeTerminalReader,
+  registerTerminalReader: terminalRegistrations.registerReader
+}))
+
+function Harness() {
+  const { hostRef } = useAgentTerminal({ active: false, id: 'agent-tab', procId: 'proc-1' })
+
+  return <div ref={hostRef} />
+}
+
+describe('useAgentTerminal', () => {
+  let resolveFontLoad!: (faces: FontFace[]) => void
+  let resizeObserverConstructor = vi.fn<() => void>()
+
+  beforeEach(() => {
+    const pendingFontLoad = new Promise<FontFace[]>(resolve => {
+      resolveFontLoad = resolve
+    })
+
+    Object.defineProperty(globalThis.document, 'fonts', {
+      configurable: true,
+      value: { load: vi.fn(() => pendingFontLoad) }
+    })
+
+    resizeObserverConstructor = vi.fn<() => void>()
+    vi.stubGlobal(
+      'ResizeObserver',
+      class {
+        constructor() {
+          resizeObserverConstructor()
+        }
+
+        disconnect = vi.fn()
+        observe = vi.fn()
+        unobserve = vi.fn()
+      } as unknown as typeof ResizeObserver
+    )
+  })
+
+  afterEach(() => {
+    vi.clearAllMocks()
+    vi.unstubAllGlobals()
+    Reflect.deleteProperty(globalThis.document, 'fonts')
+  })
+
+  it('unmounts safely while initial font preparation is pending', async () => {
+    const { unmount } = render(<Harness />)
+
+    await waitFor(() => expect(globalThis.document.fonts.load).toHaveBeenCalledTimes(3))
+
+    expect(() => unmount()).not.toThrow()
+    expect(xterm.dispose).toHaveBeenCalledOnce()
+    expect(resizeObserverConstructor).not.toHaveBeenCalled()
+
+    await act(async () => {
+      resolveFontLoad([])
+      await Promise.resolve()
+    })
+
+    expect(xterm.open).not.toHaveBeenCalled()
+    expect(resizeObserverConstructor).not.toHaveBeenCalled()
+    expect(terminalRegistrations.registerWriter).not.toHaveBeenCalled()
+    expect(terminalRegistrations.registerReader).not.toHaveBeenCalled()
+  })
+})