From 2d5e93161bd73bd282315edd9f7abfeab477d142 Mon Sep 17 00:00:00 2001 From: "hermes-seaeye[bot]" <307254004+hermes-seaeye[bot]@users.noreply.github.com> Date: Sat, 8 Aug 2026 08:15:17 +0000 Subject: [PATCH] fmt(js): `npm run fix` on merge (#81589) Co-authored-by: github-actions[bot] --- apps/desktop/src/app/artifacts/index.test.ts | 1 + apps/desktop/src/app/artifacts/index.tsx | 3 +++ .../hooks/use-session-actions/index.ts | 7 +------ apps/desktop/src/hermes.ts | 19 ++++++++++--------- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/apps/desktop/src/app/artifacts/index.test.ts b/apps/desktop/src/app/artifacts/index.test.ts index a6d2371e616b8..eab184cf19fba 100644 --- a/apps/desktop/src/app/artifacts/index.test.ts +++ b/apps/desktop/src/app/artifacts/index.test.ts @@ -97,6 +97,7 @@ describe('loadArtifactsForSessions', () => { makeSession({ id: 'session-2' }), makeSession({ id: 'session-3' }) ] + const callOrder: string[] = [] let activeLoads = 0 let maxActiveLoads = 0 diff --git a/apps/desktop/src/app/artifacts/index.tsx b/apps/desktop/src/app/artifacts/index.tsx index b13cb78b7057c..1e3ee17787988 100644 --- a/apps/desktop/src/app/artifacts/index.tsx +++ b/apps/desktop/src/app/artifacts/index.tsx @@ -136,6 +136,7 @@ export function ArtifactsView({ setStatusbarItemGroup: _setStatusbarItemGroup, . try { const sessions = (await listAllProfileSessions(30, 1)).sessions + const { artifacts: nextArtifacts, failures } = await loadArtifactsForSessions( sessions, async session => (await getAllSessionMessages(session.id, session.profile)).messages @@ -145,7 +146,9 @@ export function ArtifactsView({ setStatusbarItemGroup: _setStatusbarItemGroup, . const safeLimitFailures = failures.filter(({ error }) => String(error instanceof Error ? error.message : error).includes('safe-load limit') ).length + const otherFailures = failures.length - safeLimitFailures + const detail = [ safeLimitFailures ? `${safeLimitFailures} exceeded the safe transcript load limit.` : '', otherFailures ? `${otherFailures} could not be read.` : '' diff --git a/apps/desktop/src/app/session/hooks/use-session-actions/index.ts b/apps/desktop/src/app/session/hooks/use-session-actions/index.ts index a800a22fa2644..b9bb96024da54 100644 --- a/apps/desktop/src/app/session/hooks/use-session-actions/index.ts +++ b/apps/desktop/src/app/session/hooks/use-session-actions/index.ts @@ -3,12 +3,7 @@ import { type MutableRefObject, useCallback, useEffect, useRef } from 'react' import type { NavigateFunction } from 'react-router' import { revealTreePane } from '@/components/pane-shell/tree/store' -import { - deleteSession, - getAllSessionMessages, - getLatestSessionMessages, - setSessionArchived -} from '@/hermes' +import { deleteSession, getAllSessionMessages, getLatestSessionMessages, setSessionArchived } from '@/hermes' import { useI18n } from '@/i18n' import { type ChatMessage, preserveLocalAssistantErrors, toChatMessages } from '@/lib/chat-messages' import { isMissingRpcMethod } from '@/lib/gateway-rpc' diff --git a/apps/desktop/src/hermes.ts b/apps/desktop/src/hermes.ts index 857fd06d0f2cc..8cec4b6adac55 100644 --- a/apps/desktop/src/hermes.ts +++ b/apps/desktop/src/hermes.ts @@ -666,15 +666,19 @@ export function getSessionMessages( if (profile) { query.set('profile', profile) } + if (page.limit !== undefined) { query.set('limit', String(page.limit)) } + if (page.offset !== undefined) { query.set('offset', String(page.offset)) } + if (page.order) { query.set('order', page.order) } + const suffix = query.size ? `?${query.toString()}` : '' return window.hermesDesktop.api({ @@ -683,10 +687,7 @@ export function getSessionMessages( }) } -export function getLatestSessionMessages( - id: string, - profile?: string | null -): Promise { +export function getLatestSessionMessages(id: string, profile?: string | null): Promise { return getSessionMessages(id, profile, { limit: 500, order: 'latest' }) } @@ -708,23 +709,23 @@ export async function getAllSessionMessages( offset, order: 'oldest' }) + resolvedSessionId = page.session_id jsonChars += (JSON.stringify(page.messages) ?? '').length + if (jsonChars > maxJsonChars) { throw new Error( 'Session transcript exceeds the Desktop safe-load limit; use the Web Dashboard export for this session.' ) } + messages.push(...page.messages) // Legacy backends ignore pagination and return the full transcript. - if ( - !page.pagination || - page.messages.length === 0 || - page.messages.length < page.pagination.limit - ) { + if (!page.pagination || page.messages.length === 0 || page.messages.length < page.pagination.limit) { break } + offset += page.messages.length }