diff --git a/apps/desktop/electron/desktop-electron-pin.test.ts b/apps/desktop/electron/desktop-electron-pin.test.ts index d648409b353b6..1428003d3ec40 100644 --- a/apps/desktop/electron/desktop-electron-pin.test.ts +++ b/apps/desktop/electron/desktop-electron-pin.test.ts @@ -86,6 +86,7 @@ test('lockfile resolves the pinned electron', () => { if (!fs.existsSync(ROOT_LOCK)) { return } // skip if lockfile not present + const spec = electronSpec(desktopPkg()) const lock = JSON.parse(fs.readFileSync(ROOT_LOCK, 'utf-8')) const packages = (lock.packages ?? {}) as Record diff --git a/apps/desktop/electron/git-worktree-ops.ts b/apps/desktop/electron/git-worktree-ops.ts index fac77cede71ad..a2a875765d0be 100644 --- a/apps/desktop/electron/git-worktree-ops.ts +++ b/apps/desktop/electron/git-worktree-ops.ts @@ -393,6 +393,7 @@ async function listBaseBranches(repoPath, gitBin) { ['symbolic-ref', '--quiet', '--short', 'refs/remotes/origin/HEAD'], resolved ) + const localDefault = await defaultBranch(gitBin, resolved) return out diff --git a/apps/desktop/electron/main-window-lifecycle.test.ts b/apps/desktop/electron/main-window-lifecycle.test.ts index cef5243fc6d8a..4ca6f8cd3d878 100644 --- a/apps/desktop/electron/main-window-lifecycle.test.ts +++ b/apps/desktop/electron/main-window-lifecycle.test.ts @@ -1,4 +1,5 @@ import assert from 'node:assert/strict' + import { test } from 'vitest' import { ensureMainWindow } from './main-window-lifecycle' @@ -7,6 +8,7 @@ test('recreates a destroyed primary window without focusing it', () => { const destroyedWindow = { isDestroyed: () => true } + let createCalls = 0 let focusCalls = 0 @@ -42,6 +44,7 @@ test('focuses a live primary window for a normal second launch', () => { const liveWindow = { isDestroyed: () => false } + let focusedWindow = null ensureMainWindow(liveWindow, { diff --git a/apps/desktop/src/app/contrib/hooks/use-background-sync.ts b/apps/desktop/src/app/contrib/hooks/use-background-sync.ts index 2ef5d26cf0988..58e669bcabbbb 100644 --- a/apps/desktop/src/app/contrib/hooks/use-background-sync.ts +++ b/apps/desktop/src/app/contrib/hooks/use-background-sync.ts @@ -120,6 +120,7 @@ export function useBackgroundSync({ ACTIVE_MESSAGING_SESSION_POLL_INTERVAL_MS, () => void refreshActiveMessagingTranscript() ) + void refreshActiveMessagingTranscript() return dispose diff --git a/apps/desktop/src/app/contrib/wiring.tsx b/apps/desktop/src/app/contrib/wiring.tsx index 0474fd01eea66..5d071ba2f0ee7 100644 --- a/apps/desktop/src/app/contrib/wiring.tsx +++ b/apps/desktop/src/app/contrib/wiring.tsx @@ -148,10 +148,7 @@ export function ContribWiring({ children }: { children: ReactNode }) { routeTokenRef.current = routeToken const getRouteToken = useCallback(() => routeTokenRef.current, []) - const getRoutedStoredSessionId = useCallback( - () => routedSessionIdRef.current, - [] - ) + const getRoutedStoredSessionId = useCallback(() => routedSessionIdRef.current, []) const clearRoutedSessionIntent = useCallback(() => { routedSessionIdRef.current = null diff --git a/apps/desktop/src/app/gateway/hooks/use-gateway-boot.ts b/apps/desktop/src/app/gateway/hooks/use-gateway-boot.ts index 69291b7087123..2fdba29f5680e 100644 --- a/apps/desktop/src/app/gateway/hooks/use-gateway-boot.ts +++ b/apps/desktop/src/app/gateway/hooks/use-gateway-boot.ts @@ -362,6 +362,7 @@ export function useGatewayBoot({ }) const sourceProfile = normalizeProfileKey($activeGatewayProfile.get()) + const offEvent = gateway.onEvent(event => callbacksRef.current.handleGatewayEvent({ ...event, profile: sourceProfile }) ) diff --git a/apps/desktop/src/app/session/hooks/use-prompt-actions/submit.ts b/apps/desktop/src/app/session/hooks/use-prompt-actions/submit.ts index 44b2d3ea19f90..ce13b6a65a88c 100644 --- a/apps/desktop/src/app/session/hooks/use-prompt-actions/submit.ts +++ b/apps/desktop/src/app/session/hooks/use-prompt-actions/submit.ts @@ -150,9 +150,7 @@ export function useSubmitPrompt(deps: SubmitPromptDeps) { const selectedStoredSessionId = selectedStoredSessionIdRef.current const routedStoredSessionId = getRoutedStoredSessionId() - const routedRuntimeId = routedStoredSessionId - ? getRuntimeIdForStoredSession(routedStoredSessionId) - : null + const routedRuntimeId = routedStoredSessionId ? getRuntimeIdForStoredSession(routedStoredSessionId) : null const routedSessionNeedsResume = Boolean( routedStoredSessionId && diff --git a/apps/desktop/src/store/approval-mode.test.ts b/apps/desktop/src/store/approval-mode.test.ts index 7ae98d447e641..3f5112df81664 100644 --- a/apps/desktop/src/store/approval-mode.test.ts +++ b/apps/desktop/src/store/approval-mode.test.ts @@ -76,6 +76,7 @@ describe('profile-scoped approval mode cache', () => { it('lets a backend event supersede an optimistic write and its later failure', async () => { const write = deferred<{ value: string }>() + const pending = setApprovalModeForProfile( vi.fn(() => write.promise), 'work',