RomanNum3ral
/
hermes-agent
mirror of https://github.com/NousResearch/hermes-agent.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(desktop): inbox cards render in every sidebar view, not just flat recents 

The card prop was gated off whenever Project grouping was active, so the
Inbox style toggle silently did nothing there. It is a render variant, not
a grouping: project lanes and overview previews now render the same card
the flat list does.

Also mirrors the section's real virtualization inputs (projectOverview /
entered-project content, not the persistent agentProjectTree cache) when
deciding the wrapper's scroll classes, and stops gating SCROLL_Y on that
parallel guess — the section is the single authority on which scroller
lives, so the recents pane can no longer end up with no scroller at all
(the "no sessions under Updated grouping after toggling settings" blank).
This commit is contained in:
Brooklyn Nicholson 2026-08-13 02:09:50 -05:00 committed by brooklyn!
parent e7032bb267
commit 81587c4f8f
1 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
apps/desktop/src/app/chat/sidebar/index.tsx
View File

@ -1311,8 +1311,17 @@ export function ChatSidebar({
[agentProjectTree]
)
// Mirror the section's own virtualization inputs (the props it receives),
// not the raw tree cache: agentProjectTree persists after leaving Project
// grouping, and keying on it here while the section keys on projectOverview
// (which is nulled the moment grouping changes) left the two disagreeing —
// wrapper classes built for a virtualized list around a non-virtual one.
// Entered-project content is the third prop that suppresses virtualization.
const recentsVirtualizes =
!displayAgentGroups?.length && !agentProjectTree?.length && displayAgentSessions.length >= VIRTUALIZE_THRESHOLD
!displayAgentGroups?.length &&
!projectOverview?.length &&
!(inProject && enteredProjectContent) &&
displayAgentSessions.length >= VIRTUALIZE_THRESHOLD
// Keep the persisted parent + worktree orders reconciled with what's on screen:
// freshly-seen repos/worktrees surface at the top, vanished ones drop out of
@ -1552,17 +1561,21 @@ export function ChatSidebar({
<SidebarSessionsSection
activeProjectId={activeProjectId}
activeSessionId={activeSidebarSessionId}
// Inbox style is a render variant, not a grouping: only the
// flat recents list opts in, and only outside the project tree
// (whose rows already carry workspace context).
card={cardRows && !agentsGrouped}
// Inbox style is a render variant, not a grouping — it rides
// whichever view is active: flat recents, project lanes, and
// the overview previews all render the same card.
card={cardRows}
collapsible={!inProject}
contentClassName={cn(
'flex min-h-0 flex-1 flex-col gap-px pb-1.75',
// The virtualized long list owns its own scroller — giving
// this wrapper one too doubled the scrollbar gutter and
// shaved every row 4px short of the sidebar's right edge.
!recentsVirtualizes && SCROLL_Y,
// The section is the ONE authority on whether the virtual
// list owns scrolling: it neutralizes this wrapper scroller
// itself (overflow-visible) when it virtualizes. Gating
// SCROLL_Y here on index's own parallel guess desynced the
// two — a cached project tree flipped this side but not the
// section's, leaving the list with no scroller at all and
// the recents pane rendering blank under Updated grouping.
SCROLL_Y,
// Flatten into the single scroll when compact — unless this is the
// virtualized long list, which must keep its own scroller.
!recentsVirtualizes && COMPACT_FLAT