Commit Graph

2 Commits

Author SHA1 Message Date
ethernet 05650c9944 feat(lints): hold package.json overrides to the exact-version rule
An override forces a version on every transitive consumer, so a ranged
override re-floats packages the manifest never names. That is a wider
hole than a ranged direct dependency, and the lint did not look at it.

Overrides nest, so the walk is recursive. `npm:<pkg>@<version>` aliases
are now recognised too, and held to the same rule on their version
tail; before this they were rejected outright even when exact.

Three ranges are pinned to close the lint on the live tree. yauzl and
the bridge's protobufjs take their locked versions; the root protobufjs
override is dormant (no protobufjs resolves anywhere in the root tree)
and takes its own declared floor. Re-resolving both lockfiles with
`npm install --package-lock-only` returns them byte-identical.
2026-08-14 08:59:56 -04:00
ethernet 6514dea0a3 lints: migrate tests + infographic workflow, add dep-specifier lints
five new registered lints, all blocking, none autofixable:

- engines-satisfiable: from tests/test_engines_satisfiable.py, which
  lived in the python pytest lane — a package.json-only PR never ran
  it, the exact classifier gap that let the npm-12 floor outage ship.
- no-shadowed-test-definitions: from the pytest guard; same AST scan,
  per-file annotations instead of one aggregated assert.
- no-committed-infographics: from infographic-check.yml; deletes the
  workflow and its ci.yml wiring (one fewer runner per PR).
- workflow-sha-pins: the AGENTS.md action-pinning policy (commit SHA,
  never tag/branch), previously enforced only by review. repo is
  already clean — every uses: ref is pinned.
- pyproject-dep-bounds: the AGENTS.md upper-bound policy (>=floor,<
  ceiling; git deps SHA-pinned) plus the pin-consistency invariant
  pulled out of tests/test_packaging_metadata.py (the lazy_deps-coupled
  tests stay put). self-referential hermes-agent[extra] includes exempt.
- packagejson-exact-versions: every tracked package.json dependency
  must be an exact version or file:/link:/workspace: ref — ranges float
  onto minutes-old releases via unreviewable lockfile churn. fixed the
  one violator (whatsapp-bridge: express/pino/qrcode-terminal caret
  ranges pinned to their locked versions, lockfile mirror regenerated).

autofix bot also gains ruff check --fix (continue-on-error like npm
run fix; ruff-blocking stays the PR gate), with .py added to the
patch-guard allowance.
2026-08-14 08:33:55 -04:00