hermes-agent/scripts
Teknium 2ecca1e7d3
fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint (#53829)
Follow-up to #53791 addressing review feedback: the footgun checker treated
capture_output=/stdout=/stderr=/check_output as proof a subprocess can't pop a
Windows console. That invariant is false — stream redirection controls where a
child's output goes, not whether a console is allocated. From a console-less
parent (Desktop/Electron, pythonw.exe, detached gateway/cron) a console-subsystem
child still flashes a window even when fully captured.

- check-windows-footguns.py: capture/redirect/check_output is no longer a blanket
  safe-pass. Added _WINDOWS_FLASHING_PROGRAMS (git/gh/npm/node/python/uv/ffmpeg/
  docker/powershell/…); calls to those are flagged even when captured. Non-flashing
  programs keep the capture exemption (no 271-site noise). _subprocess_compat.run/
  popen calls are inherently safe (wrapper injects CREATE_NO_WINDOW).
- Routed the 35 genuine flashing git/gh/npm/uv/ffmpeg/docker spawns through the
  _subprocess_compat.run/popen chokepoint (Brooklyn's wrapper from #53810) — the
  durable fix, not per-site annotations. cmd.exe /c start stays # ok (intentional).
- Updated tests + CONTRIBUTING.md rule #17 to the corrected invariant.
2026-06-27 14:49:41 -07:00
..
ci
…
lib fix(hermes): heal broken managed Node tree instead of PATH fallback 2026-06-26 20:10:20 +05:30
tests
…
whatsapp-bridge
…
LIVETEST_README.md
…
analyze_livetest.py
…
benchmark_browser_eval.py
…
build_model_catalog.py
…
build_skills_index.py
…
check-windows-footguns.py fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint (#53829) 2026-06-27 14:49:41 -07:00
check_subprocess_stdin.py
…
contributor_audit.py fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint (#53829) 2026-06-27 14:49:41 -07:00
discord-voice-doctor.py
…
docker_config_migrate.py
…
hermes-gateway
…
install.cmd
…
install.ps1 fix(install): discard managed lockfile churn before stashing 2026-06-25 23:49:11 -07:00
install.sh fix(install): discard managed lockfile churn before stashing 2026-06-25 23:49:11 -07:00
install_psutil_android.py fix(windows): stop subprocess console-window popups + add CI guard (#53791) 2026-06-27 13:03:51 -07:00
keystroke_diagnostic.py
…
kill_modal.sh
…
lint_diff.py
…
profile-tui.py fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint (#53829) 2026-06-27 14:49:41 -07:00
release.py fix(terminal): strip VIRTUAL_ENV/CONDA_PREFIX from terminal subprocess env 2026-06-28 01:04:20 +05:30
run_tests.sh
…
run_tests_parallel.py change(ci): slice files in matrix job 2026-06-26 19:15:18 -07:00
sample_and_compress.py
…
setup_open_webui.sh
…
tool_search_livetest.py
…