hermes-agent/gateway
Teknium 70d5d7e39b
fix(memory,skills): repair write-approval inline prompt, gateway staging, and gateway /skills review (#43452)
Follow-ups to #38199/#43354 found in post-merge review:

- Inline CLI memory approval never worked: the per-thread approval callback
  was not passed to prompt_dangerous_approval, so the prompt_toolkit
  fail-closed guard (#15216) denied every gated foreground write without
  showing a prompt. Now invokes the registered callback directly; a crashed
  prompt falls back to staging instead of a silent deny.
- Gateway sessions claimed inline support but prompt_dangerous_approval has
  no gateway round-trip (that lives in the pending-approval queue), so gated
  gateway memory writes hit the input() fallback and denied. Gateway
  contexts now stage for /memory pending review.
- /skills pending|approve|reject|diff|approval now works on the gateway
  (gateway_config_gate on skills.write_approval), so skills staged from a
  messaging session can be reviewed there. Diff output truncated for chat.
- memory_tool validates required params before the gate so invalid writes
  are rejected immediately instead of staged and failing at approve time.
- Stale tri-state write_mode docstrings updated to the boolean gate; docs
  table corrected (inline prompt is interactive-CLI-only).
- 6 new tests covering the interactive approve/deny/error paths, gateway
  staging, skills never-prompt invariant, and pre-gate validation.
2026-06-10 02:57:15 -07:00
..
assets
…
builtin_hooks
…
platforms fix(gateway): Slack approval UX in threads — block-size overflow + typed-prefix instruction text (#43444) 2026-06-10 02:30:01 -07:00
__init__.py
…
authz_mixin.py fix: guard role_authorized check against MagicMock test sources 2026-06-10 00:18:11 -07:00
channel_directory.py
…
config.py feat(sessions): add optional max session cap 2026-06-08 15:12:12 -07:00
delivery.py
…
display_config.py
…
hooks.py
…
kanban_watchers.py
…
memory_monitor.py
…
mirror.py
…
pairing.py
…
platform_registry.py
…
restart.py
…
run.py fix(memory,skills): repair write-approval inline prompt, gateway staging, and gateway /skills review (#43452) 2026-06-10 02:57:15 -07:00
runtime_footer.py
…
session.py fix(discord): propagate role_authorized flag so DISCORD_ALLOWED_ROLES works end-to-end 2026-06-10 00:18:11 -07:00
session_context.py fix(api-server): bind request session context for tools 2026-06-08 20:52:08 -07:00
shutdown_forensics.py
…
slash_access.py
…
slash_commands.py fix(memory,skills): repair write-approval inline prompt, gateway staging, and gateway /skills review (#43452) 2026-06-10 02:57:15 -07:00
status.py
…
sticker_cache.py
…
stream_consumer.py
…
stream_dispatch.py
…
stream_events.py
…
whatsapp_identity.py
…