hermes-agent/tests/tools
brooklyn! 507d479c8c
fix(clarify): one canonical timeout across CLI, TUI/desktop, and gateway (#69774)
* test(clarify-gateway): cover signature, timeout fallback, and notify paths for 100% coverage

Fixes #36531

(cherry picked from commit 5265dfe2f5)

* fix(clarify): one canonical timeout across CLI, TUI/desktop, and gateway

The clarify wait timeout was resolved three different (wrong) ways:

- CLI (`cli.py`, `hermes_cli/callbacks.py`) read a non-existent top-level
  `clarify.timeout`, so it always fell through to a hardcoded 120s instead of
  the canonical `agent.clarify_timeout` (default 3600) the gateway uses (#42969).
- The TUI/desktop bridge called `_block("clarify.request", …)` with no timeout,
  so it used the hardcoded 300s `_block` default and ignored config (#51960).
- There was no way to disable the auto-skip: a user who wanted the agent to wait
  indefinitely while they think couldn't get it.

Collapse all of this onto a single resolver:

- `tools.clarify_gateway.resolve_clarify_timeout(config)` is the one source of
  truth. Order: explicit legacy `clarify.timeout` (back-compat) → canonical
  `agent.clarify_timeout` → 3600. `<= 0` is preserved verbatim as "unlimited".
- CLI, callbacks, and the TUI bridge (`_clarify_timeout_seconds`) all route
  through it, so the three surfaces can't drift.
- `<= 0` means unlimited everywhere: `wait_for_response` and `_block` drop the
  deadline (heartbeat still fires), and the CLI hides its countdown.

Tests: resolver order / default / non-numeric / unlimited-sentinel; an
unlimited `wait_for_response` blocks until resolved rather than auto-skipping;
the TUI clarify bridge passes the configured timeout to `_block`.

Supersedes #42974 (CLI key), #51993 (TUI honors config), and #68986 (unlimited
wait); folds in #52031 (clarify_gateway coverage).

Co-authored-by: liuhao1024 <liuhao1024@users.noreply.github.com>
Co-authored-by: lkevincc0 <lkevincc0@users.noreply.github.com>
Co-authored-by: theone139344 <theone139344@users.noreply.github.com>
Co-authored-by: baauzi <baauzi@users.noreply.github.com>

---------

Co-authored-by: Christopher-Schulze <210261288+Christopher-Schulze@users.noreply.github.com>
Co-authored-by: liuhao1024 <liuhao1024@users.noreply.github.com>
Co-authored-by: lkevincc0 <lkevincc0@users.noreply.github.com>
Co-authored-by: theone139344 <theone139344@users.noreply.github.com>
Co-authored-by: baauzi <baauzi@users.noreply.github.com>
2026-07-22 23:25:13 -05:00
..
__init__.py
…
conftest.py
…
test_accretion_caps.py
…
test_ansi_strip.py fix(cli): sanitize terminal escapes when replaying stored history (/resume recap, /status recap) 2026-07-17 04:53:38 -07:00
test_approval.py fix(approval): unify execution-bearing option detection 2026-07-17 04:53:04 -07:00
test_approval_deny_rules.py
…
test_approval_heartbeat.py
…
test_approval_interrupt.py
…
test_approval_plugin_hooks.py
…
test_approved_command_clean_slate.py
…
test_async_delegation.py
…
test_base_environment.py
…
test_blueprints.py
…
test_browser_camofox.py
…
test_browser_camofox_auth.py
…
test_browser_camofox_ensure_tab.py
…
test_browser_camofox_persistence.py
…
test_browser_camofox_private_page_guard.py
…
test_browser_camofox_state.py
…
test_browser_camofox_timeout.py
…
test_browser_cdp_override.py
…
test_browser_cdp_tool.py
…
test_browser_chromium_autoinstall.py
…
test_browser_chromium_check.py
…
test_browser_cleanup.py
…
test_browser_cloud_fallback.py
…
test_browser_cloud_provider_cache.py
…
test_browser_command_timeout_race.py
…
test_browser_console.py feat(browser): store full snapshots on truncation; make eval denylist opt-in (#65923) 2026-07-16 23:41:26 -07:00
test_browser_console_ssrf.py
…
test_browser_content_none_guard.py feat(browser): store full snapshots on truncation; make eval denylist opt-in (#65923) 2026-07-16 23:41:26 -07:00
test_browser_eval_ssrf.py
…
test_browser_eval_supervisor_path.py
…
test_browser_get_images_ssrf.py
…
test_browser_hardening.py feat(browser): store full snapshots on truncation; make eval denylist opt-in (#65923) 2026-07-16 23:41:26 -07:00
test_browser_headed_mode.py fix: widen headed-mode gate to config, add browser.headed default, tests, docs 2026-07-18 10:07:46 -07:00
test_browser_homebrew_paths.py
…
test_browser_hybrid_routing.py
…
test_browser_lightpanda.py
…
test_browser_open_timeout.py
…
test_browser_orphan_reaper.py
…
test_browser_private_page_action_guard.py
…
test_browser_secret_exfil.py
…
test_browser_snapshot_ssrf.py
…
test_browser_ssrf_local.py
…
test_browser_supervisor.py
…
test_browser_supervisor_healthcheck.py
…
test_browser_type_redaction.py
…
test_budget_config.py
…
test_checkpoint_manager.py
…
test_clarify_gateway.py fix(clarify): one canonical timeout across CLI, TUI/desktop, and gateway (#69774) 2026-07-22 23:25:13 -05:00
test_clarify_tool.py
…
test_clipboard.py
…
test_code_execution.py
…
test_code_execution_modes.py
…
test_code_execution_windows_env.py
…
test_command_guards.py test(approval): cover allow_session tiers in Matrix reaction seeding and gateway payload 2026-07-21 12:04:47 -07:00
test_computer_use.py
…
test_computer_use_capture_routing.py
…
test_computer_use_cua_backend_linux.py test(computer-use): assert exact capture skips X11 active-window probe 2026-07-22 21:15:18 -07:00
test_computer_use_delivery_ladder.py fix(computer_use): reconnect a dead cua-driver session instead of hanging (#67138) 2026-07-18 15:07:04 -07:00
test_computer_use_null_pid_windows.py
…
test_computer_use_vision_routing.py
…
test_config_null_guard.py
…
test_container_cwd_sanitize.py
…
test_credential_files.py fix(credentials): hoist read-guard import, fail closed loudly (#67665) 2026-07-20 09:21:08 -07:00
test_credential_pool_env_fallback.py
…
test_cron_approval_mode.py
…
test_cron_prompt_injection.py
…
test_cronjob_run_immediate.py
…
test_cronjob_tools.py
…
test_cross_profile_guard.py
…
test_daemon_pool.py
…
test_daytona_environment.py
…
test_debug_helpers.py
…
test_delegate.py feat(delegation): let subagents use execute_code (#69325) 2026-07-22 06:58:45 -07:00
test_delegate_composite_toolsets.py
…
test_delegate_subagent_timeout_diagnostic.py
…
test_delegate_summary_budget.py
…
test_delegate_toolset_scope.py
…
test_delegation_live_log.py fix(delegation): redact credentials in live subagent transcripts 2026-07-20 06:50:31 -07:00
test_desktop_ui.py feat(desktop): agent can focus panes + shared desktop-UI event bridge 2026-07-22 12:13:01 -05:00
test_discord_send_message_caption.py
…
test_discord_tool.py
…
test_docker_cgroup_limits.py
…
test_docker_config_migrate.py
…
test_docker_environment.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_docker_find.py
…
test_docker_network_config.py
…
test_docker_orphan_reaper_integration.py
…
test_docker_rebootstrap_nous_session.py
…
test_dockerfile_immutable_install.py
…
test_dockerfile_node_modules_perms.py
…
test_dockerfile_pid1_reaping.py
…
test_env_passthrough.py
…
test_env_probe.py fix(tools): bound env probe subprocess so a Windows inherited pipe can't wedge sessions (#67964) 2026-07-20 06:50:11 -07:00
test_execute_code_approval_cluster.py
…
test_execution_flag_detection.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_feishu_tools.py
…
test_file_operations.py
…
test_file_operations_edge_cases.py
…
test_file_ops_cwd_tracking.py
…
test_file_read_guards.py
…
test_file_staleness.py
…
test_file_state_registry.py
…
test_file_sync.py test(file-sync): patch module-level _monotonic alias instead of shared stdlib time module 2026-07-20 02:25:53 -07:00
test_file_sync_back.py
…
test_file_sync_perf.py
…
test_file_sync_sigint.py
…
test_file_tools.py
…
test_file_tools_container_config.py
…
test_file_tools_cwd_resolution.py
…
test_file_tools_live.py
…
test_file_tools_tilde_profile.py
…
test_file_write_safety.py
…
test_find_shell.py fix(install): detect Git Bash Mandatory ASLR failures (#64651) 2026-07-16 22:46:46 -04:00
test_focus_pane_tool.py feat(desktop): agent can focus panes + shared desktop-UI event bridge 2026-07-22 12:13:01 -05:00
test_force_dangerous_override.py
…
test_fuzzy_match.py
…
test_gateway_cwd_contract.py
…
test_gnu_long_option_abbreviation_bypass.py
…
test_hardline_blocklist.py
…
test_heartbeat_stale_thresholds.py
…
test_hermes_subprocess_env.py
…
test_hidden_dir_filter.py
…
test_homeassistant_tool.py
…
test_hook_output_spill.py
…
test_image_generation.py
…
test_image_generation_artifacts.py
…
test_image_generation_env.py
…
test_image_generation_image_to_image.py
…
test_image_generation_plugin_dispatch.py
…
test_image_source.py
…
test_init_session_cwd_respect.py
…
test_interrupt.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_kanban_redaction.py
…
test_kanban_tools.py fix(goals): update judge consumers for transport result 2026-07-20 05:38:25 -07:00
test_lazy_deps.py fix(honcho): update SDK and restore CI coverage 2026-07-16 12:48:48 -07:00
test_lazy_deps_durable_target.py
…
test_line_ending_preservation.py
…
test_llm_content_none_guard.py
…
test_local_background_child_hang.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_local_cwd_permission_fallback.py fix(terminal): fall back when the configured cwd is unenterable, not just missing (#66306) 2026-07-17 06:54:51 -07:00
test_local_env_blocklist.py
…
test_local_env_cwd_recovery.py
…
test_local_env_relative_cwd.py
…
test_local_env_session_leak.py
…
test_local_env_windows_msys.py
…
test_local_interrupt_cleanup.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_local_shell_init.py
…
test_local_tempdir.py
…
test_managed_browserbase_and_modal.py
…
test_managed_media_gateways.py
…
test_managed_modal_environment.py
…
test_managed_tool_gateway.py
…
test_mcp_bridge_single_failure.py fix(mcp): clear connect-cooldown state on every shutdown path 2026-07-21 12:43:27 -07:00
test_mcp_cancelled_error_propagation.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_mcp_capability_gating.py
…
test_mcp_circuit_breaker.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_mcp_client_cert.py
…
test_mcp_dashboard_oauth.py fix(mcp): preserve live OAuth state during reauth 2026-07-17 04:50:47 -07:00
test_mcp_dynamic_discovery.py
…
test_mcp_elicitation.py
…
test_mcp_empty_error_message.py
…
test_mcp_failure_classification.py fix(mcp): unwrap exception groups and park permanent failures immediately (#65673) 2026-07-21 12:42:33 -07:00
test_mcp_image_content.py
…
test_mcp_invalid_url.py
…
test_mcp_list_pagination.py fix(mcp): follow nextCursor pagination in tools/resources/prompts discovery 2026-07-17 04:57:12 -07:00
test_mcp_loop_profile_override.py
…
test_mcp_oauth.py fix(mcp): close hosted OAuth lifecycle gaps 2026-07-17 04:50:47 -07:00
test_mcp_oauth_bidirectional.py
…
test_mcp_oauth_cold_load_expiry.py
…
test_mcp_oauth_integration.py
…
test_mcp_oauth_manager.py fix(mcp): preserve concurrent OAuth manager refresh 2026-07-17 04:50:47 -07:00
test_mcp_oauth_metadata.py
…
test_mcp_parked_self_probe.py fix(mcp): re-register tools during parked revival 2026-07-21 12:43:00 -07:00
test_mcp_poll_loop_oom_integration.py test(mcp): e2e integration coverage for #63892 poll-loop OOM spin 2026-07-18 18:49:56 -04:00
test_mcp_preflight_content_type.py
…
test_mcp_probe.py
…
test_mcp_rapid_drop_budget.py fix(mcp): charge immediate reconnects against a rapid-drop budget (#62212) 2026-07-21 12:42:33 -07:00
test_mcp_reconnect_log_hygiene.py fix(mcp): one WARNING per state transition, DEBUG retry chatter, jittered backoff 2026-07-21 12:42:33 -07:00
test_mcp_reconnect_retry_reset.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_mcp_reconnect_signal.py
…
test_mcp_register_wakes_stale.py
…
test_mcp_resource_content.py test(mcp): isolate resource error breaker state 2026-07-21 12:43:27 -07:00
test_mcp_server_log_notifications.py
…
test_mcp_sse_transport.py
…
test_mcp_stability.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_mcp_stdio_init_timeout.py
…
test_mcp_stdio_watchdog.py fix(mcp): use direct parent identity in stdio watchdog 2026-07-18 04:15:13 -07:00
test_mcp_structured_content.py
…
test_mcp_tool.py fix(mcp): pass secret-source-injected env vars to stdio servers 2026-07-22 03:19:42 -07:00
test_mcp_tool_401_handling.py
…
test_mcp_tool_issue_948.py
…
test_mcp_tool_session_expired.py test(mcp): stamp breaker-open time on the monotonic clock, not a literal (#69003) 2026-07-21 19:54:40 -05:00
test_mcp_transport_group_reconnect.py fix(mcp): reconnect immediately on transport TaskGroup drop instead of backoff/park 2026-07-21 12:42:33 -07:00
test_mcp_utility_capability_gating.py
…
test_media_caption_split.py
…
test_memory_tool.py
…
test_memory_tool_import_fallback.py
…
test_memory_tool_schema.py
…
test_microsoft_graph_auth.py
…
test_microsoft_graph_client.py
…
test_modal_bulk_upload.py
…
test_modal_sandbox_fixes.py
…
test_modal_snapshot_isolation.py
…
test_notify_on_complete.py
…
test_open_preview_tool.py feat(desktop): agent can focus panes + shared desktop-UI event bridge 2026-07-22 12:13:01 -05:00
test_osv_check.py
…
test_parse_env_var.py
…
test_patch_failure_tracking.py
…
test_patch_parser.py
…
test_pr_6656_regressions.py
…
test_process_registry.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_read_extract.py
…
test_read_loop_detection.py
…
test_refresh_agent_mcp_tools.py
…
test_registry.py fix(ci): make tests, workflows, and attribution reliable under load (#66373) 2026-07-17 20:55:24 +00:00
test_request_tool_approval.py
…
test_resolve_path.py
…
test_restored_delegation_ownership.py
…
test_schema_sanitizer.py
…
test_search_budget_truncation.py
…
test_search_error_guard.py
…
test_search_hidden_dirs.py
…
test_send_message_missing_platforms.py
…
test_send_message_react.py
…
test_send_message_target_parse.py
…
test_send_message_telegram_proxy.py
…
test_send_message_tool.py fix(slack): preserve media in standalone cron delivery 2026-07-22 20:57:25 -07:00
test_session_cwd_store.py
…
test_session_search.py test(search): prove discovery scope and bookend bounding work together on compacted sessions 2026-07-22 16:59:09 -07:00
test_shared_container_task_id.py
…
test_shell_bypass_denylist.py
…
test_signal_media.py
…
test_singularity_preflight.py
…
test_skill_bundle_provenance.py
…
test_skill_env_passthrough.py
…
test_skill_improvements.py
…
test_skill_manager_tool.py test: add coverage for manual-skill curator guard 2026-07-18 20:17:22 +05:30
test_skill_provenance.py
…
test_skill_size_limits.py
…
test_skill_usage.py
…
test_skill_view_path_check.py
…
test_skill_view_traversal.py
…
test_skills_ast_audit.py
…
test_skills_guard.py
…
test_skills_hub.py
…
test_skills_hub_browse_sh.py
…
test_skills_hub_clawhub.py
…
test_skills_list_modified_diff.py
…
test_skills_sync.py
…
test_skills_tool.py fix(skills): strip UTF-8 BOM before parsing SKILL.md frontmatter 2026-07-17 04:52:02 -07:00
test_skills_tool_discovery_cache.py
…
test_skills_tool_profile_scope.py
…
test_slash_confirm.py
…
test_smart_approval_injection.py
…
test_spotify_client.py
…
test_ssh_bulk_upload.py
…
test_ssh_environment.py
…
test_stage2_hook_seed_one_symlinks.py
…
test_stage2_hook_symlink_chown.py
…
test_subprocess_stdin_guard.py
…
test_symlink_prefix_confusion.py
…
test_sync_back_backends.py
…
test_telegram_send_message_caption.py
…
test_terminal_compound_background.py
…
test_terminal_config_env_sync.py
…
test_terminal_env_bridge.py fix(terminal): bridge terminal.backend config in serve/desktop processes lacking a launcher env bridge 2026-07-16 08:55:10 -07:00
test_terminal_exit_semantics.py
…
test_terminal_foreground_timeout_cap.py
…
test_terminal_none_command_guard.py
…
test_terminal_output_transform_hook.py
…
test_terminal_requirements.py
…
test_terminal_task_cwd.py
…
test_terminal_timeout_output.py
…
test_terminal_tool.py
…
test_terminal_tool_pty_fallback.py
…
test_terminal_tool_requirements.py
…
test_threaded_process_handle.py
…
test_threat_patterns.py
…
test_tirith_security.py
…
test_todo_tool.py
…
test_todo_tool_type_coercion.py
…
test_tool_backend_helpers.py
…
test_tool_output_limits.py
…
test_tool_result_storage.py
…
test_tool_search.py
…
test_tool_search_context_provider.py fix(tools): make the tool-search context gate provider-aware (#68589) 2026-07-21 05:27:23 -07:00
test_transcription.py
…
test_transcription_command_providers.py
…
test_transcription_deepinfra.py
…
test_transcription_dotenv_fallback.py
…
test_transcription_plugin_dispatch.py
…
test_transcription_tools.py fix(stt): flag empty transcripts as no_speech 2026-07-22 17:47:04 -05:00
test_tts_command_providers.py
…
test_tts_deepinfra.py
…
test_tts_dotenv_fallback.py
…
test_tts_gemini.py
…
test_tts_kittentts.py
…
test_tts_max_text_length.py
…
test_tts_mistral.py
…
test_tts_opus_routing.py
…
test_tts_path_traversal.py
…
test_tts_piper.py
…
test_tts_plugin_dispatch.py
…
test_tts_speed.py
…
test_tts_streaming.py feat(voice): speech-interrupted latch in the TTS streaming core 2026-07-22 17:53:06 -05:00
test_tts_xai_speech_tags.py
…
test_url_safety.py
…
test_video_analyze.py
…
test_video_generation_dispatch.py
…
test_video_generation_dynamic_schema.py
…
test_video_generation_tool_surface_matrix.py
…
test_vision_native_fast_path.py
…
test_vision_tools.py
…
test_voice_cli_integration.py feat(voice): stream any provider in the CLI, with barge-in capture 2026-07-22 17:47:15 -05:00
test_voice_mode.py feat(voice): barge-in detector with pre-roll utterance capture 2026-07-22 17:47:05 -05:00
test_watch_patterns.py
…
test_web_extract_robustness.py
…
test_web_providers.py
…
test_web_providers_brave_free.py
…
test_web_providers_ddgs.py test(web/ddgs): cover GIL-hold timeout, interrupt, and worker reap 2026-07-21 11:51:01 +05:30
test_web_providers_searxng.py
…
test_web_providers_xai.py fix(auth): make xAI OAuth pools multi-account resilient 2026-07-17 11:37:25 +05:30
test_web_tools_config.py
…
test_web_tools_dict_urls.py
…
test_web_tools_tavily.py
…
test_web_tools_truncate.py
…
test_website_policy.py
…
test_whatsapp_send_message_media.py
…
test_windows_compat.py
…
test_windows_native_support.py
…
test_write_approval.py
…
test_write_deny.py fix(secrets): harden encrypted Bitwarden cache 2026-07-22 04:40:07 -07:00
test_write_file_syntax_gate.py
…
test_x_search_tool.py test: cover X Search reasoning config propagation 2026-07-19 23:58:33 -07:00
test_xai_http_storage.py
…
test_yolo_mode.py
…
test_zombie_process_cleanup.py
…