Final-diff simplify/review pass findings on #83785: - Consent gate (confirm_truncate -> 4029) now checked BEFORE target resolution, restoring the pre-PR precedence: an unconfirmed submit carrying truncation params refuses without paying the durable-transcript read or heal-stamping live history dicts, and an unconfirmed out-of-range ordinal returns 4029 (not 4018). Malformed params still refuse first with 4004. Regression test added (spy DB asserts zero reads pre-consent; mutation-checked against the previous commit). - _coerce_truncate_ordinal generalized to _coerce_truncate_int(param_name): the row_id branch was inlining the exact bool-guard + int() -> 4004 pattern the helper had just extracted. - Deleted the dead user_indices re-read after _resolve_truncate_row_id (heal mutates dicts in place; the filter output is identical) and the duplicate range check that had deadened the pre-existing guard. - Desktop: exported isVisibleUserMessage from use-prompt-actions/utils and used it in visibleUserOrdinal / visibleUserIndexAtOrdinal / rebindSurvivorRowIds — one predicate for the ordinal parity all three depend on instead of three verbatim copies. - Docs: programmatic-integration.md documents survivor_user_row_ids. |
||
|---|---|---|
| .. | ||
| plugins | ||
| _category_.json | ||
| acp-internals.md | ||
| adding-platform-adapters.md | ||
| adding-providers.md | ||
| adding-tools.md | ||
| agent-loop.md | ||
| architecture.md | ||
| browser-provider-plugin.md | ||
| browser-supervisor.md | ||
| codebase-ownership.md | ||
| context-compression-and-caching.md | ||
| context-engine-plugin.md | ||
| contributing.md | ||
| creating-skills.md | ||
| cron-internals.md | ||
| desktop-plugin-sdk.md | ||
| egress-internals.md | ||
| extending-the-cli.md | ||
| gateway-internals.md | ||
| image-gen-provider-plugin.md | ||
| memory-provider-plugin.md | ||
| model-provider-plugin.md | ||
| plugin-llm-access.md | ||
| programmatic-integration.md | ||
| prompt-assembly.md | ||
| provider-runtime.md | ||
| secret-source-plugin.md | ||
| session-storage.md | ||
| subagent-lifecycle-api.md | ||
| tools-runtime.md | ||
| trajectory-format.md | ||
| video-gen-provider-plugin.md | ||
| web-search-provider-plugin.md | ||
| worktree-ui-dev.md | ||