Review follow-ups on the #32811 salvage: - Hold state.runtime_lock and bail on is_running so the pre-first-turn guard can't race the first prompt dispatch (a refresh publishing mid-turn would swap tools= and break the just-created cache prefix). Regression test mutation-checked (guard removed -> test fails). - In-memory-only session lookup in the daemon: get_session() falls through to a DB restore that builds a whole new AIAgent just to decide no-op (TUI equivalent also checks its in-memory dict only). - Pass quiet_mode=True explicitly, matching the TUI/gateway callers. - Use ensure_mcp_discovery_before_agent_build() (landed on main after the PR) instead of bare wait_for_mcp_discovery() so the ACP agent build is self-sufficient and gets the retry-after-zero-connected allowance, matching CLI/one-shot construction sites. |
||
|---|---|---|
| .. | ||
| test_acp_commands.py | ||
| test_acp_images.py | ||
| test_acp_mcp_discovery.py | ||
| test_detect_provider_entra.py | ||