Adam Durham 71435fa0ea fix(agent): cancel in-flight background review before a new live turn ... A background memory/skill review (agent/background_review.py) forks a second, complete AIAgent in a daemon thread that deliberately shares the live agent's own session_id for prompt-cache warmth. Nothing previously stopped a user's next live turn from starting while that fork was still mid-conversation, letting both stream against the same session_id and credentials concurrently. That produced two observable failures: - Doubled prompt-token accounting on the live turn's own calls (the two concurrent request/response streams under one session_id confuse the token-usage bookkeeping), triggering premature context compression. - A lockup that a normal interrupt could not clear: the review fork is a fully independent AIAgent with its own _interrupt_requested flag, and was never added to the parent's _active_children list -- the only list AIAgent.interrupt() actually walks for cross-agent cancellation -- so a live-turn Ctrl+C had no propagation path to it at all. Fix, three files: 1. agent/agent_init.py -- add _background_review_agent / _background_review_lock tracking state to every AIAgent, mirroring the existing _active_children pattern. 2. agent/background_review.py -- the review fork now registers itself on the parent's _active_children right after construction (reusing the same list/lock interrupt() already fans out to for real subagent delegation), and unregisters on every exit path (success, the tool-whitelist finally, and the outer exception safety-net). All registration is defensive (getattr/try-except) so an AIAgent built without going through agent_init.py's setup degrades to "no cross-turn cancellation" instead of aborting the whole review. 3. agent/conversation_loop.py -- at the very start of every run_conversation() turn, if a prior background review is still in-flight, it is now proactively cancelled via interrupt() before the live turn proceeds -- fire-and-forget, non-blocking, adds no latency. Adds 3 regression tests to tests/run_agent/test_background_review.py, confirmed to fail against the pre-fix code via a scripted revert. Verified: ruff clean on all touched files; 66/66 background-review and interrupt-propagation tests pass; 256/256 across turn_finalizer + run_agent regression suites; no fork-only symbols in the diff.		2026-08-09 16:13:52 +05:30
..
lsp	fix(runtime): resolve Hermes-managed Node and uv before bare PATH	2026-08-01 21:17:51 -04:00
monitoring	fix(otlp): span exporter now inherits configured resource_attributes	2026-08-08 18:11:02 -07:00
pet	…
proxy_sources	…
secret_sources	fix(gateway): hydrate cold profile secret sources	2026-08-02 00:11:50 -07:00
transports	fix: suppress pydantic serializer warnings leaking to the terminal	2026-08-08 23:14:30 -07:00
verify	Integrate verify subsystem with the existing verification stack	2026-08-07 10:11:05 -07:00
__init__.py	…
account_usage.py	…
agent_init.py	fix(agent): cancel in-flight background review before a new live turn	2026-08-09 16:13:52 +05:30
agent_runtime_helpers.py	feat(agent): read_window_below tool — which OS window is underneath the desktop app	2026-08-08 12:17:50 -05:00
anthropic_adapter.py	fix: suppress pydantic serializer warnings leaking to the terminal	2026-08-08 23:14:30 -07:00
async_utils.py	…
aux_accounting.py	…
auxiliary_client.py	fix(agent): stop titling a session after our own scaffolding, or a TTS model	2026-08-09 04:33:58 -05:00
azure_identity_adapter.py	fix(secrets): scope-aware Azure credential presence reads in identity diagnostics	2026-08-02 10:02:33 -07:00
backend_identity.py	…
background_review.py	fix(agent): cancel in-flight background review before a new live turn	2026-08-09 16:13:52 +05:30
battery.py	…
bedrock_adapter.py	…
billing_links.py	…
billing_usage.py	…
billing_view.py	…
bounded_response.py	…
browser_provider.py	fix(browser): replace expired cloud sessions	2026-08-02 11:18:41 +05:30
browser_registry.py	…
chat_completion_helpers.py	fix: suppress pydantic serializer warnings leaking to the terminal	2026-08-08 23:14:30 -07:00
codex_responses_adapter.py	feat(compression): native OpenAI Responses server-side compaction for gpt-5.6	2026-08-08 11:24:45 -07:00
codex_runtime.py	fix(codex): split reasoning summary parts on summary_index	2026-08-06 22:02:46 -05:00
coding_context.py	…
context_breakdown.py	…
context_compressor.py	fix(compression): charge stale thinking to the tail budget only on the newest assistant turn (#73624)	2026-08-08 17:42:34 -07:00
context_engine.py	Revert "fix: rewire DCP context engine to current main architecture"	2026-08-08 23:09:45 +05:30
context_references.py	fix(docker): read attached binary files in backend (#76577)	2026-08-08 05:44:18 -07:00
conversation_compression.py	fix(sessions): give titles provenance so they stop overwriting themselves	2026-08-08 17:07:21 -05:00
conversation_loop.py	fix(agent): cancel in-flight background review before a new live turn	2026-08-09 16:13:52 +05:30
copilot_acp_client.py	…
credential_persistence.py	…
credential_pool.py	fix(agent): rebind pool entry id after env credential refresh	2026-08-08 19:17:02 -07:00
credential_sources.py	fix(auth): read .env as utf-8-sig in the dotenv-vs-shell detector	2026-08-08 12:32:23 -07:00
credits_tracker.py	…
curator.py	perf(curator): trim dead tool-schema from the LLM review fork	2026-08-03 18:21:17 +05:30
curator_backup.py	refactor: fold simplify findings — 6th copy in update_cmd, drop dead wrapper + speculative kwarg, behavior-contract tests	2026-08-08 15:10:35 +05:30
delegation_context.py	fix(cron): don't let a cron job inherit a kanban worker's dispatcher identity	2026-08-06 03:16:26 +05:30
display.py	refactor(discord): simplify tool preview links	2026-08-02 21:48:06 -07:00
error_classifier.py	fix: show explicit member spend cap message instead of 'no credits'	2026-08-07 19:47:40 +05:30
errors.py	…
estop.py	fix: post-merge audit follow-ups for #81138/#81139/#81141/#81148	2026-08-08 05:21:09 -07:00
file_safety.py	…
gemini_native_adapter.py	fix(gemini): interpose placeholder model turn between tool result and user text	2026-08-05 17:21:01 -07:00
gemini_schema.py	…
i18n.py	…
image_gen_provider.py	feat(media): opt-in upscale pass for image_generate and video_generate across FAL and Krea	2026-08-08 14:49:28 -07:00
image_gen_registry.py	…
image_routing.py	…
insights.py	refactor(insights): drop consumer-less get_skill_breakdown alias (simplify-pass)	2026-08-03 18:45:43 +05:30
interrupt_compat.py	fix(compression): let explicit interrupts cancel safely	2026-08-02 22:15:20 +05:30
iteration_budget.py	…
jiter_preload.py	…
kanban_stop.py	…
learn_prompt.py	fix(learn): process large sources incrementally	2026-08-08 05:09:43 -07:00
learning_graph.py	…
learning_graph_render.py	…
learning_mutations.py	…
lmstudio_reasoning.py	…
manual_compression_feedback.py	…
markdown_tables.py	…
memory_manager.py	…
memory_provider.py	fix(openviking): integrate reliability and configuration hardening	2026-08-03 20:35:47 +05:30
message_content.py	…
message_sanitization.py	fix(agent): preserve destroyed tool-call argument bytes in the WARNING log	2026-08-07 16:57:11 +05:30
moa_loop.py	perf(moa): cache resolved preset + per-slot runtime to cut cold-start latency (#66793)	2026-08-03 22:43:15 +05:30
moa_trace.py	…
model_metadata.py	fix(model-metadata): resolve provider prefixes from live registry	2026-08-09 01:51:12 -07:00
models_dev.py	…
moonshot_schema.py	…
native_compaction.py	fix(compression): correct prune boundary + exempt native compaction checkpoints	2026-08-08 14:09:41 -07:00
nous_rate_guard.py	…
onboarding.py	…
oneshot.py	…
outbound_webhooks.py	fix(hooks): flush outbound queue at interpreter exit	2026-08-02 15:01:11 -07:00
plugin_llm.py	…
portal_tags.py	…
process_bootstrap.py	…
prompt_builder.py	fix(desktop): keep earlier HUD windows in scope for the turn	2026-08-08 19:17:30 -05:00
prompt_cache_boundary.py	refactor(cache): share the boundary-declaration helper and simplify the registry	2026-08-09 15:25:12 +05:30
prompt_caching.py	perf(cache): harden the stable-prefix boundary against eviction and memory growth	2026-08-09 15:25:12 +05:30
rate_limit_tracker.py	…
reactions.py	…
reasoning_summaries.py	fix(reasoning): keep gpt-5.x summary parts as separate blocks on the chat wire	2026-08-06 22:02:37 -05:00
reasoning_timeouts.py	…
redact.py	polish: document newline residual, reuse span local, cheap check first	2026-08-07 17:50:03 +05:30
relay_llm.py	fix(relay): bypass managed execution for nested calls inside managed callbacks	2026-08-08 23:46:17 -07:00
relay_runtime.py	fix(relay): bypass managed execution for nested calls inside managed callbacks	2026-08-08 23:46:17 -07:00
relay_tools.py	fix(relay): bypass managed execution for nested calls inside managed callbacks	2026-08-08 23:46:17 -07:00
replay_cleanup.py	…
retry_utils.py	…
runtime_cwd.py	…
secret_scope.py	fix(secrets): allowlist API_SERVER listener settings as global deployment env	2026-08-02 09:59:52 -07:00
session_activity.py	refactor(agent): pin session activity heartbeat cadence + harden best-effort write	2026-08-02 16:16:36 -07:00
shell_hooks.py	fix: finish the missing-encoding sweep — BOM-tolerant reads for user-edited stores	2026-08-08 12:32:23 -07:00
skill_bundles.py	…
skill_commands.py	refactor(cache): share the boundary-declaration helper and simplify the registry	2026-08-09 15:25:12 +05:30
skill_preprocessing.py	…
skill_utils.py	fix(cron): don't let a cron job inherit a kanban worker's dispatcher identity	2026-08-06 03:16:26 +05:30
ssl_guard.py	fix(ssl_guard): tolerate truststore SSLContext.get_ca_certs() NotImplementedError on Windows	2026-08-08 15:10:24 +05:30
ssl_verify.py	…
stream_diag.py	…
stream_single_writer.py	…
subagent_lifecycle.py	fix(compression): let explicit interrupts cancel safely	2026-08-02 22:15:20 +05:30
subdirectory_hints.py	fix(context): dedupe subdirectory hints by content digest and skip backup/vendor dirs	2026-08-03 20:43:34 +05:30
subscription_view.py	…
system_prompt.py	fix: revert except ImportError back to except Exception	2026-08-08 13:57:44 +05:30
think_scrubber.py	…
thinking_timeout_guidance.py	…
thread_scoped_output.py	fix: preserve session history when a turn crashes	2026-08-06 23:08:23 -05:00
title_generator.py	refactor(title): decide on the stored title and the real turns behind it	2026-08-09 04:33:58 -05:00
tool_dispatch_helpers.py	feat(image): parallelize image_generate batches	2026-08-03 22:53:32 +05:30
tool_executor.py	feat(agent): read_window_below tool — which OS window is underneath the desktop app	2026-08-08 12:17:50 -05:00
tool_guardrails.py	…
tool_result_classification.py	…
trace_upload.py	…
trajectory.py	…
transcription_provider.py	…
transcription_registry.py	…
tts_provider.py	…
tts_registry.py	…
turn_context.py	fix(agent): stop cron and subagent runs auto-titling their sessions	2026-08-09 04:33:58 -05:00
turn_finalizer.py	fix(agent,gateway): class-level lone-surrogate chokepoints (#80366 #55143 #55309 #50959 #19819)	2026-08-08 12:31:19 -07:00
turn_retry_state.py	feat(compression): native OpenAI Responses server-side compaction for gpt-5.6	2026-08-08 11:24:45 -07:00
turn_summary.py	…
usage_pricing.py	…
verification_evidence.py	Integrate verify subsystem with the existing verification stack	2026-08-07 10:11:05 -07:00
verification_stop.py	Integrate verify subsystem with the existing verification stack	2026-08-07 10:11:05 -07:00
verify_hooks.py	…
vertex_adapter.py	…
video_gen_provider.py	feat(media): opt-in upscale pass for image_generate and video_generate across FAL and Krea	2026-08-08 14:49:28 -07:00
video_gen_registry.py	…
web_search_provider.py	…
web_search_registry.py	…