Ben Barclay c15945655f fix(terminal): sanitize host/relative cwd OVERRIDE before it reaches docker run -w (#50636) ... terminal_tool() resolves a per-task cwd override that WINS over config["cwd"]: cwd = overrides.get("cwd") or config["cwd"] config["cwd"] is sanitized for container backends in _get_env_config() (host prefixes /Users//home//C:\\/C:/ and relative paths are replaced with the backend default /root). But the override was applied RAW — it was never run through that guard. The gateway/TUI registers the host launch dir as a cwd override for workspace tracking (tui_gateway/server.py _register_session_cwd -> _terminal_task_cwd -> _session_cwd -> os.getcwd()), so on a container backend a host path leaked straight to `docker run -w <host-path>`: - Windows desktop: -w C:\Users\<user> -> container fails to start (exit 125) - POSIX: -w /home/<user> -> same The ACP adapter translates its override cwd (acp_adapter/session.py _translate_acp_cwd), but the gateway path did neither translation nor sanitization, so the override bypassed the one guard that would have caught it. Fix: extract the host/relative-path predicate into a shared _is_unusable_container_cwd() helper (so the existing _get_env_config() sanitizer and the new guard can't drift), and re-apply it to the *resolved* cwd at the override-resolution site. Valid in-container override paths (RL/benchmark sandboxes that set cwd to /workspace, /root, ...) are absolute non-host paths and pass through untouched. Tests: unit-pin the predicate (Windows backslash/forwardslash, POSIX home, macOS /Users, relative, valid container paths) AND an E2E call-site pin that drives terminal_tool() with a host-path override registered and asserts the cwd reaching _create_environment is sanitized. Mutation-verified: reverting the call-site guard makes the two host-path E2E tests fail (showing the raw host path leaking) while the valid-/workspace-override test stays green.		2026-06-25 02:33:40 +00:00
..
__init__.py	…
conftest.py	…
test_accretion_caps.py	…
test_ansi_strip.py	…
test_approval.py	…
test_approval_heartbeat.py	…
test_approval_interrupt.py	…
test_approval_plugin_hooks.py	…
test_async_delegation.py	…
test_base_environment.py	…
test_blueprints.py	…
test_browser_camofox.py	…
test_browser_camofox_persistence.py	…
test_browser_camofox_state.py	…
test_browser_cdp_override.py	…
test_browser_cdp_tool.py	…
test_browser_chromium_check.py	…
test_browser_cleanup.py	…
test_browser_cloud_fallback.py	…
test_browser_cloud_provider_cache.py	…
test_browser_console.py	…
test_browser_content_none_guard.py	…
test_browser_eval_supervisor_path.py	…
test_browser_hardening.py	…
test_browser_homebrew_paths.py	…
test_browser_hybrid_routing.py	…
test_browser_lightpanda.py	…
test_browser_orphan_reaper.py	…
test_browser_secret_exfil.py	…
test_browser_ssrf_local.py	…
test_browser_supervisor.py	…
test_browser_supervisor_healthcheck.py	…
test_budget_config.py	…
test_checkpoint_manager.py	…
test_clarify_gateway.py	…
test_clarify_tool.py	…
test_clipboard.py	…
test_code_execution.py	…
test_code_execution_modes.py	…
test_code_execution_windows_env.py	…
test_command_guards.py	…
test_computer_use.py	…
test_computer_use_capture_routing.py	…
test_computer_use_vision_routing.py	…
test_config_null_guard.py	…
test_container_cwd_sanitize.py	fix(terminal): sanitize host/relative cwd OVERRIDE before it reaches docker run -w (#50636)	2026-06-25 02:33:40 +00:00
test_credential_files.py	…
test_credential_pool_env_fallback.py	…
test_cron_approval_mode.py	…
test_cron_prompt_injection.py	…
test_cronjob_run_immediate.py	…
test_cronjob_tools.py	…
test_cross_profile_guard.py	…
test_daytona_environment.py	…
test_debug_helpers.py	…
test_delegate.py	Merge pull request #47959 from NousResearch/bb/pets-gen	2026-06-24 19:41:34 -05:00
test_delegate_composite_toolsets.py	…
test_delegate_subagent_timeout_diagnostic.py	…
test_delegate_toolset_scope.py	…
test_discord_tool.py	…
test_docker_config_migrate.py	…
test_docker_environment.py	…
test_docker_find.py	…
test_docker_orphan_reaper_integration.py	…
test_dockerfile_immutable_install.py	fix(docker): redirect lazy installs to a durable target so opt-in backends work in the immutable image (#51136)	2026-06-25 09:20:13 +10:00
test_dockerfile_node_modules_perms.py	…
test_dockerfile_pid1_reaping.py	…
test_env_passthrough.py	…
test_env_probe.py	…
test_execute_code_approval_cluster.py	…
test_feishu_tools.py	…
test_file_operations.py	…
test_file_operations_edge_cases.py	…
test_file_ops_cwd_tracking.py	…
test_file_read_guards.py	…
test_file_staleness.py	…
test_file_state_registry.py	…
test_file_sync.py	…
test_file_sync_back.py	…
test_file_sync_perf.py	…
test_file_tools.py	…
test_file_tools_container_config.py	…
test_file_tools_cwd_resolution.py	…
test_file_tools_live.py	…
test_file_tools_tilde_profile.py	…
test_file_write_safety.py	…
test_force_dangerous_override.py	…
test_fuzzy_match.py	…
test_gateway_cwd_contract.py	…
test_hardline_blocklist.py	…
test_heartbeat_stale_thresholds.py	…
test_hidden_dir_filter.py	…
test_homeassistant_tool.py	…
test_image_generation.py	…
test_image_generation_artifacts.py	…
test_image_generation_env.py	…
test_image_generation_image_to_image.py	…
test_image_generation_plugin_dispatch.py	…
test_init_session_cwd_respect.py	…
test_interrupt.py	…
test_kanban_redaction.py	…
test_kanban_tools.py	…
test_lazy_deps.py	…
test_lazy_deps_durable_target.py	test(lazy-deps): make durable-target tests network-free	2026-06-25 09:20:13 +10:00
test_line_ending_preservation.py	…
test_llm_content_none_guard.py	…
test_local_background_child_hang.py	…
test_local_env_blocklist.py	…
test_local_env_cwd_recovery.py	…
test_local_env_windows_msys.py	…
test_local_interrupt_cleanup.py	…
test_local_shell_init.py	…
test_local_tempdir.py	…
test_managed_browserbase_and_modal.py	…
test_managed_media_gateways.py	…
test_managed_modal_environment.py	…
test_managed_tool_gateway.py	…
test_mcp_cancelled_error_propagation.py	…
test_mcp_capability_gating.py	…
test_mcp_circuit_breaker.py	…
test_mcp_client_cert.py	…
test_mcp_dynamic_discovery.py	…
test_mcp_elicitation.py	…
test_mcp_empty_error_message.py	…
test_mcp_image_content.py	…
test_mcp_invalid_url.py	…
test_mcp_loop_profile_override.py	…
test_mcp_oauth.py	…
test_mcp_oauth_bidirectional.py	…
test_mcp_oauth_cold_load_expiry.py	…
test_mcp_oauth_integration.py	…
test_mcp_oauth_manager.py	…
test_mcp_oauth_metadata.py	…
test_mcp_preflight_content_type.py	…
test_mcp_probe.py	…
test_mcp_reconnect_signal.py	…
test_mcp_sse_transport.py	…
test_mcp_stability.py	…
test_mcp_structured_content.py	…
test_mcp_tool.py	…
test_mcp_tool_401_handling.py	…
test_mcp_tool_issue_948.py	…
test_mcp_tool_session_expired.py	…
test_mcp_utility_capability_gating.py	…
test_memory_tool.py	…
test_memory_tool_import_fallback.py	…
test_memory_tool_schema.py	…
test_microsoft_graph_auth.py	…
test_microsoft_graph_client.py	…
test_mixture_of_agents_tool.py	…
test_modal_bulk_upload.py	…
test_modal_sandbox_fixes.py	fix(terminal): sanitize host/relative cwd OVERRIDE before it reaches docker run -w (#50636)	2026-06-25 02:33:40 +00:00
test_modal_snapshot_isolation.py	…
test_notify_on_complete.py	…
test_osv_check.py	…
test_parse_env_var.py	…
test_patch_failure_tracking.py	…
test_patch_parser.py	…
test_pr_6656_regressions.py	…
test_process_registry.py	…
test_read_extract.py	…
test_read_loop_detection.py	…
test_refresh_agent_mcp_tools.py	…
test_registry.py	…
test_resolve_path.py	…
test_schema_sanitizer.py	…
test_search_budget_truncation.py	…
test_search_error_guard.py	…
test_search_hidden_dirs.py	…
test_send_message_missing_platforms.py	…
test_send_message_react.py	…
test_send_message_target_parse.py	…
test_send_message_telegram_proxy.py	…
test_send_message_tool.py	…
test_session_search.py	…
test_shared_container_task_id.py	…
test_signal_media.py	…
test_singularity_preflight.py	…
test_skill_env_passthrough.py	…
test_skill_improvements.py	…
test_skill_manager_tool.py	…
test_skill_provenance.py	…
test_skill_size_limits.py	…
test_skill_usage.py	…
test_skill_view_path_check.py	…
test_skill_view_traversal.py	…
test_skills_ast_audit.py	…
test_skills_guard.py	…
test_skills_hub.py	…
test_skills_hub_browse_sh.py	…
test_skills_hub_clawhub.py	…
test_skills_list_modified_diff.py	…
test_skills_sync.py	…
test_skills_tool.py	…
test_slash_confirm.py	…
test_smart_approval_injection.py	…
test_spotify_client.py	…
test_ssh_bulk_upload.py	…
test_ssh_environment.py	…
test_stage2_hook_gateway_bootstrap_state.py	…
test_stage2_hook_immutable_install.py	…
test_stage2_hook_install_method_stamp.py	…
test_stage2_hook_log_dir_seed.py	…
test_stage2_hook_puid_pgid.py	…
test_stage2_hook_toplevel_chown.py	…
test_stage2_hook_unraid_uid.py	…
test_stage2_hook_user_flag_guard.py	…
test_subprocess_stdin_guard.py	…
test_symlink_prefix_confusion.py	…
test_sync_back_backends.py	…
test_terminal_compound_background.py	…
test_terminal_config_env_sync.py	…
test_terminal_exit_semantics.py	…
test_terminal_foreground_timeout_cap.py	…
test_terminal_none_command_guard.py	…
test_terminal_output_transform_hook.py	…
test_terminal_requirements.py	…
test_terminal_task_cwd.py	…
test_terminal_timeout_output.py	…
test_terminal_tool.py	…
test_terminal_tool_pty_fallback.py	…
test_terminal_tool_requirements.py	…
test_threaded_process_handle.py	…
test_threat_patterns.py	…
test_tirith_security.py	fix(tools): catch mkdtemp OSError in tirith install to prevent unbounded retry and temp-dir leak (#51826)	2026-06-25 02:13:56 +05:30
test_todo_tool.py	…
test_tool_backend_helpers.py	…
test_tool_output_limits.py	…
test_tool_result_storage.py	…
test_tool_search.py	…
test_transcription.py	…
test_transcription_command_providers.py	…
test_transcription_dotenv_fallback.py	…
test_transcription_plugin_dispatch.py	…
test_transcription_tools.py	…
test_tts_command_providers.py	…
test_tts_dotenv_fallback.py	…
test_tts_gemini.py	…
test_tts_kittentts.py	…
test_tts_max_text_length.py	…
test_tts_mistral.py	…
test_tts_opus_routing.py	…
test_tts_path_traversal.py	…
test_tts_piper.py	…
test_tts_plugin_dispatch.py	…
test_tts_speed.py	…
test_tts_xai_speech_tags.py	…
test_url_safety.py	…
test_video_analyze.py	…
test_video_generation_dispatch.py	…
test_video_generation_dynamic_schema.py	…
test_video_generation_tool_surface_matrix.py	…
test_vision_native_fast_path.py	…
test_vision_tools.py	…
test_voice_cli_integration.py	…
test_voice_mode.py	…
test_watch_patterns.py	…
test_web_providers.py	…
test_web_providers_brave_free.py	…
test_web_providers_ddgs.py	fix(ddgs): bound DuckDuckGo search with a wall-clock timeout (#36776)	2026-06-25 01:45:06 +05:30
test_web_providers_searxng.py	…
test_web_providers_xai.py	…
test_web_tools_config.py	…
test_web_tools_tavily.py	…
test_website_policy.py	…
test_windows_compat.py	…
test_windows_native_support.py	…
test_write_approval.py	…
test_write_deny.py	…
test_x_search_tool.py	…
test_yolo_mode.py	…
test_zombie_process_cleanup.py	…