From 5565d3b9ced02788906dc9065cd7a0db6f21a818 Mon Sep 17 00:00:00 2001 From: Vineeth Voruganti <13438633+VVoruganti@users.noreply.github.com> Date: Tue, 28 Jul 2026 15:30:40 -0400 Subject: [PATCH] chore: clear the two remaining basedpyright warnings `uv run basedpyright tests/ src/` reported two warnings in files that predate this change. The pre-commit hook is file-scoped, so neither was visible unless the owning file was touched. - src/vector_store/__init__.py: join the lancedb error message with explicit `+` instead of adjacent literals (reportImplicitStringConcatenation). - tests/test_cache_redaction.py: the test covers a private helper deliberately, so annotate the import (reportPrivateUsage). No behavior change; whole-tree check is now clean. Co-Authored-By: Claude Opus 5 (1M context) --- src/vector_store/__init__.py | 8 ++++---- tests/test_cache_redaction.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/vector_store/__init__.py b/src/vector_store/__init__.py index 85fdd9ff..17eeec34 100644 --- a/src/vector_store/__init__.py +++ b/src/vector_store/__init__.py @@ -207,10 +207,10 @@ def _create_store_by_type(store_type: str) -> VectorStore: except ImportError as exc: raise RuntimeError( "VECTOR_STORE.TYPE is set to 'lancedb', but the 'lancedb' package " - "is not installed (for example on macOS Intel, where it is omitted " - "from dependencies because PyPI has no wheel). " - "Use TYPE 'pgvector' or 'turbopuffer', or install lancedb manually. " - f"Original import error: {exc}" + + "is not installed (for example on macOS Intel, where it is omitted " + + "from dependencies because PyPI has no wheel). " + + "Use TYPE 'pgvector' or 'turbopuffer', or install lancedb manually. " + + f"Original import error: {exc}" ) from exc return LanceDBVectorStore() diff --git a/tests/test_cache_redaction.py b/tests/test_cache_redaction.py index 0ff2bbc7..3a8e6891 100644 --- a/tests/test_cache_redaction.py +++ b/tests/test_cache_redaction.py @@ -2,7 +2,7 @@ import pytest -from src.cache.client import _redact_cache_url +from src.cache.client import _redact_cache_url # pyright: ignore[reportPrivateUsage] class TestRedactCacheUrl: