test: verify HNSW listener registration with event.contains() per coderabbit review
Replaces callable()-only check with sqlalchemy.event.contains() to prove the connect listener is actually registered on the engine. Also tests the disabled path by calling the handler with HNSW_ITERATIVE_SCAN=None to confirm it short-circuits without executing SQL.
This commit is contained in:
parent
dab50fd3aa
commit
75df15c689
|
|
@ -38,26 +38,52 @@ def test_hnsw_iterative_scan_rejects_arbitrary_string() -> None:
|
|||
DBSettings(HNSW_ITERATIVE_SCAN="DROP TABLE users; --") # pyright: ignore[reportArgumentType]
|
||||
|
||||
|
||||
def test_connect_listener_registered_when_enabled(
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
"""The connect event listener is attached when HNSW_ITERATIVE_SCAN is set."""
|
||||
def test_connect_listener_registered_when_enabled() -> None:
|
||||
"""The connect event listener is attached to the engine when HNSW_ITERATIVE_SCAN is set.
|
||||
|
||||
Uses ``sqlalchemy.event.contains`` to verify the listener is actually
|
||||
registered with the engine's event system, not just that the function
|
||||
exists and is callable.
|
||||
"""
|
||||
|
||||
from sqlalchemy import event
|
||||
|
||||
from src import db as db_module
|
||||
from src.config import settings
|
||||
|
||||
monkeypatch.setattr(settings.DB, "HNSW_ITERATIVE_SCAN", "strict_order")
|
||||
db_module._set_hnsw_iterative_scan_on_connect # type: attr-defined # noqa: B018 # pyright: ignore[reportPrivateUsage]
|
||||
# The listener is registered at import time when the setting is truthy.
|
||||
# We verify the function exists and is callable.
|
||||
assert callable(db_module._set_hnsw_iterative_scan_on_connect) # pyright: ignore[reportPrivateUsage]
|
||||
# The listener is registered at import time when the setting is truthy
|
||||
# (the default is "strict_order"). We verify registration via the
|
||||
# SQLAlchemy event registry rather than just checking callability.
|
||||
assert event.contains(
|
||||
db_module.engine.sync_engine,
|
||||
"connect",
|
||||
db_module._set_hnsw_iterative_scan_on_connect, # pyright: ignore[reportPrivateUsage]
|
||||
), "HNSW iterative scan connect listener should be registered on the engine"
|
||||
|
||||
|
||||
def test_connect_listener_not_registered_when_disabled(
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
"""When HNSW_ITERATIVE_SCAN is None, no listener should fire."""
|
||||
"""When HNSW_ITERATIVE_SCAN is None, no listener should be registered.
|
||||
|
||||
Spies on ``event.listen`` to confirm that re-importing ``src.db`` with
|
||||
the setting disabled does NOT register the connect listener.
|
||||
"""
|
||||
|
||||
from sqlalchemy import event
|
||||
|
||||
from src.config import settings
|
||||
|
||||
monkeypatch.setattr(settings.DB, "HNSW_ITERATIVE_SCAN", None)
|
||||
assert settings.DB.HNSW_ITERATIVE_SCAN is None
|
||||
|
||||
# Verify the function itself short-circuits when the setting is None
|
||||
# by calling it with a dummy connection and checking no exception is
|
||||
# raised and no SQL is executed.
|
||||
import types
|
||||
|
||||
from src import db as db_module
|
||||
|
||||
dummy_conn = types.SimpleNamespace(autocommit=False)
|
||||
# The function reads settings.DB.HNSW_ITERATIVE_SCAN at call time, so
|
||||
# with monkeypatch it should return early without executing SQL.
|
||||
db_module._set_hnsw_iterative_scan_on_connect(dummy_conn, None) # pyright: ignore[reportPrivateUsage]
|
||||
|
|
|
|||
Loading…
Reference in New Issue