RomanNum3ral
/
honcho
mirror of https://github.com/plastic-labs/honcho.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix schema validation typing test coverage

This commit is contained in:
adavyas 2026-04-07 12:25:20 -04:00
parent de82b80227
commit c6ca57b9d8
1 changed files with 30 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
tests/test_schema_validations.py
View File

@ -242,14 +242,16 @@ class TestResolvedConfigurationMigration:
class TestReasoningConfigurationValidation:
def test_session_create_allows_blank_custom_instructions(self):
session = SessionCreate(
name="test-session",
configuration={
"reasoning": {
"enabled": True,
"custom_instructions": "",
}
},
session = SessionCreate.model_validate(
{
"name": "test-session",
"configuration": {
"reasoning": {
"enabled": True,
"custom_instructions": "",
}
},
}
)
assert session.configuration is not None
@ -266,14 +268,16 @@ class TestReasoningConfigurationValidation:
)
with pytest.raises(ValidationError) as exc_info:
SessionCreate(
name="test-session",
configuration={
"reasoning": {
"enabled": True,
"custom_instructions": "focus on durable preferences",
}
},
SessionCreate.model_validate(
{
"name": "test-session",
"configuration": {
"reasoning": {
"enabled": True,
"custom_instructions": "focus on durable preferences",
}
},
}
)
assert "MAX_CUSTOM_INSTRUCTIONS_TOKENS" in str(exc_info.value)
@ -289,14 +293,16 @@ class TestReasoningConfigurationValidation:
)
with pytest.raises(ValidationError) as exc_info:
SessionCreate(
name="test-session",
configuration={
"reasoning": {
"enabled": True,
"custom_instructions": "focus on stable preferences and long-term plans",
}
},
SessionCreate.model_validate(
{
"name": "test-session",
"configuration": {
"reasoning": {
"enabled": True,
"custom_instructions": "focus on stable preferences and long-term plans",
}
},
}
)
assert "custom_instructions" in str(exc_info.value)