From 7e1d62b86672564deb3aea67b862fadab159ce76 Mon Sep 17 00:00:00 2001 From: Timothy Stewart Date: Sun, 2 Aug 2026 13:51:53 -0500 Subject: [PATCH] fix(metallb): guard cilium_bgp variable before evaluating - The 'Deploy metallb manifest' and 'Deploy metallb pool' conditionals evaluate 'not cilium_bgp' directly, which raises an undefined-variable error when the k3s_server role runs without cilium_bgp in scope and no Cilium variables are set - Guard with 'cilium_bgp is not defined' so the condition resolves cleanly when Cilium BGP is not configured - Fixes #644 --- roles/k3s_server/tasks/main.yml | 2 +- roles/k3s_server_post/tasks/main.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/k3s_server/tasks/main.yml b/roles/k3s_server/tasks/main.yml index d0306c9..ae406e0 100644 --- a/roles/k3s_server/tasks/main.yml +++ b/roles/k3s_server/tasks/main.yml @@ -27,7 +27,7 @@ - name: Deploy metallb manifest ansible.builtin.include_tasks: metallb.yml tags: metallb - when: kube_vip_lb_ip_range is not defined and (not cilium_bgp or cilium_iface is not defined) + when: kube_vip_lb_ip_range is not defined and (cilium_bgp is not defined or cilium_iface is not defined) - name: Deploy kube-vip manifest ansible.builtin.include_tasks: kube-vip.yml diff --git a/roles/k3s_server_post/tasks/main.yml b/roles/k3s_server_post/tasks/main.yml index 1a02d8d..dbb38dc 100644 --- a/roles/k3s_server_post/tasks/main.yml +++ b/roles/k3s_server_post/tasks/main.yml @@ -12,7 +12,7 @@ - name: Deploy metallb pool ansible.builtin.include_tasks: metallb.yml tags: metallb - when: kube_vip_lb_ip_range is not defined and (not cilium_bgp or cilium_iface is not defined) + when: kube_vip_lb_ip_range is not defined and (cilium_bgp is not defined or cilium_iface is not defined) - name: Remove tmp directory used for manifests ansible.builtin.file: