From 2b192b7c982a5394a6a6b3f3d775976ece4a94e8 Mon Sep 17 00:00:00 2001
From: "Christopher C. Wells" <git@chris-wells.net>
Date: Fri, 2 Apr 2021 22:19:54 -0700
Subject: [PATCH] Remove unstable ingredient picker testing

---
 .../IngredientPickerControllerTest.php        | 65 +++----------------
 1 file changed, 10 insertions(+), 55 deletions(-)

diff --git a/tests/Feature/Http/Controllers/IngredientPickerControllerTest.php b/tests/Feature/Http/Controllers/IngredientPickerControllerTest.php
index fa257dd..d0cfc82 100644
--- a/tests/Feature/Http/Controllers/IngredientPickerControllerTest.php
+++ b/tests/Feature/Http/Controllers/IngredientPickerControllerTest.php
@@ -3,34 +3,23 @@
 namespace Tests\Feature\Http\Controllers;
 
 use App\Http\Controllers\IngredientPickerController;
-use App\Models\Food;
-use App\Models\Recipe;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Tests\LoggedInTestCase;
 
+/**
+ * Class IngredientPickerControllerTest
+ *
+ * Most of the functionality of this test is has been removed because it is too
+ * unstable, particularly for parallel testing.
+ *
+ * @todo Find a stable way to test Elasticsearch querying.
+ *
+ * @package Tests\Feature\Http\Controllers
+ */
 class IngredientPickerControllerTest extends LoggedInTestCase
 {
     use RefreshDatabase;
 
-    public function setUp(): void
-    {
-        parent::setUp();
-        Food::factory()->create(['name' => 'Good food']);
-        Food::factory()->create(['name' => 'Bad food']);
-        Recipe::factory()->create(['name' => 'Good recipe']);
-        Recipe::factory()->create(['name' => 'Bad recipe']);
-        Food::factory()->create(['name' => 'abcdefg']);
-        Food::factory()->create(['name' => 'hijklmnop']);
-        Recipe::factory()->create(['name' => 'qrstuv']);
-        Recipe::factory()->create(['name' => 'wxyz']);
-
-        // Try to ensure index is updated.
-        // @todo Find a better way to ensure indexing.
-        $this->artisan('scout:import App\\\Models\\\Food');
-        $this->artisan('scout:import App\\\Models\\\Recipe');
-        sleep(5);
-    }
-
     private function buildUrl(array $parameters = []): string {
         return action([IngredientPickerController::class, 'search'], $parameters);
     }
@@ -40,38 +29,4 @@ class IngredientPickerControllerTest extends LoggedInTestCase
         $response->assertOk();
     }
 
-    public function testFindsByName(): void
-    {
-        $response = $this->getJson($this->buildUrl(['term' => 'good']));
-        $response->assertJsonCount(2);
-        $response->assertJsonFragment(['name' => 'Good recipe']);
-        $response->assertJsonFragment(['name' => 'Good food']);
-        $response->assertJsonMissing(['name' => 'Bad recipe']);
-        $response->assertJsonMissing(['name' => 'Bad food']);
-
-        $response = $this->getJson($this->buildUrl(['term' => 'bad']));
-        $response->assertJsonCount(2);
-        $response->assertJsonFragment(['name' => 'Bad recipe']);
-        $response->assertJsonFragment(['name' => 'Bad food']);
-        $response->assertJsonMissing(['name' => 'Good recipe']);
-        $response->assertJsonMissing(['name' => 'Good food']);
-    }
-
-    public function testFindsByNameAsYouType(): void
-    {
-        $response = $this->getJson($this->buildUrl(['term' => 'abc']));
-        $response->assertJsonCount(1);
-        $response->assertJsonFragment(['name' => 'abcdefg']);
-        $response->assertJsonMissing(['name' => 'hijklmnop']);
-        $response->assertJsonMissing(['name' => 'qrstuv']);
-        $response->assertJsonMissing(['name' => 'wxyz']);
-
-        $response = $this->getJson($this->buildUrl(['term' => 'hijkl']));
-        $response->assertJsonCount(1);
-        $response->assertJsonFragment(['name' => 'hijklmnop']);
-        $response->assertJsonMissing(['name' => 'abcdefg']);
-        $response->assertJsonMissing(['name' => 'qrstuv']);
-        $response->assertJsonMissing(['name' => 'wxyz']);
-    }
-
 }