RomanNum3ral
/
kcal
mirror of https://github.com/kcal-app/kcal.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add old data rebuild test for recipe add

This commit is contained in:
Christopher C. Wells 2021-04-06 14:37:38 -07:00
parent 9b795a743b
commit 69701ee4d8
1 changed files with 30 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
tests/Feature/Http/Controllers/RecipeControllerTest.php
View File

@ -61,7 +61,6 @@ class RecipeControllerTest extends HttpControllerTestCase
$response = $this->get($create_url); $response = $this->get($create_url);
$response->assertOk(); $response->assertOk();
$ingredient_amounts = IngredientAmount::factory() $ingredient_amounts = IngredientAmount::factory()
->count(10) ->count(10)
->make(['parent_id' => null, 'parent_type' => null]); ->make(['parent_id' => null, 'parent_type' => null]);
@ -105,18 +104,22 @@ class RecipeControllerTest extends HttpControllerTestCase
$response->assertSessionHasNoErrors(); $response->assertSessionHasNoErrors();
} }
public function testSessionKeepsOldInput(): void { public function testSessionKeepsOldInputOnAdd(): void {
$instance = $this->createInstance(); $instance = $this->createInstance();
$data = $this->createInvalidFormData($instance);
$create_url = action([$this->class(), 'create']);
$store_url = action([$this->class(), 'store']);
$response = $this->from($create_url)->post($store_url, $data);
$response->assertRedirect($create_url);
$response->assertSessionHasErrors();
$response->assertSessionHasInput('ingredients', $data['ingredients']);
$response->assertSessionHasInput('steps', $data['steps']);
$response->assertSessionHasInput('separators', $data['separators']);
}
$data = [ public function testSessionKeepsOldInputOnEdit(): void {
'ingredients' => $this->createFormDataFromIngredientAmounts($instance->ingredientAmounts), $instance = $this->createInstance();
'steps' => $this->createFormDataFromRecipeSteps($instance->steps), $data = $this->createInvalidFormData($instance);
'separators' => $this->createFormDataFromRecipeSeparators($instance->ingredientSeparators),
] + $instance->toArray();
// Remove the first amount value to force a form error.
$data['ingredients']['amount'][0] = NULL;
$edit_url = action([$this->class(), 'edit'], [$this->routeKey() => $instance]); $edit_url = action([$this->class(), 'edit'], [$this->routeKey() => $instance]);
$put_url = action([$this->class(), 'update'], [$this->routeKey() => $instance]); $put_url = action([$this->class(), 'update'], [$this->routeKey() => $instance]);
$response = $this->from($edit_url)->put($put_url, $data); $response = $this->from($edit_url)->put($put_url, $data);
@ -132,6 +135,22 @@ class RecipeControllerTest extends HttpControllerTestCase
$this->assertEquals($edit_url, url()->current()); $this->assertEquals($edit_url, url()->current());
} }
/**
* Create invalid form data for testing rejected forms.
*/
private function createInvalidFormData(Recipe $instance): array {
$instance = $this->createInstance();
$data = [
'ingredients' => $this->createFormDataFromIngredientAmounts($instance->ingredientAmounts),
'steps' => $this->createFormDataFromRecipeSteps($instance->steps),
'separators' => $this->createFormDataFromRecipeSeparators($instance->ingredientSeparators),
] + $instance->toArray();
// Remove the first amount value to force a form error.
$data['ingredients']['amount'][0] = NULL;
return $data;
}
/** /**
* Convert ingredient amount instances in to a form data style array. * Convert ingredient amount instances in to a form data style array.
*/ */