From 76f82989bf63bfdd683f1c843bc69eeb8d35e215 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Fri, 26 Jun 2026 06:08:15 -0400 Subject: [PATCH] Fixes #22532: Ensure all empty table headers have an ARIA label (#22545) --- netbox/extras/tables/tables.py | 2 +- netbox/netbox/tables/columns.py | 3 +++ netbox/templates/core/configrevision_restore.html | 2 +- netbox/templates/dcim/inc/panels/inventory_items.html | 2 +- netbox/templates/dcim/panels/component_inventory_items.html | 2 +- netbox/templates/dcim/panels/interface_wireless.html | 2 +- netbox/templates/dcim/virtualchassis_edit.html | 2 +- netbox/templates/extras/inc/script_list_content.html | 2 +- netbox/templates/ipam/inc/panels/fhrp_groups.html | 2 +- netbox/templates/ipam/panels/fhrp_groups.html | 2 +- 10 files changed, 12 insertions(+), 9 deletions(-) diff --git a/netbox/extras/tables/tables.py b/netbox/extras/tables/tables.py index 3df1d7c70..fac030061 100644 --- a/netbox/extras/tables/tables.py +++ b/netbox/extras/tables/tables.py @@ -424,7 +424,7 @@ class NotificationTable(NetBoxTable): orderable=False, attrs={ 'td': {'class': 'w-1'}, - 'th': {'class': 'w-1'}, + 'th': {'class': 'w-1', 'aria-label': _('Type')}, }, verbose_name='' ) diff --git a/netbox/netbox/tables/columns.py b/netbox/netbox/tables/columns.py index e0d16c664..b6e441228 100644 --- a/netbox/netbox/tables/columns.py +++ b/netbox/netbox/tables/columns.py @@ -248,6 +248,9 @@ class ActionsColumn(tables.Column): direct button link and icon (default: True) """ attrs = { + 'th': { + 'aria-label': _('Actions'), + }, 'td': { 'class': 'text-end text-nowrap noprint p-1' } diff --git a/netbox/templates/core/configrevision_restore.html b/netbox/templates/core/configrevision_restore.html index ee0ce1ebe..4604aaaba 100644 --- a/netbox/templates/core/configrevision_restore.html +++ b/netbox/templates/core/configrevision_restore.html @@ -36,7 +36,7 @@ {% trans "Parameter" %} {% trans "Current Value" %} {% trans "New Value" %} - + diff --git a/netbox/templates/dcim/inc/panels/inventory_items.html b/netbox/templates/dcim/inc/panels/inventory_items.html index ff49d1a53..a42cc1301 100644 --- a/netbox/templates/dcim/inc/panels/inventory_items.html +++ b/netbox/templates/dcim/inc/panels/inventory_items.html @@ -18,7 +18,7 @@ {% trans "Name" %} {% trans "Label" %} {% trans "Role" %} - + diff --git a/netbox/templates/dcim/panels/component_inventory_items.html b/netbox/templates/dcim/panels/component_inventory_items.html index 02b3e1d6a..209bb360d 100644 --- a/netbox/templates/dcim/panels/component_inventory_items.html +++ b/netbox/templates/dcim/panels/component_inventory_items.html @@ -8,7 +8,7 @@ {% trans "Name" %} {% trans "Label" %} {% trans "Role" %} - + diff --git a/netbox/templates/dcim/panels/interface_wireless.html b/netbox/templates/dcim/panels/interface_wireless.html index dfc7a3452..33fc95d30 100644 --- a/netbox/templates/dcim/panels/interface_wireless.html +++ b/netbox/templates/dcim/panels/interface_wireless.html @@ -6,7 +6,7 @@ - + {% if peer %} diff --git a/netbox/templates/dcim/virtualchassis_edit.html b/netbox/templates/dcim/virtualchassis_edit.html index dbe029fa6..7be4d2ec3 100644 --- a/netbox/templates/dcim/virtualchassis_edit.html +++ b/netbox/templates/dcim/virtualchassis_edit.html @@ -66,7 +66,7 @@ - + diff --git a/netbox/templates/extras/inc/script_list_content.html b/netbox/templates/extras/inc/script_list_content.html index ed30e423d..0c9e91cb4 100644 --- a/netbox/templates/extras/inc/script_list_content.html +++ b/netbox/templates/extras/inc/script_list_content.html @@ -33,7 +33,7 @@ - + diff --git a/netbox/templates/ipam/inc/panels/fhrp_groups.html b/netbox/templates/ipam/inc/panels/fhrp_groups.html index d5e0102f9..26f9a137f 100644 --- a/netbox/templates/ipam/inc/panels/fhrp_groups.html +++ b/netbox/templates/ipam/inc/panels/fhrp_groups.html @@ -24,7 +24,7 @@ - + diff --git a/netbox/templates/ipam/panels/fhrp_groups.html b/netbox/templates/ipam/panels/fhrp_groups.html index aa9a91dcc..7dd1c8f19 100644 --- a/netbox/templates/ipam/panels/fhrp_groups.html +++ b/netbox/templates/ipam/panels/fhrp_groups.html @@ -10,7 +10,7 @@ - +
{% trans "Local" %}{% trans "Peer" %}{% trans "Serial" %} {% trans "Position" %} {% trans "Priority" %}
{% trans "Description" %} {% trans "Last Run" %} {% trans "Status" %}
{% trans "Protocol" %} {% trans "Virtual IPs" %} {% trans "Priority" %}
{% trans "Protocol" %} {% trans "Virtual IPs" %} {% trans "Priority" %}