Drop the redundant enum checks from the string length bounds

ChoiceField does not subclass CharField, so the enclosing issubclass() guard
already excludes an enum-bearing property. The extra condition never fired and
implied a second guard was needed, inconsistent with the numeric branch below.
This commit is contained in:
Jason Novinger 2026-09-15 09:07:37 -05:00
parent 5402cc8c7e
commit 779ce96dc7
1 changed files with 2 additions and 2 deletions

View File

@ -115,9 +115,9 @@ class JSONSchemaProperty:
# it's safe to check against CharField here because the other
# CharField-derived fields are ruled out by the "is a string check" above
if issubclass(field_class, forms.CharField):
if self.minLength is not None and not self.enum:
if self.minLength is not None:
field_kwargs['min_length'] = self.minLength
if self.maxLength is not None and not self.enum:
if self.maxLength is not None:
field_kwargs['max_length'] = self.maxLength
if self.pattern is not None:
field_kwargs['validators'] = [