From 7a3397798a903f87e13744d1b26e90a024304cf5 Mon Sep 17 00:00:00 2001 From: Arthur Hanson Date: Wed, 13 May 2026 14:38:30 -0700 Subject: [PATCH] Fixes #16851: Add missing Aria Labels (#22178) * #16851 - Add missing Aria Labels * #16851 - Add missing Aria Labels * #16851 - Add missing Aria Labels * fixes for form field labels * cleanup * cleanup * cleanup * cleanup * cleanup * cleanup * cleanup --- netbox/dcim/forms/model_forms.py | 3 +- netbox/netbox/forms/mixins.py | 4 ++ netbox/netbox/tables/columns.py | 11 +++- netbox/templates/account/preferences.html | 4 +- netbox/templates/dcim/device/base.html | 2 +- netbox/templates/dcim/device_edit.html | 12 ++-- netbox/templates/dcim/devicebay_populate.html | 8 +-- .../dcim/inc/interface_vlans_table.html | 8 +-- netbox/templates/dcim/manufacturer.html | 2 +- netbox/templates/dcim/module.html | 2 +- .../dcim/panels/rack_elevations.html | 2 +- .../templates/dcim/virtualchassis_edit.html | 4 +- netbox/templates/generic/object_edit.html | 6 +- netbox/templates/generic/object_list.html | 4 +- netbox/templates/inc/filter_list.html | 4 +- netbox/templates/inc/light_toggle.html | 8 +-- netbox/templates/inc/notification_bell.html | 8 ++- netbox/templates/inc/paginator.html | 24 ++++---- netbox/templates/inc/table_controls_htmx.html | 12 ++-- netbox/templates/inc/toast.html | 5 +- netbox/templates/inc/user_menu.html | 18 +++--- .../virtualization/virtualmachine/base.html | 2 +- netbox/utilities/forms/fields/fields.py | 2 +- .../utilities/templates/buttons/bookmark.html | 4 +- .../templates/buttons/subscribe.html | 4 +- .../templates/form_helpers/render_field.html | 22 ++++---- .../form_helpers/render_fieldset.html | 14 ++--- .../templates/helpers/utilization_graph.html | 2 + .../utilities/templates/navigation/menu.html | 10 ++-- .../templates/widgets/apiselect.html | 6 +- .../templates/widgets/markdown_input.html | 4 +- netbox/utilities/templatetags/form_helpers.py | 56 ++++++++++++++++++- netbox/utilities/tests/test_templatetags.py | 42 ++++++++++++++ netbox/virtualization/forms/model_forms.py | 3 +- 34 files changed, 219 insertions(+), 103 deletions(-) diff --git a/netbox/dcim/forms/model_forms.py b/netbox/dcim/forms/model_forms.py index 9672cc54b..7745deb60 100644 --- a/netbox/dcim/forms/model_forms.py +++ b/netbox/dcim/forms/model_forms.py @@ -690,7 +690,8 @@ class DeviceForm(TenancyForm, PrimaryModelForm): ) local_context_data = JSONField( required=False, - label='' + label='', + widget=forms.Textarea(attrs={'aria-label': _('Local config context data')}) ) virtual_chassis = DynamicModelChoiceField( label=_('Virtual chassis'), diff --git a/netbox/netbox/forms/mixins.py b/netbox/netbox/forms/mixins.py index 681047f56..2f031c70f 100644 --- a/netbox/netbox/forms/mixins.py +++ b/netbox/netbox/forms/mixins.py @@ -109,6 +109,10 @@ class SavedFiltersMixin(forms.Form): def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) + # Ensure the underlying ') + return format_html( + '', + title_text, title_text, + ) class BooleanColumn(tables.Column): diff --git a/netbox/templates/account/preferences.html b/netbox/templates/account/preferences.html index b2898da6c..3550bd1cb 100644 --- a/netbox/templates/account/preferences.html +++ b/netbox/templates/account/preferences.html @@ -44,7 +44,7 @@ - + {% trans "Table" %} {% trans "Ordering" %} @@ -55,7 +55,7 @@ {% for table, prefs in request.user.config.data.tables.items %} - + {{ table }} {{ prefs.ordering|join:", "|placeholder }} diff --git a/netbox/templates/dcim/device/base.html b/netbox/templates/dcim/device/base.html index 9a2286e40..d40afb51b 100644 --- a/netbox/templates/dcim/device/base.html +++ b/netbox/templates/dcim/device/base.html @@ -20,7 +20,7 @@ -