From a3b50b4198c89a349b17655c4ae6a4040cad5221 Mon Sep 17 00:00:00 2001 From: Brian Tiemann Date: Thu, 21 May 2026 05:54:48 -0400 Subject: [PATCH] Guard against rename_fields=None in submitted comprehension The `submitted` list comprehension previously called `f in self.rename_fields` which raises TypeError when a subclass sets rename_fields=None. Short-circuit with `self.rename_fields and` to safely handle None, empty tuple, and populated tuples uniformly. Co-Authored-By: Claude Sonnet 4.6 --- netbox/netbox/views/generic/bulk_views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netbox/netbox/views/generic/bulk_views.py b/netbox/netbox/views/generic/bulk_views.py index 4512a789a..bdd7528d0 100644 --- a/netbox/netbox/views/generic/bulk_views.py +++ b/netbox/netbox/views/generic/bulk_views.py @@ -962,7 +962,7 @@ class BulkRenameView(GetReturnURLMixin, BaseMultiObjectView): if form.is_valid(): submitted = [ f for f in request.POST.getlist('field_names') - if f in self.rename_fields + if self.rename_fields and f in self.rename_fields ] if self.rename_fields and not submitted: form.add_error(None, _("Select at least one field to rename."))