RomanNum3ral
/
netbox
mirror of https://github.com/netbox-community/netbox.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Closes #22333: Use lowercase username for testing 

The test failures arises from unstable sorting of the usernames
depending on the collation used in the PostgreSQL database used for
testing. When a case-insensitive collation is used 'testuser' is sorted
before 'User*' and because this user has permissions assigned and
additional query is issued resulting in 12 queries. When a
case-sensitive collation is used the sorting is inverted. Because the
'User*' don't have permissions only 11 queries are sent to the database.

Using only testusers with lowercase names enforces stable sorting
across collations.
This commit is contained in:
Tobias Genannt 2026-06-02 14:05:28 +02:00 committed by Jeremy Stretch
parent 8f974e3cc8
commit b4fdd6f209
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
netbox/users/tests/test_api.py
View File

@ -39,25 +39,25 @@ class UserTestCase(APIViewTestCases.APIViewTestCase):
permissions[2].object_types.add(ObjectType.objects.get_by_natural_key('dcim', 'rack'))
users = (
User(username='User1', password='FooBarFooBar1'),
User(username='User2', password='FooBarFooBar2'),
User(username='User3', password='FooBarFooBar3'),
User(username='user1', password='FooBarFooBar1'),
User(username='user2', password='FooBarFooBar2'),
User(username='user3', password='FooBarFooBar3'),
)
User.objects.bulk_create(users)
cls.create_data = [
{
'username': 'User4',
'username': 'user4',
'password': 'FooBarFooBar4',
'permissions': [permissions[0].pk],
},
{
'username': 'User5',
'username': 'user5',
'password': 'FooBarFooBar5',
'permissions': [permissions[1].pk],
},
{
'username': 'User6',
'username': 'user6',
'password': 'FooBarFooBar6',
'permissions': [permissions[2].pk],
},