df8ebd94ea
filter-displacement: Refactor onto obs::source_factory
...
This drastically improves stability and prevents all exceptions from leaking into libobs C code, which prevents crashes and unexpected freezes from exception handlers further down the stack.
Additionally minor work was done to further improve the quality and user experience for the filter.
2019-11-18 03:03:11 +01:00
6efdb1950b
obs-source-factory: Fix typo and missing return
2019-11-18 03:03:11 +01:00
db85883821
obs/obs-source-factory: Fix potential null-pointer-dereference
2019-11-17 14:07:54 +01:00
87f83738c3
gs-helper: Add common debug colors
2019-10-31 05:59:16 +01:00
10681d30c8
gs-helper: Remove unused constructor
2019-10-18 23:04:23 +02:00
90cdc30ef1
gs-helper: Add class for managed debug markers
2019-10-18 22:59:30 +02:00
9b0ea98243
filter-transform: Add GPU debug markers
2019-10-18 22:42:07 +02:00
ba71b43a39
gfx-source-texture: Add debug markers
2019-10-18 22:32:54 +02:00
141a5efd00
filter-transform: Refactor onto obs::source_factory
2019-10-18 22:32:54 +02:00
bacf52f9b6
source-mirror: Refactor to improve performance
...
Caching the output of a source is only necessary for really expensive to render sources, so it is disabled by default now. Thanks to that, most Source Mirrors are now "free" instead of requiring two context switches and a texture, while those really expensive can be manually set to cache.
The scaling mode is also set to disabled instead of point when rescaling is off to further improve performance. The previous method would incorrectly cause an extra texture to be used.
Additionally we now have support for debug markers for graphics debugging, allowing us to exactly tell apart improvements in rendering cost for this source.
2019-10-18 22:32:54 +02:00
52c9e372ba
source-mirror: Refactor onto obs::source_factory
2019-10-18 22:31:53 +02:00
d47ab0570f
obs-source-factory: Barebone Source Factory and Instance
...
This class and template should be used to reduce the code clutter from repeatedly doing the same thing. It requires OBS v24.0 or newer since the get_properties2 and get_defaults2 API were fully implemented with it.
2019-10-18 22:31:52 +02:00
6db575c9cf
source-mirror: Add debug markers
2019-10-16 04:54:40 +02:00
03c2a68846
gfx-effect-source: Catch exceptions as const
2019-10-13 07:28:59 +02:00
e832dbd628
filter-sdf-effects: Fix and improve various problematic locations
2019-10-13 07:28:29 +02:00
4fe76a85ae
filter-blur: Fix some warnings
2019-10-13 07:28:12 +02:00
bbcbd0fa1e
filter-color-grade: Fix and improve various problematic locations
2019-10-13 07:27:59 +02:00
e07d7c01fc
filter-displacement: Fix and improve various problematic locations
2019-10-13 07:27:42 +02:00
ef5e6ac896
filter-dynamic-mask: Catch const exceptions
2019-10-13 07:08:56 +02:00
06d9a3d2f5
filter-transform: Catch and log exceptions
2019-10-13 07:08:02 +02:00
96466100b4
obs-source: Ensure that exceptions are const
2019-10-13 07:07:31 +02:00
b5d3131203
filter-dynamic-mask: Fix some crashy locations
2019-10-13 07:02:04 +02:00
0ef94aad0f
gs-vertexbuffer: Fix and improve various problematic locations
2019-10-13 06:38:15 +02:00
45d2431ef5
source-mirror: Fix and improve various problematic locations
2019-10-13 06:20:41 +02:00
fd0b79e97d
utility-event: Remove unused event handler
2019-10-13 05:58:53 +02:00
f1a376d44b
cmake: Add commit to version.hpp template
...
Switches out the `const uint16_t` for actual defines, which are easier to deal with and work in C out of the box.
2019-10-13 05:54:20 +02:00
e02225262c
obs-source: Add noexcept try-catch to C facing callbacks
2019-09-07 21:35:32 +02:00
d6f1979dee
project: Fix missing returns
2019-09-07 21:28:54 +02:00
5a4d38d249
project: Fix a massive list of dangerous warnings
...
This is a massive improvement to stability and safety when using the plugin, as all exceptions should now no longer be leaked into C controlled code, which can't actually handle exceptions at all.
Warnings fixed:
* Potentially throwing exception during library load.
* Possibly throwing function passed to C.
* Statement does nothing.
* Variable is initialized but not referenced.
* Variable overloads variable in parent scope.
2019-09-05 18:42:28 +02:00
2a4a3bf501
util-memory: Cast to intptr_t
2019-09-05 18:09:33 +02:00
4c44496b87
source-mirror: Handle uncaught exceptions in C callbacks
...
Fixes various crashes and undefined behavior due to exceptions falling into C code where they now wreak havoc with the current stack.
2019-09-04 20:52:37 +02:00
f65dfcbbf0
filter-blur: Don't throw exceptions into C code
...
It is extremely problematic to throw C++ exceptions into C code, especially because C code usually does not handle C++ exceptions at all. Therefore we have to prevent any exception from leaving the function and define it as noexcept.
2019-09-04 20:43:40 +02:00
f61cdeb582
utility-event: Fix compile errors
2019-09-04 20:30:16 +02:00
29ab00633c
utility-event: Safer event handling with proper lifetime
...
The util::event code suffers from the problem that it could call into a class that no longer exists, corrupting memory or even crashing. By tracking lifetime using std::weak_ptr<void> this can be avoided and the dead listeners can be automatically removed.
2019-09-04 16:36:32 +02:00
da9124fc1a
util-memory: Avoid MSVC specific C++ and use Std++ if available
2019-09-04 03:22:05 +02:00
82faab4380
project: Re-apply formatting
2019-09-04 03:03:41 +02:00
ce7e4c97d4
project: Don't use non-standard strcmpi
2019-09-04 03:02:19 +02:00
03c704de1a
project: Correct usage of exceptions and include stdexcept
2019-09-04 02:59:04 +02:00
4765c57828
filter-sdf-effects: Don't define structs in nameless unions
2019-09-04 02:49:04 +02:00
f27320c6c9
project: Remove use of P_INITIALIZER
...
Does not support cross-platform very well and breaks on Apple for no apparent reason.
Add resolution scale to shader filter.
2019-09-04 02:47:27 +02:00
9ace96285d
filter-dynamic-mask: Use snprintf instead of sprintf_s
2019-09-04 02:39:59 +02:00
2e98c2e754
color-grade: Fix and improve advanced options
...
These new options allow further control over the Tint tool in Color grading.
2019-09-04 02:18:40 +02:00
781307fbe6
color-grade: Add further Tint options
2019-09-04 01:41:15 +02:00
deeb6719c4
project: Apply formatting
2019-08-24 12:59:32 +02:00
250dc97603
gfx-effect-source: enumerate child sources correctly
2019-08-07 20:40:04 +02:00
a04d102568
gfx-effect-source: Support for textures and some crash resistance
2019-08-07 20:22:12 +02:00
f945f08ab0
strings: Texture formats
2019-08-07 20:21:39 +02:00
d7e66b17f1
filter-shader: Don't ignore all properties
2019-08-07 19:22:10 +02:00
b8fc0d5284
source-shader: Fix rendering
2019-08-07 19:20:44 +02:00
7fdd9498a0
filter-shader: Fix blending
2019-08-07 19:20:32 +02:00
90699f6b6f
gfx-effect-source: Implement defaults for bool, value and matrix
2019-08-07 19:19:56 +02:00
39e6959c67
source-shader: Fix rendering and reapply parameters on change
2019-08-07 18:43:34 +02:00
181df6e3d9
filter-shader: Reapply parameters if there was a change
2019-08-07 18:43:19 +02:00
9be36d5ec4
gfx-effect-source: Add function to get "default" value
2019-08-07 18:42:54 +02:00
2b2f87e6fc
gfx-effect-source: Fix validity check
...
Had the check inverted oops.
2019-08-07 18:16:20 +02:00
c88535c7ab
gfx-effect-source: Remove/replace old defines
2019-08-07 18:11:46 +02:00
c670ab60a1
source-shader: Use custom draw video_render
2019-08-07 18:10:44 +02:00
8cb2ddaa82
source-shader, cmake: 'Shader' source
2019-08-07 18:06:48 +02:00
1b34e5210a
gfx-effect-source: Expose defines to set default file and technique
2019-08-07 18:06:24 +02:00
9ad93c0ee9
filter-shader: Rename from Custom shader
2019-08-07 18:05:49 +02:00
98a18480d0
gfx-effect-source: Fix UI mode detection
2019-08-07 17:45:32 +02:00
8ec8a22928
filter-custom-shader: Add new callbacks
2019-08-07 17:37:52 +02:00
335847945d
gfx-effect-source: Allow overriding value and visibility of parameters
2019-08-07 17:37:34 +02:00
ff4a556f3f
filter-custom-shader: Update to use new gfx::effect_source::effect_source
2019-08-07 17:15:46 +02:00
bde4e278bf
gfx-effect-source: Further work on rewrite
...
This partially implements most behavior to an acceptable degree for use right now.
2019-08-07 17:14:44 +02:00
845a2cbb21
gs-effect: Don't include the null character in strings
2019-08-07 17:14:14 +02:00
b88cc0fe01
gs-effect: Check correct size in get_default_string
2019-08-07 17:07:54 +02:00
8603fef897
gs-effect: Fix get_string and get_default_string
2019-08-07 16:41:26 +02:00
c6559d84ba
gs-effect: Check if effect is nullptr, not if its a valid ptr
...
Woops, that somehow went completely by me without checking.
2019-08-07 16:17:12 +02:00
7b0159947e
gs-effect: Add helpers and fix bad enable_shared_from_this
2019-08-07 16:11:09 +02:00
e59bc2fdd2
filter-custom-shader: Rewrite from scratch
2019-08-07 12:43:23 +02:00
1092dc1de1
gfx-effect-source: Complete rewrite from scratch
2019-08-07 12:42:25 +02:00
087cd79a7a
filter-color-grade: Always return something in get_width/get_height
2019-08-07 12:41:34 +02:00
f5b4c1f7a1
filter-color-grade: Fix crash if color-grade.effect is missing
2019-08-04 23:20:35 +02:00
71b223dcb5
gs-effect: Add ::create for shared_ptr and remove default constructor
2019-08-04 23:19:38 +02:00
9db7cd8da2
filter-displacement: Fix crash on nullptr file path
2019-08-04 23:14:43 +02:00
0c447f4055
gs-effect: Use std::shared_ptr and track effect lifetime
...
This fixes the case where the effect vanishes, but we still hold an invalid pointer to a parameter of that effect. With the new code, the effect will not vanish as long as an effect pointer exists.
However, all effects must be created either through std::shared_ptr or std::make_shared. If they were not made through one of those means, the code will crash on the ->shared_from_this() call.
2019-08-04 23:12:30 +02:00
ff6f4d5ddf
gs-effect: Add string support, get accessors and annotations
2019-08-04 22:44:46 +02:00
9be02e6f2b
project: Fix up previous commit
2019-08-04 20:29:04 +02:00
0e350415b3
project: Apply new coding guidelines
2019-08-04 16:20:26 +02:00
533de01061
filter-color-grade: Always return true in tool_modified
2019-08-04 12:34:54 +02:00
2ca15bb28c
source-mirror: Allow overriding audio layout
2019-08-04 12:34:42 +02:00
93ba39545f
filter-color-grade: Implement Tool selection for OBS Studio 24.x
2019-08-03 12:29:47 +02:00
721f2bdf8f
filter-color-grade: Fully feature Color Grading filter
...
Allows controlling Lift, Gamma, Gain, Offset, Tint and various Correction factors directly from within OBS without having to create a new LUT.
2019-08-02 23:49:18 +02:00
a6ce6c5860
utility: Add some extra functionality
2019-08-02 23:49:17 +02:00
ad270bc6ee
gs-effect: Fix uninitialized member variable
2019-08-02 23:49:17 +02:00
c716e75ba3
project: Fix various catch-by-value locations
2019-07-27 19:57:50 +02:00
e887a53463
filter-sdf-effects: Fix a crash due to failed rendering
...
For whatever reason, the initial render target render fails when an async source is being used.
2019-07-27 19:57:49 +02:00
2c94852ba8
source-mirror: Allow changing source alignment
...
Adds a new property to control the alignment of the source within the calculated boundary when rescaling the source. Also fixes the permanently left aligned mirror at the same time.
2019-05-28 20:04:26 +02:00
45728702ff
utility: Add recursive text lookup function
...
Similar to the one used in enc-amf, allows looking up string containing other strings, thus drastically simplifying the necessary time to build translated strings, while also caching them for future use.
2019-05-28 19:54:23 +02:00
95b1e81ee5
filter-dynamic-mask: Don't crash if a texture is missing
...
When copying or re-ordering filters, an occasional crash can be observed due to the rendering not being possible yet. With this, it will simply revert back to the original source instead of crashing.
2019-05-28 02:51:27 +02:00
ccc4c6ea22
filter-sdf-effects: Fix and improve effect rendering
...
Fixes the bug that rendering an outline would remove all other effects not directly under the outline, while also improving the rendering speed drastically by only initializing and clearing the rendertarget once instead of for each effect.
2019-05-28 02:51:27 +02:00
9e7894c9c3
filter-dynamic-mask: Implement Dynamic Mask filter
...
This filter allows the use of another source as a mask, allowing complex filter graphs and trippy effects, such as creating a text source with three animated videos, each using a different color channel as the mask.
Fixes #18 .
2019-04-27 17:56:10 +02:00
c46e881697
obs-source: Don't un/register audio capture with no source
...
Fixes the log spam if a source could not be found.
2019-04-27 16:08:54 +02:00
8bb1ca50ac
obs-source-tracker: Also keep track of sources being renamed
...
When a source was renamed, obs::source_tracker did not use the new name and instead relied on the old name. This caused source lists with this feature to slowly degrade over time as sources were renamed, until libobs was restarted.
With this fix the renamed sources are now properly tracked, updating as expected.
Related Issue: #64
2019-04-27 16:07:50 +02:00
f6687c7ed6
filter-displacement: Don't crash if the file can't be found
...
Fixes a user reported issue where obs-studio began crashing out of nowhere.
2019-04-23 17:20:18 +02:00
bbcde070f3
filter-displacement: Do not allow zero-length file names
...
Fixes a crash when using c_str() on an empty string, causing an unexpected crash.
2019-04-23 17:00:18 +02:00
f8e685cf42
project: Apply clang-format manually again
2019-04-19 20:40:07 +02:00
be4d42312d
project: Fix all remaining portability issues
...
Clang on Windows and Clang on Linux behave differently, and of course GCC on Windows (MinGW) and GCC on Linux do too. This is the point where using either compiler on either platform should successfully compile the project without any issues.
Clang and GCC have a ton of warnings however, which definitely need to be fixed in the near future. Some of them are great warnings, like old C style casts, others are non-sense like suggest brackets.
Fixes #47
Fixes #60
2019-04-19 14:18:29 +02:00
aac52f736d
project: Clang support
...
Lots and lots of errors and warnings fixed with this single commit, in the name of clang support.
Related #60 , #47 .
2019-04-19 09:42:15 +02:00
Michael Fabian 'Xaymar' Dirks