From 8a48c3b7114fd94807afa301cf0ea0646a38d791 Mon Sep 17 00:00:00 2001 From: rdb Date: Mon, 21 Nov 2022 18:26:19 +0100 Subject: [PATCH] pgraph: Remove recursive lock grab in `Light.set_color()` Harmless, but unnecessary --- panda/src/pgraph/light.I | 2 +- panda/src/pgraph/light.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/panda/src/pgraph/light.I b/panda/src/pgraph/light.I index 6dd0428836..d173740607 100644 --- a/panda/src/pgraph/light.I +++ b/panda/src/pgraph/light.I @@ -71,8 +71,8 @@ INLINE void Light:: set_color(const LColor &color) { CDWriter cdata(_cycler); cdata->_color = color; + cdata->_viz_geom_stale = true; _has_color_temperature = false; - mark_viz_stale(); } /** diff --git a/panda/src/pgraph/light.cxx b/panda/src/pgraph/light.cxx index 8631cb5b0b..d70a83c195 100644 --- a/panda/src/pgraph/light.cxx +++ b/panda/src/pgraph/light.cxx @@ -125,7 +125,7 @@ set_color_temperature(PN_stdfloat temperature) { CDWriter cdata(_cycler); cdata->_color = color; - mark_viz_stale(); + cdata->_viz_geom_stale = true; } /**