From d87cbbce628ec2a20cea4dfc3ddf9b59f0f337a6 Mon Sep 17 00:00:00 2001 From: rdb Date: Wed, 27 Nov 2024 18:10:18 +0100 Subject: [PATCH] dist: Validate application_id when building for Android --- direct/src/dist/commands.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/direct/src/dist/commands.py b/direct/src/dist/commands.py index 0496ae5c30..7d022014e2 100644 --- a/direct/src/dist/commands.py +++ b/direct/src/dist/commands.py @@ -519,6 +519,18 @@ class build_apps(setuptools.Command): tmp.update(self.package_data_dirs) self.package_data_dirs = tmp + if 'android' in self.platforms: + assert self.application_id, \ + 'Must have a valid application_id when targeting Android!' + + parts = self.application_id.split('.') + assert len(parts) >= 2, \ + 'application_id must contain at least one \'.\' separator!' + + for part in parts: + assert part.isidentifier(), \ + 'Each part of application_id must be a valid identifier!' + # Default to all supported ABIs (for the given Android version). if self.android_max_sdk_version and self.android_max_sdk_version < 21: assert self.android_max_sdk_version >= 19, \