Having depth test disabled is the default OpenGL state, and callbacks may quite reasonably expect to see the default state. Kivy seems to expect this, for one.
Problem is that WGL is strict about binding context in different thread while it is still bound in another thread. Either way we need to make sure the draw thread is not rendering, so if you call get_screenshot() from a thread other than the draw thread, it uses the GraphicsEngine to wait until the draw thread is idle and then asks it to do the get_screenshot().
Fixes#360
The assert is being triggered because the window is already being removed in open_windows. It does not really matter if it returns false anyway, as long as the window is removed one way or another.
This is required to make the test suite run with pipelining enabled.
It's necessary to let the draw thread do these tasks because that's where the OpenGL context is bound to. However, we need to let it access the data from the calling thread, so we have to temporarily change the pipeline stage of the draw thread.
I'm not really happy about this solution; it would be better to temporarily make the context current to the app thread, but we need a window for that, which we don't currently require to be passed into that method.
- Fix Windows pbuffer crash on Intel cards
- Fix crash when using pnmimage.write with unsupported format
- Fix GLSL diagnostics on Mesa GLES2 compiler
- Reduce warning severity when resizing immutable storage texture
- Print more debug info when FrameBufferProperties are insufficient
- Fix "Bam file contains objects of unknown type: MovingPart<LMatrix4f>"
- Fix memory leak in BulletTriangleMesh
- Fix pmerge in Python 3
The only transform still stored in CullableObject is internal transform.
NB: I haven't tested my PipeOcclusionCullTraverser changes. Please contact me if you encounter problems with it.
cxx: Fix missing includes masked by composite builds.
misc: Fix typos in comments.
config: Fix missing config forward-declarations.
direct: Adjust Python imports to panda3d.* instead of pandac.*.
display: Split graphicsWindow out into an extension.
framework: Use if/elif/elif/endif instead of ifdef/elif/elif/endif.
ode: Remove erroneous INLINE declarations.
interval: Fix missing import.
rdb
Sam Edwards
Younguk Kim
tobspr
David Rose