From 05973b2073bd07e67c55bb2feb0a64514cc250b5 Mon Sep 17 00:00:00 2001 From: Devin Foley Date: Thu, 9 Jul 2026 20:46:46 -0700 Subject: [PATCH] Enable sandbox environments for Grok local adapter (#9338) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Local CLI adapters can run against Paperclip-managed execution environments instead of only the host filesystem. > - The environment picker and environment capability API derive sandbox support from shared adapter capability lists. > - The Grok Build adapter is implemented as a local CLI adapter, but it was missing from those shared environment capability lists. > - That made Grok agents look local-only even when sandbox environments were configured. > - This pull request registers `grok_local` in the shared adapter constants and remote-managed environment support path. > - The benefit is that Grok Build agents can select the same local, SSH, and sandbox environment overrides as other local CLI adapters. ## Linked Issues or Issue Description No public GitHub issue exists for this bug. Inline bug report follows. ### Pre-submission checklist - [x] I have searched existing open and closed issues and this is not a duplicate. - [x] I am on `master`. - [x] I have confirmed the error originates in Paperclip itself, not in the Grok adapter provider or local configuration. ### What happened? When configuring a Grok Build local agent in the board UI, Paperclip did not expose configured sandbox environments as selectable environment overrides. The shared environment capability helper treated `grok_local` as local-only because it was missing from the remote-managed local adapter allowlist. ### Expected behavior Grok Build should behave like other local CLI adapters: when environments are enabled and a runnable sandbox environment exists, the agent configuration form should show the environment override selector and allow the sandbox to be selected. ### Steps to reproduce 1. Enable environments in instance experimental settings. 2. Configure at least one runnable sandbox environment. 3. Open the agent configuration form for a Grok Build local agent. 4. Observe that the sandbox environment is not offered as an override before this fix. ### Paperclip version or commit `master` before this PR. ### Deployment mode Local dev (`pnpm dev`). ### Installation method Built from source (`pnpm dev` / `pnpm build`). ### Agent adapter(s) involved - Grok Build local adapter. - Core bug in shared environment capability logic. ### Database mode Not database-related. ### Access context Board human operator. ### Relevant logs or output No runtime error is emitted; the issue is a missing UI option caused by shared capability metadata. ### Relevant config No secret-bearing config required. Reproduction only needs environments enabled and a runnable sandbox environment configured. ### Privacy checklist - [x] I have reviewed all pasted output for PII, usernames, file paths, API keys, tokens, company names, and redacted where necessary. ## What Changed - Added `grok_local` to the shared built-in adapter type list. - Added `grok_local` to the remote-managed adapter set used by environment capability helpers. - Added shared regression coverage for Grok local sandbox provider and driver support. - Added a UI render regression test that confirms Grok Build agents show the environment override when a runnable sandbox exists. ## Verification - `git diff --check` - Changed-file secret scan with `rg` for common token/key patterns. - `pnpm --filter @paperclipai/shared exec vitest run src/environment-support.test.ts` - `pnpm --dir ui exec vitest run src/components/AgentConfigForm.render.test.tsx` ## Risks - Low risk. This expands environment support for an existing local adapter to match the local CLI adapter behavior already used by Claude, Codex, Gemini, OpenCode, Cursor, and Pi. - Operators still need at least one configured runnable sandbox environment before a Grok agent has a sandbox option to select. - This PR was created from a Paperclip execution workspace branch whose name is runtime-provided; the PR body intentionally avoids internal issue identifiers or instance-local links. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled terminal/code execution environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --- packages/shared/src/constants.ts | 1 + .../shared/src/environment-support.test.ts | 31 ++++++++++++++++++- packages/shared/src/environment-support.ts | 1 + .../AgentConfigForm.render.test.tsx | 22 +++++++++++++ 4 files changed, 54 insertions(+), 1 deletion(-) diff --git a/packages/shared/src/constants.ts b/packages/shared/src/constants.ts index 287ae7835b..587d78d3cb 100644 --- a/packages/shared/src/constants.ts +++ b/packages/shared/src/constants.ts @@ -34,6 +34,7 @@ export const AGENT_ADAPTER_TYPES = [ "codex_local", "cursor_cloud", "gemini_local", + "grok_local", "hermes_gateway", "hermes_local", "opencode_local", diff --git a/packages/shared/src/environment-support.test.ts b/packages/shared/src/environment-support.test.ts index 59b4ec9e4e..396945b027 100644 --- a/packages/shared/src/environment-support.test.ts +++ b/packages/shared/src/environment-support.test.ts @@ -1,5 +1,10 @@ import { describe, expect, it } from "vitest"; -import { isSandboxProviderSupportedForAdapter } from "./environment-support.js"; +import { + adapterSupportsRemoteManagedEnvironments, + getEnvironmentCapabilities, + isSandboxProviderSupportedForAdapter, + supportedEnvironmentDriversForAdapter, +} from "./environment-support.js"; describe("isSandboxProviderSupportedForAdapter", () => { it("accepts additional sandbox providers for remote-managed adapters", () => { @@ -13,4 +18,28 @@ describe("isSandboxProviderSupportedForAdapter", () => { isSandboxProviderSupportedForAdapter("openclaw", "fake-plugin", ["fake-plugin"]), ).toBe(false); }); + + it("treats grok_local as a remote-managed local adapter", () => { + expect(adapterSupportsRemoteManagedEnvironments("grok_local")).toBe(true); + expect(supportedEnvironmentDriversForAdapter("grok_local")).toEqual(["local", "ssh", "sandbox"]); + expect( + isSandboxProviderSupportedForAdapter("grok_local", "fake-plugin", ["fake-plugin"]), + ).toBe(true); + }); + + it("includes grok_local sandbox support in environment capabilities", () => { + const capabilities = getEnvironmentCapabilities(["grok_local"], { + sandboxProviders: { + "fake-plugin": { displayName: "Fake Plugin" }, + }, + }); + + expect(capabilities.adapters).toEqual([ + expect.objectContaining({ + adapterType: "grok_local", + drivers: expect.objectContaining({ sandbox: "supported", ssh: "supported" }), + sandboxProviders: expect.objectContaining({ "fake-plugin": "supported" }), + }), + ]); + }); }); diff --git a/packages/shared/src/environment-support.ts b/packages/shared/src/environment-support.ts index 7373a9bd67..a60f77c5dd 100644 --- a/packages/shared/src/environment-support.ts +++ b/packages/shared/src/environment-support.ts @@ -41,6 +41,7 @@ const REMOTE_MANAGED_ADAPTERS = new Set([ "codex_local", "cursor", "gemini_local", + "grok_local", "opencode_local", "pi_local", ]); diff --git a/ui/src/components/AgentConfigForm.render.test.tsx b/ui/src/components/AgentConfigForm.render.test.tsx index 1f9a11b045..2c4d24cc6f 100644 --- a/ui/src/components/AgentConfigForm.render.test.tsx +++ b/ui/src/components/AgentConfigForm.render.test.tsx @@ -288,6 +288,28 @@ describe("AgentConfigForm environment selector", () => { expect(text).not.toContain("Inherit instance default"); }); + it("shows the environment override for Grok local agents", async () => { + const result = await renderForm( + [ + makeEnvironment({ id: "local-1", name: "Local", driver: "local" }), + makeEnvironment({ + id: "sandbox-1", + name: "E2B", + driver: "sandbox", + config: { provider: "e2b" }, + }), + ], + { adapterType: "grok_local" }, + ); + roots.push(result.root); + + const text = result.container.textContent ?? ""; + const selector = result.container.querySelector("select"); + + expect(text).toContain("Environment override"); + expect(selector?.textContent).toContain("E2B · sandbox"); + }); + it("keeps an existing non-runnable override visible so it can be cleared", async () => { const result = await renderForm( [