fix(ui): use issuePrefix instead of name-derived prefix in create dialog badges (#8550)

## Thinking Path

> - Paperclip is the open source app people use to manage AI agents at
work
> - Paperclip stores an `issuePrefix` on each company (e.g. "OPS") used
for issue identifiers (`OPS-1`) and company-prefixed routes
(`/OPS/dashboard`)
> - The create-dialog badges in NewIssueDialog, NewProjectDialog, and
NewGoalDialog were derived from the company display name using
`company.name.slice(0, 3).toUpperCase()` — so "Acme Labs" showed "ACM"
> - This is misleading because the badge visually represents the issue
prefix, but actually shows an unrelated 3-letter slice of the display
name
> - When a company has `issuePrefix = "OPS"` but `name = "Acme Labs"`,
the badge showed "ACM" while issues use "OPS-1"
> - This pull request replaces `name.slice(0, 3).toUpperCase()` with
`company.issuePrefix` in all three dialog badge components
> - The benefit is that the badge now matches the actual prefix used for
issues and routes, eliminating confusion

## Linked Issues or Issue Description

Fixes: #8501

## What Changed

- `ui/src/components/NewIssueDialog.tsx` (line ~1339): Replaced
`company.name.slice(0, 3).toUpperCase()` with `company.issuePrefix` in
the selected-company header badge
- `ui/src/components/NewIssueDialog.tsx`: Replaced
`company.name.slice(0, 3).toUpperCase()` with `company.issuePrefix` in
the company picker list badge
- `ui/src/components/NewProjectDialog.tsx`: Replaced
`selectedCompany.name.slice(0, 3).toUpperCase()` with
`selectedCompany.issuePrefix` in the selected-company header badge
- `ui/src/components/NewGoalDialog.tsx`: Replaced
`selectedCompany.name.slice(0, 3).toUpperCase()` with
`selectedCompany.issuePrefix` in the selected-company header badge

## Verification

1. Create or configure a company whose `issuePrefix` differs from the
first 3 letters of its display name (e.g. name = "Acme Labs",
issuePrefix = "OPS")
2. Open the New Task dialog — the selected-company header badge should
show "OPS", not "ACM"
3. Open the company picker dropdown inside the New Task dialog — each
company list badge should show the actual `issuePrefix`
4. Open the New Project dialog — the selected-company header badge
should show "OPS"
5. Open the New Goal dialog — the selected-company header badge should
show "OPS"
6. Verify that companies whose prefix matches the first 3 letters (e.g.
name="Ops Team", prefix="OPS") still display correctly

**Before/After:**
- Before: Company "Acme Labs" with `issuePrefix = "OPS"` showed badge
"ACM"
- After: Same company shows badge "OPS"

(Screenshots require running the UI locally against a test instance with
the relevant company configuration.)

## Risks

Low risk — this is a purely visual change to 3 React component badge
labels. No API changes, no schema changes, no behavioral changes to
issue creation or routing. The `issuePrefix` field is already loaded on
the company objects used by these components.

## Model Used

- **Provider:** OpenCode
- **Model:** MiMo v2.5 Free
- **Reasoning:** N/A (standard code generation)

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I searched GitHub for duplicate or related PRs and found none
targeting the same badge code
- [x] I have linked the existing issue with Fixes: #8501
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change (`fix/issue-8501`)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Hardik Dholariya 2026-08-12 05:04:42 +05:30 committed by GitHub
parent 0a95ada1be
commit 3b74ff4813
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 35 additions and 4 deletions

View File

@ -124,7 +124,7 @@ export function NewGoalDialog() {
<div className="flex items-center gap-2 text-sm text-muted-foreground">
{selectedCompany && (
<span className="bg-muted px-1.5 py-0.5 rounded text-xs font-medium">
{selectedCompany.name.slice(0, 3).toUpperCase()}
{selectedCompany.issuePrefix}
</span>
)}
<span className="text-muted-foreground/60">&rsaquo;</span>

View File

@ -1362,4 +1362,35 @@ describe("NewIssueDialog", () => {
act(() => root.unmount());
});
});
describe("PAP-8501: company badge shows issuePrefix", () => {
it("displays issuePrefix instead of name-derived prefix", async () => {
// Override company data to have mismatched name/prefix
companyState.companies = [
{
id: "company-1",
name: "Acme Labs",
status: "active",
brandColor: "#123456",
issuePrefix: "OPS",
},
];
companyState.selectedCompany = {
id: "company-1",
name: "Acme Labs",
status: "active",
brandColor: "#123456",
issuePrefix: "OPS",
};
const { root } = renderDialog(container);
await waitForAssertion(() => {
const text = container.textContent ?? "";
// Should show OPS (issuePrefix), not ACM (name.slice(0,3))
expect(text).toContain("OPS");
});
act(() => root.unmount());
});
});
});

View File

@ -1336,7 +1336,7 @@ export function NewIssueDialog() {
: undefined
}
>
{(dialogCompany?.name ?? "").slice(0, 3).toUpperCase()}
{dialogCompany?.issuePrefix ?? ""}
</button>
</PopoverTrigger>
<PopoverContent className="w-48 p-1" align="start">
@ -1366,7 +1366,7 @@ export function NewIssueDialog() {
: undefined
}
>
{c.name.slice(0, 3).toUpperCase()}
{c.issuePrefix}
</span>
<span className="truncate">{c.name}</span>
</button>

View File

@ -219,7 +219,7 @@ export function NewProjectDialog() {
<div className="flex items-center gap-2 text-sm text-muted-foreground">
{selectedCompany && (
<span className="bg-muted px-1.5 py-0.5 rounded text-xs font-medium">
{selectedCompany.name.slice(0, 3).toUpperCase()}
{selectedCompany.issuePrefix}
</span>
)}
<span className="text-muted-foreground/60">&rsaquo;</span>