From 6335748b0ed92584849ba6032306ec6f61c9edd6 Mon Sep 17 00:00:00 2001 From: cryppadotta <34892728+cryppadotta@users.noreply.github.com> Date: Sat, 12 Sep 2026 14:05:36 +0000 Subject: [PATCH 1/3] fix(ui): align property icons with avatars Co-Authored-By: Paperclip --- ui/src/components/IssueProperties.test.tsx | 6 ++++-- ui/src/components/issue-properties/IssueProperties.tsx | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ui/src/components/IssueProperties.test.tsx b/ui/src/components/IssueProperties.test.tsx index 8f72726293..32914b7466 100644 --- a/ui/src/components/IssueProperties.test.tsx +++ b/ui/src/components/IssueProperties.test.tsx @@ -130,8 +130,8 @@ vi.mock("../lib/assignees", () => ({ })); vi.mock("./StatusIcon", () => ({ - StatusIcon: ({ status, blockerAttention }: { status: string; blockerAttention?: Issue["blockerAttention"] }) => ( - {status} + StatusIcon: ({ status, blockerAttention, className }: { status: string; blockerAttention?: Issue["blockerAttention"]; className?: string }) => ( + {status} ), })); @@ -526,6 +526,8 @@ describe("IssueProperties", () => { expect(surface?.classList).toContain("pl-4"); expect(surface?.querySelectorAll('[data-property-section="true"]').length).toBeGreaterThan(1); expect(surface?.querySelector('[data-property-value="true"]')).not.toBeNull(); + expect(surface?.querySelector('[data-property-label="Status"] + [data-property-value="true"] .size-6')) + .not.toBeNull(); expect(surface?.querySelector('[data-property-section="true"] > div')?.classList) .toContain("text-muted-foreground/70"); const projectLabel = surface?.querySelector('[data-property-label="Project"]'); diff --git a/ui/src/components/issue-properties/IssueProperties.tsx b/ui/src/components/issue-properties/IssueProperties.tsx index 5904558605..b634ee0ad3 100644 --- a/ui/src/components/issue-properties/IssueProperties.tsx +++ b/ui/src/components/issue-properties/IssueProperties.tsx @@ -1944,7 +1944,7 @@ export function IssueProperties({ {projectName(issue.projectId)} @@ -2332,7 +2332,7 @@ export function IssueProperties({ onUpdate({ status })} showLabel From 6c81d8103c506ef555f3088e690cfe39bae3a167 Mon Sep 17 00:00:00 2001 From: cryppadotta <34892728+cryppadotta@users.noreply.github.com> Date: Sat, 12 Sep 2026 18:13:44 +0000 Subject: [PATCH 2/3] fix(ui): keep property status glyph at text scale Co-Authored-By: Paperclip --- ui/src/components/IssueProperties.test.tsx | 10 +++++++--- ui/src/components/issue-properties/IssueProperties.tsx | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ui/src/components/IssueProperties.test.tsx b/ui/src/components/IssueProperties.test.tsx index 32914b7466..942d5b176a 100644 --- a/ui/src/components/IssueProperties.test.tsx +++ b/ui/src/components/IssueProperties.test.tsx @@ -131,7 +131,7 @@ vi.mock("../lib/assignees", () => ({ vi.mock("./StatusIcon", () => ({ StatusIcon: ({ status, blockerAttention, className }: { status: string; blockerAttention?: Issue["blockerAttention"]; className?: string }) => ( - {status} + {status} ), })); @@ -526,8 +526,12 @@ describe("IssueProperties", () => { expect(surface?.classList).toContain("pl-4"); expect(surface?.querySelectorAll('[data-property-section="true"]').length).toBeGreaterThan(1); expect(surface?.querySelector('[data-property-value="true"]')).not.toBeNull(); - expect(surface?.querySelector('[data-property-label="Status"] + [data-property-value="true"] .size-6')) - .not.toBeNull(); + const statusVisual = surface?.querySelector( + '[data-property-label="Status"] + [data-property-value="true"] [data-testid="status-icon"]', + ); + expect(statusVisual).not.toBeNull(); + expect(statusVisual?.classList).toContain("mx-1"); + expect(statusVisual?.classList).not.toContain("size-6"); expect(surface?.querySelector('[data-property-section="true"] > div')?.classList) .toContain("text-muted-foreground/70"); const projectLabel = surface?.querySelector('[data-property-label="Project"]'); diff --git a/ui/src/components/issue-properties/IssueProperties.tsx b/ui/src/components/issue-properties/IssueProperties.tsx index b634ee0ad3..fafe4dd7bf 100644 --- a/ui/src/components/issue-properties/IssueProperties.tsx +++ b/ui/src/components/issue-properties/IssueProperties.tsx @@ -2332,7 +2332,7 @@ export function IssueProperties({ onUpdate({ status })} showLabel From 80b4143cbf638cafcf2b414f505f11d7e617e767 Mon Sep 17 00:00:00 2001 From: cryppadotta <34892728+cryppadotta@users.noreply.github.com> Date: Sat, 12 Sep 2026 18:43:22 +0000 Subject: [PATCH 3/3] test(ui): assert status glyph stays at pane scale Co-Authored-By: Paperclip --- ui/src/components/IssueProperties.test.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/src/components/IssueProperties.test.tsx b/ui/src/components/IssueProperties.test.tsx index 942d5b176a..6277c22054 100644 --- a/ui/src/components/IssueProperties.test.tsx +++ b/ui/src/components/IssueProperties.test.tsx @@ -130,8 +130,8 @@ vi.mock("../lib/assignees", () => ({ })); vi.mock("./StatusIcon", () => ({ - StatusIcon: ({ status, blockerAttention, className }: { status: string; blockerAttention?: Issue["blockerAttention"]; className?: string }) => ( - {status} + StatusIcon: ({ status, blockerAttention, className, size }: { status: string; blockerAttention?: Issue["blockerAttention"]; className?: string; size?: string }) => ( + {status} ), })); @@ -530,6 +530,7 @@ describe("IssueProperties", () => { '[data-property-label="Status"] + [data-property-value="true"] [data-testid="status-icon"]', ); expect(statusVisual).not.toBeNull(); + expect(statusVisual?.getAttribute("data-size")).toBe("md"); expect(statusVisual?.classList).toContain("mx-1"); expect(statusVisual?.classList).not.toContain("size-6"); expect(surface?.querySelector('[data-property-section="true"] > div')?.classList)