RomanNum3ral
/
paperclip
mirror of https://github.com/paperclipai/paperclip.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor(onboarding): reconcile the arc column's width comment with its width (#12875) 

The shell carried two comments arguing opposite things: the older made the case for a 64px inset and said 40px was too wide, the newer made the case for the 40px the code uses. The older one had also drifted from the code independently - it described 68px sides and a 424px column while the file used --sz-64px, a 432px column.

One comment now: 40px sides, a 480px column, the measure the connect sequence is drawn to and which the arc shares. The earlier objection is kept and marked untested, with a note that if step 1 or step 3 reads loose the fix belongs in those steps' content rather than the shared shell.

Comment-only; no behaviour change.
This commit is contained in:
Tonio 2026-09-05 00:32:48 -07:00 committed by GitHub
parent f2349990cc
commit a7ed22e3dd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
ui/src/components/OnboardingWizard.tsx
View File

@ -2508,17 +2508,23 @@ function OnboardingWizardInner({
// narrower than the next screen's makes the whole frame jump on
// Continue — which is the thing that read as "off" to begin
// with, and is more obvious once the buttons match.
// 68px sides, so the column inside the 560px frame is 424px —
// the measure the design draws every arc step to. It was 40px
// (a 480px column), which is wide enough that the two model
// tiles stretch and the name field sits under a question far
// narrower than itself.
// 40px sides, so the column inside the 560px frame is 480px:
// the measure the connect sequence is drawn to. The arc shares
// one shell, so the other steps take that measure rather than
// sitting narrower than the step between them.
//
// It has been both ways, and the objection that moved it last
// time has not been retested since it moved back. A 64px inset
// (a 432px column) was chosen because at the wider measure the
// two model tiles stretch and the name field sits under a
// question far narrower than itself. The connect step is now
// drawn to 480px, so the shell followed it. If step 1 or step 3
// reads loose, that is the reason and this is the line — but
// narrowing the shell again would put the connect step back out
// of step with its own design, so the fix would belong in those
// steps' own content rather than here.
isAgentArcStep || step === 1
? // 40px inset, not 64: the connect sequence is drawn against
// a 480px column and the arc's other steps share the shell,
// so they widen with it rather than sitting narrower than
// the step between them.
"w-(--sz-560px) max-w-full px-8 py-10 sm:px-10 sm:py-11"
? "w-(--sz-560px) max-w-full px-8 py-10 sm:px-10 sm:py-11"
: "w-full max-w-md px-8 py-12",
)}
>