fix(evals): switch public inspector panes without duplication
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
parent
bdd5b51cae
commit
d735f61815
|
|
@ -395,7 +395,19 @@ export function EvidencePanel(props: EvidencePanelProps) {
|
|||
{devtools !== undefined ? (
|
||||
<>
|
||||
{devtools === null ? (
|
||||
evalReport ? <EvalReportInspector evalReport={evalReport} /> : <p className="pit-muted pit-devtools-loading">Loading company state…</p>
|
||||
evalReport ? <>
|
||||
<div className="pit-devtools-tabs" role="tablist" aria-label="Developer tools">
|
||||
{(["eval", "evidence"] as const).map((tab) => <button
|
||||
key={tab}
|
||||
type="button"
|
||||
role="tab"
|
||||
aria-selected={devtoolsTab === tab}
|
||||
className="pit-tab"
|
||||
onClick={() => onDevtoolsTabChange(tab)}
|
||||
><span className="pit-tab-glyph"><Icon name="evidence" /></span><span>{tab === "eval" ? "Eval" : "Evidence"}</span></button>)}
|
||||
</div>
|
||||
{devtoolsTab === "eval" ? <EvalReportInspector evalReport={evalReport} /> : null}
|
||||
</> : <p className="pit-muted pit-devtools-loading">Loading company state…</p>
|
||||
) : (
|
||||
<DevtoolsInspector snapshot={devtools} onFork={onForkRevision} tab={devtoolsTab} onTabChange={onDevtoolsTabChange} evalReport={evalReport} />
|
||||
)}
|
||||
|
|
|
|||
|
|
@ -111,7 +111,7 @@ try {
|
|||
})
|
||||
.count(),
|
||||
);
|
||||
else if (payload.devtools) {
|
||||
if (payload.devtools || payload.publication) {
|
||||
const evidenceLink = page
|
||||
.locator('[data-thread-item="tool_activity"][open]')
|
||||
.first()
|
||||
|
|
@ -120,6 +120,7 @@ try {
|
|||
await evidenceLink.click();
|
||||
await expect(evidenceTab).toHaveAttribute("aria-selected", "true");
|
||||
await expect(page.locator('[data-highlighted="true"]').first()).toBeVisible();
|
||||
await expect(page.getByRole("heading", { name: "Assertions", exact: true })).toHaveCount(0);
|
||||
// Reopening the same record after selecting another tab must work too.
|
||||
await page.getByRole("tab", { name: "Eval", exact: true }).click();
|
||||
await evidenceLink.click();
|
||||
|
|
|
|||
Loading…
Reference in New Issue