From e0d46d13750baaa7b6ff98b6d380bdb21e594cc3 Mon Sep 17 00:00:00 2001
From: Dotta <34892728+cryppadotta@users.noreply.github.com>
Date: Wed, 19 Aug 2026 11:01:24 -0500
Subject: [PATCH] test(workspaces): fix runtime provision metadata assertion
 (#11707)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Thinking Path

> - Paperclip manages agent work in isolated execution workspaces.
> - Workspace operations record operation metadata and command-result
metadata separately.
> - Runtime provisioning records its provision kind in the operation
metadata.
> - One merged regression test checked that value in the command-result
metadata.
> - The production behavior was correct, but the test failed.
> - This pull request checks the provision kind in the operation
metadata.
> - The benefit is that the regression test now matches the recorder
contract.

## Linked Issues or Issue Description

Related pull request: #11706

**What happened?**

The runtime provisioning regression test expected `provisionKind` in
`result.metadata`. The recorder stores this value in the operation's
top-level `metadata`. The command-result metadata is `null` for this
case.

**Expected behavior**

The test must check `metadata.provisionKind`. It must continue to check
`result.status`.

**Steps to reproduce**

1. Check out commit `e1df4c6068fea684a1e9714ebd64bce95f3db19a`.
2. Run the focused runtime provisioning test.
3. Observe that the assertion checks the wrong metadata object.

**Paperclip version or commit**

`e1df4c6068fea684a1e9714ebd64bce95f3db19a`

**Deployment mode**

Local development.

## What Changed

- Move the `provisionKind` assertion from `result.metadata` to the
operation's top-level `metadata`.
- Keep the `result.status` assertion unchanged.

## Verification

- `pnpm --filter @paperclipai/server exec vitest run
src/__tests__/workspace-runtime.test.ts -t "keeps an explicit command
matching the built-in seed command as runtime provisioning"`
- Result: 1 test passed and 125 tests skipped.

## Risks

- Low risk. This pull request changes one test assertion and does not
change production code.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, GPT-5, high-reasoning mode, with repository, shell, Git,
GitHub, and code execution tools. The runtime does not expose a
context-window value.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

Co-authored-by: Paperclip <noreply@paperclip.ing>
---
 server/src/__tests__/workspace-runtime.test.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/server/src/__tests__/workspace-runtime.test.ts b/server/src/__tests__/workspace-runtime.test.ts
index 7f67755c2a..b469d1cc77 100644
--- a/server/src/__tests__/workspace-runtime.test.ts
+++ b/server/src/__tests__/workspace-runtime.test.ts
@@ -3965,11 +3965,11 @@ describe("ensureRuntimeServicesForRun", () => {
       expect(operations).toEqual([
         expect.objectContaining({
           phase: "workspace_runtime_provision",
+          metadata: expect.objectContaining({
+            provisionKind: "runtime_dependencies",
+          }),
           result: expect.objectContaining({
             status: "succeeded",
-            metadata: expect.objectContaining({
-              provisionKind: "runtime_dependencies",
-            }),
           }),
         }),
       ]);